Re: [quicwg/base-drafts] Use handshake bytes more consistently (#3775)

[Mike Bishop <[e-mail]>]

@MikeBishop approved this pull request.



> @@ -429,14 +430,15 @@ the packet type and keys that are used for protecting data.
 
 Each encryption level is associated with a different sequence of bytes, which is
 reliably transmitted to the peer in CRYPTO frames. When TLS provides handshake
-bytes to be sent, they are appended to the current flow. Any packet that
-includes the CRYPTO frame is protected using keys from the corresponding
-encryption level. Four encryption levels are used, producing keys for Initial,
-0-RTT, Handshake, and 1-RTT packets. CRYPTO frames are carried in just three of
-these levels, omitting the 0-RTT level. These four levels correspond to three
-packet number spaces: Initial and Handshake encrypted packets use their own
-separate spaces; 0-RTT and 1-RTT packets use the application data packet number
-space.
+bytes to be sent, they are appended to the handshake bytes for the current
+encryption level. Any packet that includes the CRYPTO frame is protected using
+keys from the corresponding encryption level.

Not new text, but this feels like it's reversed.  It's not the fact that it includes these bytes that causes a packet to use particular keys; the level of these bytes determines which packet type it must be sent in.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3775#pullrequestreview-436130428