Re: [quicwg/base-drafts] Easy RFC Editor Questions (PR #4954)

Mike Bishop <notifications@github.com> Mon, 14 February 2022 18:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C5B13A09EF for <quic-issues@ietfa.amsl.com>; Mon, 14 Feb 2022 10:45:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.666
X-Spam-Level:
X-Spam-Status: No, score=-8.666 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.576, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PVV9QoDt9nEz for <quic-issues@ietfa.amsl.com>; Mon, 14 Feb 2022 10:45:49 -0800 (PST)
Received: from smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3D00B3A087D for <quic-issues@ietf.org>; Mon, 14 Feb 2022 10:45:49 -0800 (PST)
Received: from github-lowworker-d93c4b6.va3-iad.github.net (github-lowworker-d93c4b6.va3-iad.github.net [10.48.17.47]) by smtp.github.com (Postfix) with ESMTP id CF0CD560D21 for <quic-issues@ietf.org>; Mon, 14 Feb 2022 10:45:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1644864347; bh=vLX90u3Cex2L4idGJ1pInUs6f1Sju3BkOLimXz/E4DI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=j0yGxLJeCtc9hJyLzVPzNEeVxwowTbPyajPereKavepnn6w9I+YSfxBktn/JI7rEy PLyISEkshMUHTsG56sm57NtCnoczA4bB5F+vUjcjlu8t4Q3jEqTWEhDJitzmODV+dS mESLgZ3gK3ZGQmTVbvMf6bJIyKhBV+Lz60jyI7Bw=
Date: Mon, 14 Feb 2022 10:45:47 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2P3YYFUBF6LOCPNM6AC2CFXEVBNHHEHT6N3Y@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4954/review/882042640@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4954@github.com>
References: <quicwg/base-drafts/pull/4954@github.com>
Subject: Re: [quicwg/base-drafts] Easy RFC Editor Questions (PR #4954)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_620aa35bc093d_37d5c6fc77410"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kzLrKpuI7UyK8XV_3qTY6zIN40g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Feb 2022 18:45:54 -0000

@MikeBishop commented on this pull request.

Including the actual AUTH48 questions this addresses.

> @@ -1,6 +1,5 @@
 ---
-title: Hypertext Transfer Protocol Version 3 (HTTP/3)
-abbrev: HTTP/3
+title: HTTP/3

See #4944.

> @@ -606,7 +605,7 @@ The following pseudo-header fields are defined for requests:
     {{Section 7.1 of SEMANTICS}}.
 
 All HTTP/3 requests MUST include exactly one value for the ":method", ":scheme",
-and ":path" pseudo-header fields, unless it is a CONNECT request; see
+and ":path" pseudo-header fields, unless the request is a CONNECT request; see

RFC Editor asked:
>Because HTTP/3 requests is plural, may we update this as follows?
> 
> Original:
>>  All HTTP/3 requests MUST include exactly one value for the ":method",  
>> ":scheme", and ":path" pseudo-header fields, unless it is a CONNECT  
>> request; see Section 4.2.
> 
> Perhaps A:
>>  All HTTP/3 requests MUST include exactly one value for the ":method",  
>> ":scheme", and ":path" pseudo-header fields, except for CONNECT  
>> requests; see Section 4.2.
> 
> Perhaps B:
>>  All HTTP/3 requests MUST include exactly one value for the ":method",  
>> ":scheme", and ":path" pseudo-header fields, unless the request is a 
>> CONNECT  request; see Section 4.2.


> +Implementations SHOULD cancel requests by abruptly terminating any directions of
+a stream that are still open.  To do so, an implementation resets the sending
+parts of streams and aborts reading on the receiving parts of streams; see
+{{Section 2.4 of QUIC-TRANSPORT}}.

RFC Editor asked:
> This text is a bit tricky to read with all the -ing endings.  Is there a way to rephrase?

> +receiver, or bidirectional, carrying data in both directions.  Streams can be
+initiated by either the client or the server.  For more detail on QUIC streams,
+see {{Section 2 of QUIC-TRANSPORT}}.

RFC Editor asked:
> Should this sentence be made parallel by explaining both unidirectional and bidirectional?  Or may we remove the explanatory clause as unidirectional is used several times prior to this occurrence?

I opted to parallelize, since I don't see the initiator-to-receiver direction stated elsewhere, but I'm also happy to shorten the text if it's adequately covered elsewhere.

> +to use.
+
+Each endpoint needs to create at least one unidirectional stream for the HTTP
+control stream. QPACK requires two additional unidirectional streams, and other
+extensions might require further streams. Therefore, the transport parameters
+sent by both clients and servers MUST allow the peer to create at least three
+unidirectional streams. These transport parameters SHOULD also provide at least
+1,024 bytes of flow control credit to each unidirectional stream.

RFC Editor asked:

> Which of these interpretations is correct?  Also, note that this sentence is quite long and may benefit from further rephrasing to break it up.
> 
> Original:
>> To avoid blocking, the transport parameters sent by both clients and 
>> servers MUST allow the peer to create at least one unidirectional 
>> stream for the HTTP control stream plus the number of unidirectional 
>> streams required by mandatory extensions (three being the minimum 
>> number required for the base HTTP/3 protocol and QPACK), and SHOULD 
>> provide at least 1,024 bytes of flow control credit to each stream.
> 
> Perhaps A:
>> To avoid blocking, the transport parameters sent by both clients and 
>> servers 1) MUST allow the peer to create at least one unidirectional 
>> stream for the HTTP control stream plus the number of unidirectional 
>> streams required by mandatory extensions (three being the minimum 
>> number required for the base HTTP/3 protocol and
>> QPACK) and 2) SHOULD provide at least 1,024 bytes of flow-control 
>> credit to each stream.
> 
> Perhaps B:
>> To avoid blocking, the transport parameters sent by both clients and 
>> servers MUST allow the peer to create at least one unidirectional 
>> stream for the HTTP control stream plus the number of unidirectional 
>> streams required by mandatory extensions (three being the minimum 
>> number required for the base HTTP/3 protocol and QPACK), and the peer 
>> SHOULD provide at least 1,024 bytes of flow-control credit to each 
>> stream.

> +For fomatting reasons, setting names can be abbreviated by removing the
+'SETTING_' prefix.
+

RFC Editor asked:
> We note that RFC-to-be 9114 registers names in the HTTP/3 Settings registry that are preceded by "SETTINGS_".  They also include the following note in the IANA section: 
> 
>>  For fomatting reasons, the setting names here are abbreviated by 
>> removing the  'SETTING_' prefix.
> 
> Should "MAX_FIELD_SECTION_SIZE" be registered as "SETTINGS_MAX_FIELD_SECTION_SIZE"?  
> See https://www.iana.org/assignments/http3-parameters
> 
> Should a similar note be included in the IANA text as well? 

On re-reading, this may suggest the IANA page itself should be corrected to include SETTINGS_

> +Robbie Shade and Mike Warres were the authors of draft-shade-quic-http2-mapping,
+which was the basis for this document.

RFC Editor asked:
> We believe "original authors of this specification" refers to the authors of draft-shade-quic-http2-mapping; may we clarify that here?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4954#pullrequestreview-882042640
You are receiving this because you are subscribed to this thread.

Message ID: <quicwg/base-drafts/pull/4954/review/882042640@github.com>