Re: [quicwg/base-drafts] Added normative text to invariants (#3774)

Mike Bishop <notifications@github.com> Mon, 22 June 2020 18:34 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D2BC03A107C for <quic-issues@ietfa.amsl.com>; Mon, 22 Jun 2020 11:34:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id taO_mG8NP-ej for <quic-issues@ietfa.amsl.com>; Mon, 22 Jun 2020 11:34:05 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3C08F3A1077 for <quic-issues@ietf.org>; Mon, 22 Jun 2020 11:34:05 -0700 (PDT)
Received: from github-lowworker-0f7e7fd.ash1-iad.github.net (github-lowworker-0f7e7fd.ash1-iad.github.net [10.56.110.17]) by smtp.github.com (Postfix) with ESMTP id 2EC17A07DE for <quic-issues@ietf.org>; Mon, 22 Jun 2020 11:34:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1592850844; bh=31C7i+euTIwaHrYvZSmP8zMIbMGh6BxbZMhJopfanwA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uTxgSTq9Inrspwsm1g6DviELp45kysMJxMddNuIbpreSqBxX5iIajGO+u3vRPLHqK N30JpMTRvGcCIGXPD1QxWUTGZ0wCYmDWjmvcnqU8NQYITUrDoFA+EFSBQV1W697IDd 3OUPhE7l7AH8RDd34FhnQfxtFcR/ERqk6GEGnSR0=
Date: Mon, 22 Jun 2020 11:34:04 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6SL6OGVYB57PA6RNF47TNJZEVBNHHCMMQ2BU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3774/review/435175866@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3774@github.com>
References: <quicwg/base-drafts/pull/3774@github.com>
Subject: Re: [quicwg/base-drafts] Added normative text to invariants (#3774)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ef0f99c1f72b_42573fe5140cd96813974d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/l1MPucHHiajXHmgY1YN1LVpTjuw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jun 2020 18:34:07 -0000

@MikeBishop approved this pull request.



> +# Requirements for Intermediaries
+
+An intermediary MAY observe the QUIC version in certain packets, statefully note
+the version associated with the connection IDs (see {{connection-id}}) in the
+packet, and if it understands that version, parse and process packets with one
+of those connection IDs without regard for the invariants in this document.
+
+Intermediaries MUST implement a mode that, if they cannot associate a version
+with a packet's connection ID or do not understand the associated QUIC version,
+uses only the invariant fields described in this document to execute its
+function(s). This might mean that the intermediary cannot accomplish its
+function(s) at all, or that it implements a default behavior.
+
+Intermediaries MUST NOT implement a default behavior of dropping packets of QUIC
+versions they do not understand, or packets that have a connection ID they
+cannot associate with a QUIC version.

Perhaps "MUST NOT drop packets on the basis of..." would be avoid the wiggles of "default"?

> +packet, and if it understands that version, parse and process packets with one
+of those connection IDs without regard for the invariants in this document.
+
+Intermediaries MUST implement a mode that, if they cannot associate a version
+with a packet's connection ID or do not understand the associated QUIC version,
+uses only the invariant fields described in this document to execute its
+function(s). This might mean that the intermediary cannot accomplish its
+function(s) at all, or that it implements a default behavior.
+
+Intermediaries MUST NOT implement a default behavior of dropping packets of QUIC
+versions they do not understand, or packets that have a connection ID they
+cannot associate with a QUIC version.
+
+Specifications for intermediaries SHOULD document any implicit assumptions they
+are making about endpoint behavior beyond the invariants in this document, and
+the impact if future versions of QUIC violate those assumptions.

```suggestion
the impact if future versions of QUIC do not conform to those assumptions.
```
"Violate" has a negative connotation, and behavior changes aren't something we want to discourage.

> @@ -234,7 +281,7 @@ and is not constrained by this specification.
 The remainder of the packet has version-specific semantics.
 
 
-## Connection ID
+## Connection ID {#connection-id}

Nothing wrong with doing this, but it's pointless since this would be the default anchor generated for this section title anyway.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3774#pullrequestreview-435175866