Re: [quicwg/base-drafts] Use time_of_last_sent_packet (#923)
ianswett <notifications@github.com> Tue, 28 November 2017 14:25 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3FB92127A91 for <quic-issues@ietfa.amsl.com>; Tue, 28 Nov 2017 06:25:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.395
X-Spam-Level:
X-Spam-Status: No, score=-3.395 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q1G0UFUPR5Sx for <quic-issues@ietfa.amsl.com>; Tue, 28 Nov 2017 06:25:09 -0800 (PST)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AFBA2127011 for <quic-issues@ietf.org>; Tue, 28 Nov 2017 06:25:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=cpZGVU0pNReFg85FvXGAahwlfTE=; b=UR3cUcw0/Xfu+YAM 6nqJMowUbMprCgCkHJPtwRC+BXAy3kos5XO110jO9tnDPW+vzjUP9b4aHqYbQPcy d3+1cntj4T5Z/FWylM0ZDquxSZVJ23TiuGl3cO7Au5mqvQHDe2TnO4Rw3LNpDfbi T4qJhn+vbqhv451WKNqH7JDU8rU=
Received: by filter0535p1las1.sendgrid.net with SMTP id filter0535p1las1-13240-5A1D71B0-7 2017-11-28 14:24:48.171853097 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0003p1iad2.sendgrid.net (SG) with ESMTP id iz8AHcsHSmmb_iQRhDYpvA for <quic-issues@ietf.org>; Tue, 28 Nov 2017 14:24:48.147 +0000 (UTC)
Date: Tue, 28 Nov 2017 14:24:48 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb629f9fca543ad5ffd7b32e150c8cf672474e2e192cf00000001163533af92a169ce104aa7af@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/923/review/79519872@github.com>
In-Reply-To: <quicwg/base-drafts/pull/923@github.com>
References: <quicwg/base-drafts/pull/923@github.com>
Subject: Re: [quicwg/base-drafts] Use time_of_last_sent_packet (#923)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a1d71afec988_ac313fd293744f28181031"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
tracking:
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0CWIO3HmVTpmHPVJ1Xa2JGVUcqj29YdGbs3i jJP0f224iJ4bsHDkDRAF+qK2MHOTF6s9s94NddVRHrMMhD//1iPBUqrriAdU4RhMcd4EF3A1snh6lw x2WwW3XLW5rAkt6c6RUstFKrBwmzM1dcEv/gJHuZ0JJ5Ulhywwejwf64aA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lHo4_lNcwN7jP9UYyRZ_WsPfLMI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2017 14:25:10 -0000
ianswett commented on this pull request.
> @@ -701,7 +701,8 @@ Pseudocode for SetLossDetectionAlarm follows:
alarm_duration = max(alarm_duration, kMinRTOTimeout)
alarm_duration = alarm_duration * (2 ^ rto_count)
- loss_detection_alarm.set(now + alarm_duration)
+ loss_detection_alarm.set(time_of_last_sent_packet
That's a good point, given the other packets are not decryptable, and hence will not generate an acknowledgement until the handshake completes, #962 filed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/923#discussion_r153505505
- [quicwg/base-drafts] Use time_of_last_sent_packet… ianswett
- Re: [quicwg/base-drafts] Use time_of_last_sent_pa… Mike Bishop
- Re: [quicwg/base-drafts] Use time_of_last_sent_pa… Subodh Iyengar
- Re: [quicwg/base-drafts] Use time_of_last_sent_pa… Subodh Iyengar
- Re: [quicwg/base-drafts] Use time_of_last_sent_pa… Subodh Iyengar
- Re: [quicwg/base-drafts] Use time_of_last_sent_pa… Lars Eggert
- Re: [quicwg/base-drafts] Use time_of_last_sent_pa… ianswett
- Re: [quicwg/base-drafts] Use time_of_last_sent_pa… janaiyengar
- Re: [quicwg/base-drafts] Use time_of_last_sent_pa… janaiyengar