Re: [quicwg/base-drafts] Only applications know what can be retried (#2460)

Jana Iyengar <notifications@github.com> Fri, 22 February 2019 02:58 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A0974128B01 for <quic-issues@ietfa.amsl.com>; Thu, 21 Feb 2019 18:58:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3
X-Spam-Level:
X-Spam-Status: No, score=-3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2A1RUigVmN1J for <quic-issues@ietfa.amsl.com>; Thu, 21 Feb 2019 18:58:25 -0800 (PST)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 66EEB1288BD for <quic-issues@ietf.org>; Thu, 21 Feb 2019 18:58:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=+0+H/fMnGX5qdrmzXNIR4fxG7+k=; b=YM/76OB+umZl1kt2 TLEWBiKfasy9vsMnyQQ7AO/j4LbjzvNvyUhZ/hOfQv7WeQRzgXL6I9+Vz+uIkV8i 74VR3jWbHib2gaa7RyMrU6FzNqPGGVi/11Pfl0lo3RHrM4XzsijSNl7BS4wzzcLK Cg52hcTVwnhJaa/CMD88oE/jl7k=
Received: by filter0612p1iad2.sendgrid.net with SMTP id filter0612p1iad2-28377-5C6F6550-2 2019-02-22 02:58:24.065450246 +0000 UTC m=+5997.481672626
Received: from github-lowworker-cef7735.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0050p1iad1.sendgrid.net (SG) with ESMTP id 5JS1LTNaRcWqiDUuuH_kEQ for <quic-issues@ietf.org>; Fri, 22 Feb 2019 02:58:23.966 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-cef7735.cp1-iad.github.net (Postfix) with ESMTP id E8B941E0799 for <quic-issues@ietf.org>; Thu, 21 Feb 2019 18:58:23 -0800 (PST)
Date: Fri, 22 Feb 2019 02:58:24 +0000
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0cd3257fa07e2fcfed782dab5140f8389c0f3e6192cf000000011887274f92a169ce18697e5e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2460/review/206640170@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2460@github.com>
References: <quicwg/base-drafts/pull/2460@github.com>
Subject: Re: [quicwg/base-drafts] Only applications know what can be retried (#2460)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c6f654fe73ea_28383f84462d45c41057f8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1x48mSHUSqR+KVRtWVQ6DZoBdYzRkcHdH2Ed YuOskrJN82EDpfxRt/sn0Y95JBMjiXOagjoUizoI6PHjKPAT/jlAX7bK3u+XcvOmZC7GGF4PbjJ1Ug sXKPcJD3HAzvGeC0TuZ1uKo7FlpjA1QoDLMI8mMMr11277jTn4WrmxwOhXN5L2Ri5IAx+F78pWRGYR Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/m53wCs-31QiBR5_yTgDNstVB58c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Feb 2019 02:58:27 -0000

janaiyengar approved this pull request.

LGTM, one nit. ("using applications" is fine, it's just a bit awkward.)

> @@ -2211,7 +2211,9 @@ endpoint.  An endpoint that sends packets near the end of the idle timeout
 period of a peer risks having those packets discarded if its peer enters the
 draining state before the packets arrive.  If a peer could timeout within an
 Probe Timeout (PTO, see Section 6.2.2 of {{QUIC-RECOVERY}}), it is advisable to
-test for liveness before sending any data that cannot be retried safely.
+test for liveness before sending any data that cannot be retried safely.  Note
+that it is likely that only application protocols or using applications will

```suggestion
that it is likely that only applications or application protocols will
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2460#pullrequestreview-206640170