IETF Logo Mail Archive

Re: [quicwg/base-drafts] ChaCha inputs (#2171)

Martin Thomson <notifications@github.com> Mon, 26 August 2019 10:30 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BFA5A1200EC for <quic-issues@ietfa.amsl.com>; Mon, 26 Aug 2019 03:30:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0JewIhlAyW4r for <quic-issues@ietfa.amsl.com>; Mon, 26 Aug 2019 03:30:28 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2C98512001E for <quic-issues@ietf.org>; Mon, 26 Aug 2019 03:30:28 -0700 (PDT)
Date: Mon, 26 Aug 2019 03:30:27 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566815427; bh=s0hgy18xgmrPqN1baznFnwU14JwoCxbd1o3Am76DjZ8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Rxt8yESgrfsoyp3ARKG7uPnayFpGR3MiRjD8TJup5CrmTVKbv3kdrr9riw0CT8zrT CfT/jSiMW9uWsxstYYy7UYIxwElEliNm43Q6Uep4c2kAcYhwZ8G0Pt8mJWJSa1w6Bu ig0+zGRvMyhAQSZSMM1zNC9/PehU8K4xEKrilBI8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ56A6C7MX3ZS4YJX53ODTUHEVBNHHBOTHDPI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2171/524809410@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2171@github.com>
References: <quicwg/base-drafts/issues/2171@github.com>
Subject: Re: [quicwg/base-drafts] ChaCha inputs (#2171)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d63b4c34c632_79f13f87618cd96c28415"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nc7oouX0qMckJbklbAd7a2tebVc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Aug 2019 10:30:30 -0000

I don't think that the reinterpretation of the little-endian thing is safe, as per @mikkelfj's comment.

The [PKCS#11 interface](https://docs.oasis-open.org/pkcs11/pkcs11-curr/v3.0/csprd01/pkcs11-curr-v3.0-csprd01.html#_Toc10561273) takes a byte buffer as input rather than a `uint32_t`.  That is to allow for different block counter sizes.  I'll make the editorial change, but leave the suggestion there alone.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2171#issuecomment-524809410

v2.23.0 | Report a Bug | By Email