Re: [quicwg/base-drafts] Define RTT (#2362)

Martin Thomson <notifications@github.com> Wed, 23 January 2019 04:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4FE8B130E0A for <quic-issues@ietfa.amsl.com>; Tue, 22 Jan 2019 20:00:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KqSSVrKqm-ws for <quic-issues@ietfa.amsl.com>; Tue, 22 Jan 2019 20:00:05 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 91F41130DFA for <quic-issues@ietf.org>; Tue, 22 Jan 2019 20:00:05 -0800 (PST)
Date: Tue, 22 Jan 2019 20:00:04 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548216004; bh=XUITXfHg6gxG0HTQAp4YgKGsXZ2qUu5F5aLa6fF6WR0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hjC8lHVxPa8yhmmktmBkIUCpDIWaQ3n3JB6T4ZE7FL0LFD8Vv9KqPLs45mVITetJm jxGdspasw3QM0C+2jd4k+QXNnf8k/uw295s8h18uxTQEElvCZ+KRK3W05Qp9xLrZpd 3xlE7kPq/5yjnZA7GHD4d8PWfKIEzLJYzssvaN5M=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab88e5d2b06e067eb3da9217efcf622dd6c3ec0c4792cf00000001185fa8c492a169ce17f65f56@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2362/review/195339003@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2362@github.com>
References: <quicwg/base-drafts/pull/2362@github.com>
Subject: Re: [quicwg/base-drafts] Define RTT (#2362)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c47e6c475158_4eef3fe6fc2d45c4770761"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/oYjC95TraGVSd22sc6m4NbtiQrY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2019 04:00:07 -0000

martinthomson commented on this pull request.



> @@ -293,10 +293,10 @@ continue making forward progress.
 
 # Computing the RTT estimate
 
-RTT is calculated when an ACK frame arrives by computing the difference between
-the current time and the time the largest acked packet was sent.  An RTT sample
-MUST NOT be taken for a packet that is not newly acknowledged or not
-ack-eliciting.
+Round trip time, abbreviated RTT, is calculated when an ACK frame arrives by

```suggestion
Round trip time (RTT) is calculated when an ACK frame arrives by
```

Just make sure that you add the parenthetical the first time you see the acronym.  If that is prior to this section in the document, then you probably need to expand the first usage as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2362#pullrequestreview-195339003