Re: [quicwg/base-drafts] Alternative Largest Reference Decoding algorithm. (#2248)
Bence Béky <notifications@github.com> Mon, 24 December 2018 13:55 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1F694130EED for <quic-issues@ietfa.amsl.com>; Mon, 24 Dec 2018 05:55:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.086
X-Spam-Level:
X-Spam-Status: No, score=-7.086 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jo7lswDBMMQH for <quic-issues@ietfa.amsl.com>; Mon, 24 Dec 2018 05:55:54 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 372F5130ED9 for <quic-issues@ietf.org>; Mon, 24 Dec 2018 05:55:54 -0800 (PST)
Date: Mon, 24 Dec 2018 05:55:53 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545659753; bh=hmJTNEnHW8nQQCF50VcE9eBR8b79LKq09SrO5vKz4ss=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=gE4jGuxYZQEH1WSdlkK/4JLeyAVaGfO+LV3bR3WrH7pqn6nzZBd4/TisAxPFVPj8r Ugk0QivEZiohzwtUg3Vo45GivEQnIgz3nnjWP6EXM8NSc18SmDpQsLDqKM0raYbD2C uwdtZqQU/ujVnIVFqdMmKbh8J8bn1brNly7Vk1wc=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab34a3685c199351ec08b826b913edc0e3db444dd392cf000000011838a76992a169ce17789b2a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2248/c449737179@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2248@github.com>
References: <quicwg/base-drafts/pull/2248@github.com>
Subject: Re: [quicwg/base-drafts] Alternative Largest Reference Decoding algorithm. (#2248)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c20e5694c476_3d273fe8470d45c09042cd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qUkwTiL40i7uLXX0x3EQnR0zaK4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Dec 2018 13:55:56 -0000
> The problem with code like this is that it is indecipherable. It's short, but I don't think that it improves readability much. Not that this code is ever readable... I appreciate your concern. Indeed if one is focused on the mechanics of how the decoder or Largest Reference wraps around and what that does to different quantities, the current code is easier to read. On the other hand, if you focus on the requirement that "Largest Reference is the unique integer that is congruent with wire Largest Reference - 1 modulo 2 * MaxEntries and falls in the interval [TotalNumberOfInserts - MaxEntries, TotalNumberOfInserts + MaxEntries)", then the proposed code is easier to read. So I believe readability is largely dependent on the mental model that readers have in their heads. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2248#issuecomment-449737179
- [quicwg/base-drafts] Alternative Largest Referenc… Bence Béky
- Re: [quicwg/base-drafts] Alternative Largest Refe… Bence Béky
- Re: [quicwg/base-drafts] Alternative Largest Refe… Martin Thomson
- Re: [quicwg/base-drafts] Alternative Largest Refe… Bence Béky
- Re: [quicwg/base-drafts] Alternative Largest Refe… Bence Béky
- Re: [quicwg/base-drafts] Alternative Largest Refe… Bence Béky