IETF Logo Mail Archive

Re: [quicwg/base-drafts] remove misleading sentence about incompatible QUIC versions and ALPN (#2802)

Mike Bishop <notifications@github.com> Tue, 27 August 2019 22:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9C36712012E for <quic-issues@ietfa.amsl.com>; Tue, 27 Aug 2019 15:19:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PKy0Vjrd8Cof for <quic-issues@ietfa.amsl.com>; Tue, 27 Aug 2019 15:19:15 -0700 (PDT)
Received: from out-9.smtp.github.com (out-9.smtp.github.com [192.30.254.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 563C312004D for <quic-issues@ietf.org>; Tue, 27 Aug 2019 15:19:15 -0700 (PDT)
Date: Tue, 27 Aug 2019 15:19:14 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566944355; bh=pFsZIouQaGC1R34qPPiWHjMDjBzL1IKLMdrjC/wpu64=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bKhuNUYREbTeynkxUZN0Zy3fYT/Qq6KEOZ59fcOJG0izuBj70gZOhLFRW1ZNJaOg0 5/RvYHrpKrqQe7ASd+1qWMEWtUb8DFfh8Zey2oYzROhtoyfJSx26AUA5vS06UZX8V+ DBruhoXxw3SyhoGGI7DDtpvopW+XddheQ4g6dS/Y=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5YBDMYGCZKN3ZRMLN3OLWPFEVBNHHBWRDWHA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2802/review/280502714@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2802@github.com>
References: <quicwg/base-drafts/pull/2802@github.com>
Subject: Re: [quicwg/base-drafts] remove misleading sentence about incompatible QUIC versions and ALPN (#2802)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d65ac62e1369_a943fb1e4ccd960141654"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rw3S93NlAsRyjbFjg83rYi0YnYg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Aug 2019 22:19:17 -0000

MikeBishop requested changes on this pull request.

I think removing the sentence entirely is the wrong approach.

> @@ -1279,8 +1279,7 @@ An application-layer protocol MAY restrict the QUIC versions that it can operate
 over.  Servers MUST select an application protocol compatible with the QUIC
 version that the client has selected.  If the server cannot select a compatible
 combination of application protocol and QUIC version, it MUST abort the
-connection. A client MUST abort a connection if the server picks an incompatible
-combination of QUIC version and ALPN identifier.

This requirement is still true.  If you object to the implication of the server picking a version, maybe this should be "A client MUST abort a connection if the server picks an application protocol incompatible with the protocol version being used."?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2802#pullrequestreview-280502714

v2.23.0 | Report a Bug | By Email