Re: [quicwg/base-drafts] QPACK wording fix: decoders dont receive resets (#2014)

Dmitri Tikhonov <notifications@github.com> Sat, 17 November 2018 02:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 54EFB128CF2 for <quic-issues@ietfa.amsl.com>; Fri, 16 Nov 2018 18:28:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m3-TPK1sf7Fv for <quic-issues@ietfa.amsl.com>; Fri, 16 Nov 2018 18:28:29 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4DD1D126CB6 for <quic-issues@ietf.org>; Fri, 16 Nov 2018 18:28:29 -0800 (PST)
Date: Fri, 16 Nov 2018 18:28:28 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542421708; bh=dH6/MGKGXXXfkRxCgIGELLy0gWtErkE4wvupP99Ny4k=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=KSU/7uM6Ufac+IeR6bgjUPYos3f3yUPsG+EeNUk6Vy4VxtDSwQoWWYZfX9zQjgmWZ n00GXql3Jd1UH6lENmznMJ1qzkMlrWwLbMeJQqoxyVtTgiR3+Ufk6azec+CZlI6UhQ FBWNY70Bog3ZYLRFzOSEGjxpL/eUptP0L7Y8RiQA=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5cd59126975163209badac4976c666282f60160d92cf0000000118073ecc92a169ce16c08c68@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2014/review/176036773@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2014@github.com>
References: <quicwg/base-drafts/pull/2014@github.com>
Subject: Re: [quicwg/base-drafts] QPACK wording fix: decoders dont receive resets (#2014)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bef7ccc3378c_62d63ff2074d45c09669c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/so94dFcP4YlNrmgIKYXXXMt3V7g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Nov 2018 02:28:31 -0000

dtikhonov commented on this pull request.



> @@ -668,13 +668,14 @@ Largest Known Received.
 ### Stream Cancellation
 
 A stream that is reset might have multiple outstanding header blocks with
-dynamic table references.  A decoder that receives a stream reset before the end
-of a stream generates a Stream Cancellation instruction on the decoder stream.
-Similarly, a decoder that abandons reading of a stream needs to signal this
-using the Stream Cancellation instruction.  This signals to the encoder that all
-references to the dynamic table on that stream are no longer outstanding.  A
-decoder with a maximum dynamic table size equal to zero MAY omit sending Stream
-Cancellations, because the encoder cannot have any dynamic table references.
+dynamic table references.  An endpoint that receives a stream reset before
+the end of a stream generates a Stream Cancellation instruction on the
+decoder stream.  Similarly, a decoder that abandons reading of a stream needs

Good point -- I'll modify this part as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2014#discussion_r234392841