Re: [quicwg/base-drafts] ignore the ack delay in Initial and Handshake packets (#2676)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.

Seems reasonable to me.

Throughout here, should we be using "peer" or "receiver"?

(The suggestions I make here are not issues with this change, but I'm sure that @ianswett or @janaiyengar will find them a home.)

> @@ -387,18 +387,21 @@ smoothed_rtt is an exponentially-weighted moving average of an endpoint's RTT
 samples, and rttvar is the endpoint's estimated variance in the RTT samples.
 
 smoothed_rtt uses path latency after adjusting RTT samples for peer-reported

```suggestion
The calculation of smoothed_rtt uses path latency after adjusting RTT samples for```

> @@ -387,18 +387,21 @@ smoothed_rtt is an exponentially-weighted moving average of an endpoint's RTT
 samples, and rttvar is the endpoint's estimated variance in the RTT samples.
 
 smoothed_rtt uses path latency after adjusting RTT samples for peer-reported
-host delays ({{host-delay}}).  A peer limits any delay in sending an
-acknowledgement for an ack-eliciting packet to no greater than the advertised
-max_ack_delay transport parameter.  Consequently, when a peer reports an Ack
-Delay that is greater than its max_ack_delay, the delay is attributed to reasons
-out of the peer's control, such as scheduler latency at the peer or loss of
-previous ACK frames.  Any delays beyond the peer's max_ack_delay are therefore
-considered effectively part of path delay and incorporated into the smoothed_rtt
-estimate.
+host delays ({{host-delay}}).  For packets sent in the ApplicationData packet
+number space, a peer limits any delay in sending an acknowledgement for an
+ack-eliciting packet to no greater than the advertised max_ack_delay transport

```suggestion
ack-eliciting packet to no greater than the value it advertises in the max_ack_delay transport
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2676#pullrequestreview-234876361