[quicwg/base-drafts] bytes_in_flight update issue (#2009)

Lars Eggert <notifications@github.com> Thu, 15 November 2018 14:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 443A4129385 for <quic-issues@ietfa.amsl.com>; Thu, 15 Nov 2018 06:05:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NuVoKlSbvWzv for <quic-issues@ietfa.amsl.com>; Thu, 15 Nov 2018 06:05:02 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AD627128CFD for <quic-issues@ietf.org>; Thu, 15 Nov 2018 06:05:02 -0800 (PST)
Date: Thu, 15 Nov 2018 06:05:01 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542290701; bh=lpeauvToLPm6T4x64ENVClox5SpCC6Ka5oip8sk8U84=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=1n2E02KjzknqKJF2FeUORC7FCWph1fxbdd+ESQ+6bc1RukTvzT5VJVChekNxOMeJf ncpfGyMqtX/80FAOU0XA4LrMvKm9gbaiGhlsiQV7wKbQHYrZjxalMW3lYY+SBsY/6c 0Z6uiGLojdOurhd4b3Q27n+/gbxdjCpnoz3AhEEY=
From: Lars Eggert <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc25dac037714b78dcbaea24a887474e980ab164592cf0000000118053f0d92a169ce16b845fa@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2009@github.com>
Subject: [quicwg/base-drafts] bytes_in_flight update issue (#2009)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bed7d0dd664c_bb73fe96eed45bc675945"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: larseggert
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/v5v-3rMOxq5ggt69eEq_2vDJ_K8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Nov 2018 14:05:04 -0000

I think the following issue exists in the pseudo code:

For a new ACK block, `OnAckReceived()` first calls `OnPacketAcked()`, where `OnPacketAckedCC()` reduces `bytes_in_flight` by the sizes of whichwever packets were ACKed.

Then,`OnAckReceived()` calls `DetectLostPackets()`,  which reduces `bytes_in_flight` for every packet that it determines to be lost. That can cause `bytes_in_flight` to become zero.

Next, `SetLossDetectionTimer()` is called. The first thing that does is to cancel the `loss_detection_timer` when `bytes_in_flight` is zero.

So when and how are the packets that were declared lost retransmitted?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2009