[quicwg/base-drafts] 19ee6d: lost_pn can no longer go negative

ianswett <noreply@github.com> Wed, 17 April 2019 19:29 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 066C2120131 for <quic-issues@ietfa.amsl.com>; Wed, 17 Apr 2019 12:29:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BUJQAGMXAQpo for <quic-issues@ietfa.amsl.com>; Wed, 17 Apr 2019 12:29:14 -0700 (PDT)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E5A812003E for <quic-issues@ietf.org>; Wed, 17 Apr 2019 12:29:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:to:subject:mime-version:content-type:content-transfer-encoding; s=s20150108; bh=9qN1oju3cuD9HXzeI+Xy2UkoQxw=; b=wVYcLR0PRmdSFKEQ 2V/tgzLxifgO8eXnUSnj4PpWMGuyTt8uB82UR2Q9OP9yyQGtwR7pInAFDMDHLz9w eAUMKqRg5qtqT2todtp+b9gJm4S1TFZaRRTm7Yo7Z3tmMnk8EH3fHK4ZPSVdClQn yxdqZHfeWDxWXqvwWgvi48ccjh4=
Received: by filter1862p1mdw1.sendgrid.net with SMTP id filter1862p1mdw1-29877-5CB77E87-1A 2019-04-17 19:29:11.762638867 +0000 UTC m=+761719.928983423
Received: from github-lowworker-89d05ac.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0041p1mdw1.sendgrid.net (SG) with ESMTP id tNaClTRKRZy48IXTX-Ca2Q for <quic-issues@ietf.org>; Wed, 17 Apr 2019 19:29:11.724 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-89d05ac.cp1-iad.github.net (Postfix) with ESMTP id 81D5CAE0430 for <quic-issues@ietf.org>; Wed, 17 Apr 2019 12:29:11 -0700 (PDT)
Date: Wed, 17 Apr 2019 19:29:12 +0000 (UTC)
From: ianswett <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/ianswett-lost-pn/12bc31-dd1cb3@github.com>
Subject: [quicwg/base-drafts] 19ee6d: lost_pn can no longer go negative
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0LaPKZwSGWhb/l7chbmLHdVD7S1OC7iDPGjA HNsKiaddd6qdwGbpozt+9hzBw+qund42Ho+pq0xY4p1bvZnco5DcIC3/BgHTcdB7EPc/Iul5iiBa54 hCMRDEwX3WyXRVyTsk6OhYktxYEVLQUEhpKaZe5PiJFW9umYCkxNMlnvSA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/w3CRQC7j6XGNwcjBAr7RgmWhEqc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Apr 2019 19:29:16 -0000

  Branch: refs/heads/ianswett-lost-pn
  Home:   https://github.com/quicwg/base-drafts
  Commit: 19ee6d735c8c8085db713b881bf7e54123d65b63
      https://github.com/quicwg/base-drafts/commit/19ee6d735c8c8085db713b881bf7e54123d65b63
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2019-04-15 (Mon, 15 Apr 2019)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  lost_pn can no longer go negative

And 0 is a valid packet number, so defaulting largest_acked_packet to 0 is inherently incorrect.

Fixes #2611


  Commit: dd1cb399e373b118e49b60274a2cf5036c2a02d9
      https://github.com/quicwg/base-drafts/commit/dd1cb399e373b118e49b60274a2cf5036c2a02d9
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2019-04-17 (Wed, 17 Apr 2019)

  Changed paths:

  Log Message:
  -----------
  Merge branch 'ianswett-no-crypto-data' into ianswett-lost-pn


Compare: https://github.com/quicwg/base-drafts/compare/12bc3155910e...dd1cb399e373