IETF Logo Mail Archive

Re: [quicwg/base-drafts] DCID in short headers (#2991)

ianswett <notifications@github.com> Tue, 27 August 2019 05:20 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9E0321200E0 for <quic-issues@ietfa.amsl.com>; Mon, 26 Aug 2019 22:20:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W9gSkIBAf96X for <quic-issues@ietfa.amsl.com>; Mon, 26 Aug 2019 22:20:52 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B41D7120F02 for <quic-issues@ietf.org>; Mon, 26 Aug 2019 22:20:52 -0700 (PDT)
Date: Mon, 26 Aug 2019 22:20:51 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566883251; bh=X0btZFQR8o/+57C7P5grjrsw+i0OysB+RB/iQVwju64=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=THq5lkFMsAl5BgcY2O2YgPQVP1EZjsmKhEbyahXS/RuxyoyDs7LOZDRL3/67f8ypV c5q1M4DAr5V+1VxIOKx5RUv0OzF0WkN9zQOc/kMJVagfgdAKTwA7dOfXv+raCH0+Uf TAWsISUNKLCOmGbrvfxdD98YJLzp9WgszkgPg0+Y=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3JV2PLSFS4BTCB2UF3OH7EHEVBNHHBZ2ZTJY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2991/review/279959609@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2991@github.com>
References: <quicwg/base-drafts/pull/2991@github.com>
Subject: Re: [quicwg/base-drafts] DCID in short headers (#2991)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d64bdb3c28e1_5ac53f89aa2cd9681611fa"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wlYMP8OvxLcEbUrpvb_d7drf5I4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Aug 2019 05:20:55 -0000

ianswett approved this pull request.

One editorial suggestion, but LG

> @@ -194,9 +194,10 @@ version-specific semantics are marked with an X.
 
 A QUIC packet with a short header has the high bit of the first byte set to 0.
 
-A QUIC packet with a short header includes a Destination Connection ID.  The
-short header does not include the Connection ID Lengths, Source Connection ID,
-or Version fields.
+A QUIC packet with a short header includes a Destination Connection ID
+immediately following the first byte.  The short header does not include the
+Connection ID Lengths, Source Connection ID, or Version fields.  The length of
+the Destination Connection ID is not constrained in packets with a short header.

```suggestion
the Destination Connection ID is not specified or constrained in packets with a short header.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2991#pullrequestreview-279959609

v2.23.0 | Report a Bug | By Email