Re: [quicwg/base-drafts] Error code to be sent when the size of request headers exceed server's limit (#2775)

ianswett <notifications@github.com> Fri, 07 June 2019 11:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9D32B1200D5 for <quic-issues@ietfa.amsl.com>; Fri, 7 Jun 2019 04:44:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.878
X-Spam-Level:
X-Spam-Status: No, score=-6.878 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.415, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Grqc-jsYCJSJ for <quic-issues@ietfa.amsl.com>; Fri, 7 Jun 2019 04:44:25 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E1F021200E5 for <quic-issues@ietf.org>; Fri, 7 Jun 2019 04:44:24 -0700 (PDT)
Date: Fri, 07 Jun 2019 04:44:23 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1559907863; bh=Tlx+r1yDqMXaapcdRmU19ILTMjAIPOaRFWLWPtpoJls=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eIPFIRKoYLdDgbncXy/CZ8ji8uvyc7rLLIyJaTUFGxRygQpZDaubMbqPMFA0kPlkS hg1r9k/RNsR1bkt8CWLwIkM7CjlNiwUAOT96qI7M1u0P0NR1Cm5/UAWjxixGQMPNCH QhEJW4jySP7XA3R/eVJyF6P7R3MZZkFqbUCO/uqA=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7FQP6DDTS2ECPAODF3A6AJPEVBNHHBWBH5ZM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2775/499854386@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2775@github.com>
References: <quicwg/base-drafts/issues/2775@github.com>
Subject: Re: [quicwg/base-drafts] Error code to be sent when the size of request headers exceed server's limit (#2775)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cfa4e1799399_7e4e3fee57ccd96046644a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/wngyPl6YAm_oGHYNrgRsVqeKPPQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jun 2019 11:44:27 -0000

I agree, HTTP_EXCESSIVE_LOAD seems like the wrong error code here.

HTTP_GENERAL_PROTOCOL_ERROR or HTTP_REQUEST_REJECTED would be better.

Did you have an HTTP status code in mind for this case?  I believe HTTP status codes should be consistent across HTTP versions, so If neither HTTP or HTTP/2 are sending back a status code for this case, an HTTP/3 error code seems more appropriate.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2775#issuecomment-499854386