[quicwg/base-drafts] e4123f: Perform stateless reset token comparisons in const...

Martin Thomson <noreply@github.com> Tue, 27 August 2019 03:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DBCC81200F9 for <quic-issues@ietfa.amsl.com>; Mon, 26 Aug 2019 20:29:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7
X-Spam-Level:
X-Spam-Status: No, score=-7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OLqw3nRw2apP for <quic-issues@ietfa.amsl.com>; Mon, 26 Aug 2019 20:29:17 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D8221200F8 for <quic-issues@ietf.org>; Mon, 26 Aug 2019 20:29:17 -0700 (PDT)
Date: Mon, 26 Aug 2019 20:29:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566876556; bh=6TnxerMB/Kxq+v7wxnsW/5EivxnVtxtQaG1QRsLJEGI=; h=Date:From:To:Subject:From; b=ABpt6TfJaOsN7T4jypuLgNlFX+JAvrnBGy1Re4eBX9k1n4F51QfiUTAUr6YokLZQ7 brC6VngpMxPs3l+Y8RJ3VX1BUrZrcTmyJe3Sc+gbhOAxltylzUAFQXH0GUZECN1r+H gdAnMHlETwsAmbk2sMZdlObaQ5xhgynnMbslfnzU=
From: Martin Thomson <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/ct-sr/000000-e4123f@github.com>
Subject: [quicwg/base-drafts] e4123f: Perform stateless reset token comparisons in const...
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/x1LpDhOoYoibe9qFXWdt_xuMOlA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Aug 2019 03:29:19 -0000

  Branch: refs/heads/ct-sr
  Home:   https://github.com/quicwg/base-drafts
  Commit: e4123fc84870a688212a82b48fec71cc44d729ab
      https://github.com/quicwg/base-drafts/commit/e4123fc84870a688212a82b48fec71cc44d729ab
  Author: Martin Thomson <martin.thomson@gmail.com>
  Date:   2019-08-27 (Tue, 27 Aug 2019)

  Changed paths:
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Perform stateless reset token comparisons in constant time

Otherwise information about the token might leak.

As @mikkelfj says, there is no strict need to compare across the entire
set of values.  That could leaks two things: that the inbound packet was
dropped and the total number of stateless reset tokens.  Both are things
that we might care about, but will probably find prohibitive to protect.

Closes #2152.