IETF Logo Mail Archive

Re: [quicwg/base-drafts] PADDING frames consume congestion window (#4415)

kixelated <notifications@github.com> Mon, 30 November 2020 23:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D50B13A1263 for <quic-issues@ietfa.amsl.com>; Mon, 30 Nov 2020 15:12:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1tGeRHI4VNGr for <quic-issues@ietfa.amsl.com>; Mon, 30 Nov 2020 15:12:58 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6B9053A074E for <quic-issues@ietf.org>; Mon, 30 Nov 2020 15:12:58 -0800 (PST)
Received: from github.com (hubbernetes-node-a0ec7a8.va3-iad.github.net [10.48.18.66]) by smtp.github.com (Postfix) with ESMTPA id ABB49E1E60 for <quic-issues@ietf.org>; Mon, 30 Nov 2020 15:12:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1606777977; bh=8hsHNKOEJHRVZMyRgBAHvI8xUvvU0vpFUzg8atDRmHs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XNXC6iqZRVajdXfBXkWE3c5Gk6CZ7v0swAyy9QgxUWq9XPGsN3tYjDH+gmhJV9NuY amhwZJREEbYAYx6KUPS/V8sGFkWQGgl6MIJOC0oBH4sfUzSjdjn/9437ZQV5IodZud u9r2huv/HngtsWuul9MYL4d3u2w9kcfNQUmVIcoM=
Date: Mon, 30 Nov 2020 15:12:57 -0800
From: kixelated <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3MIZQUNMSOSZJPONF52FOXTEVBNHHCZ3ZIFU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/4415/736111325@github.com>
In-Reply-To: <quicwg/base-drafts/issues/4415@github.com>
References: <quicwg/base-drafts/issues/4415@github.com>
Subject: Re: [quicwg/base-drafts] PADDING frames consume congestion window (#4415)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5fc57c79a8e1d_4b19b412932e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kixelated
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/x7gRay7kS-9bFE7YUiaUg8J3ElY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Nov 2020 23:13:00 -0000

I think that this hypothetical congestion control algorithm should use PING-only packets instead of PADDING-only packets. I don’t think there’s any reason to have this special case and dangerous support for non-congestion-controlled PADDING-only frames.

In general, only ack-eliciting packets should contribute to the congestion control window. Frames like ACK and PADDING do not trigger an acknowledgement to free the congestion control window, so they should not consume it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/4415#issuecomment-736111325

v2.23.0 | Report a Bug | By Email