Re: [quicwg/base-drafts] Add table to show what frames go on what streams (#2419)

Mike Bishop <notifications@github.com> Tue, 05 February 2019 22:03 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 153E8131305 for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 14:03:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BZqD4n3KCvGw for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 14:03:06 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1C1F7131303 for <quic-issues@ietf.org>; Tue, 5 Feb 2019 14:03:06 -0800 (PST)
Date: Tue, 05 Feb 2019 14:03:05 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549404185; bh=A+QmOZMKFyIfMF3YKP5hWCl3fZXUp2YdgnxuGSjkurE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=UulzzHFYdYMo96WHFGuLfJapVuCvaGHwgvVNWvF+pCvy2BOTH8/xDTZ6p+ZCHv1ci arCf0hiDL68jVgh+0L0haI3li8r42YNNNS15oAVuMBztDW3LNyJCo2r18OxqHhBRGK a4FchZKZo2iFIrrQ4hEPaDbVgVGwslIfp0f1KT54=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc0b1b6c59ddf5c350481301fda5b5d857d6114ae92cf000000011871ca1992a169ce183e4265@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2419/review/200325691@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2419@github.com>
References: <quicwg/base-drafts/pull/2419@github.com>
Subject: Re: [quicwg/base-drafts] Add table to show what frames go on what streams (#2419)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5a081936892_44c73facce8d45b8274315"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/x8oM-q37ZtgzwqwzAnqOn4nKSfc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Feb 2019 22:03:08 -0000

MikeBishop commented on this pull request.

Minor nit; otherwise good.

Given that we have two frames that fall into this camp, might it be worth doing something like "(*) = only as the first frame"?

> @@ -396,9 +396,24 @@ implementation chooses.
 
 # HTTP Framing Layer {#http-framing-layer}
 
-As discussed above, frames are carried on QUIC streams and used on control
-streams, request streams, and push streams.  This section describes HTTP framing
-in QUIC.  For a comparison with HTTP/2 frames, see {{h2-frames}}.
+HTTP frames are carried on QUIC streams, as described in {{stream-mapping}}.
+HTTP/3 defines three stream types: control stream, request stream, and push
+stream. This section describes HTTP/3 frame formats and the streams types which
+they are permitted on, see {{stream-frame-mapping}} for an overiew.  A

"on which they are permitted; see ... overview"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2419#pullrequestreview-200325691