Re: [quicwg/base-drafts] Two idle timeout corrections (#3983)

Jana Iyengar <notifications@github.com> Tue, 11 August 2020 22:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BEFF83A0D4D for <quic-issues@ietfa.amsl.com>; Tue, 11 Aug 2020 15:28:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.48
X-Spam-Level:
X-Spam-Status: No, score=-1.48 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l1c-8rJISC4h for <quic-issues@ietfa.amsl.com>; Tue, 11 Aug 2020 15:28:21 -0700 (PDT)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8C3C33A0C59 for <quic-issues@ietf.org>; Tue, 11 Aug 2020 15:28:21 -0700 (PDT)
Received: from github-lowworker-a27607f.ash1-iad.github.net (github-lowworker-a27607f.ash1-iad.github.net [10.56.18.61]) by smtp.github.com (Postfix) with ESMTP id 244477A00A5 for <quic-issues@ietf.org>; Tue, 11 Aug 2020 15:28:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597184901; bh=w/0V9oQ2CpTy55dTuKS1NzKJXDfTMMCsk16dDxANgK8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=GV+DUVaMBD/fSXqSQJqfSXQlysE4mQ6SyvKzalJqFVR5Jda208AtxQEEOzlSY5hlU 7J8Xjts3IjE85VpDBtvOtwr54E7v15v+vaaztupuJ51DVvrA+zrEjKytwiGT3VMYdz 9sH4NJ/uuKHlmgO+g+PE+hV9Qtm6S6SpQ0cZjl6w=
Date: Tue, 11 Aug 2020 15:28:20 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK57CXEWFIBZ4O36KEN5H36IJEVBNHHCQH3D4M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3983/review/465471373@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3983@github.com>
References: <quicwg/base-drafts/pull/3983@github.com>
Subject: Re: [quicwg/base-drafts] Two idle timeout corrections (#3983)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f331b84d319d_226116f8209819"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xh8XDNZwbEArBAYMQyp_NJRv-_o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Aug 2020 22:28:23 -0000

@janaiyengar commented on this pull request.



> @@ -2712,8 +2712,12 @@ An implementation of QUIC might provide applications with an option to defer an
 idle timeout.  This facility could be used when the application wishes to avoid
 losing state that has been associated with an open connection, but does not
 expect to exchange application data for some time.  With this option, an
-endpoint could send a PING frame periodically to defer an idle timeout; see
-{{frame-ping}}.
+endpoint could send a PING frame ({{frame-ping}}) periodically, which will cause
+the peer to restart its idle timeout period.  Sending a packet containing a PING
+frame also restarts the idle timeout for the endpoint if this is the first

```suggestion
frame restarts the idle timeout for this endpoint also if this is the first
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3983#pullrequestreview-465471373