Re: [quicwg/base-drafts] Fix: detect stateless reset if connection not found (#2270)

Martin Thomson <notifications@github.com> Mon, 31 December 2018 02:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EA3A712EB11 for <quic-issues@ietfa.amsl.com>; Sun, 30 Dec 2018 18:44:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NyK_l_2e2yt4 for <quic-issues@ietfa.amsl.com>; Sun, 30 Dec 2018 18:44:08 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9793912008A for <quic-issues@ietf.org>; Sun, 30 Dec 2018 18:44:08 -0800 (PST)
Date: Sun, 30 Dec 2018 18:44:07 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546224247; bh=HziAuXeG1og9a/10nquO+vfhdXp2/Yg3IiYwG1s4Vvg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uTAL4UWr8D8w9OnkPq089zNSLTidmqKaUDlkdKcSBrK0gQsOZ6Y8x/sjCkVaWHH4k wMjSZ4PuqHRAru5h3/v3ASsRUNSbuK31JhMW9gdGGM/X5n46aM9elxGIBfeh0rXzt5 xw3CVyzFj220/h9twKCvLbgOSxmrjEcwoLULy9Nk=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab179255edfa900c4f52cfa8a9f8a891b6e0a97a1492cf000000011841447792a169ce1786b308@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2270/review/188457490@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2270@github.com>
References: <quicwg/base-drafts/pull/2270@github.com>
Subject: Re: [quicwg/base-drafts] Fix: detect stateless reset if connection not found (#2270)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c298277bbb9b_664d3f9d34ad45c432657"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zNjuEJuySMxCXePYQf0YjLjCsMA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Dec 2018 02:44:11 -0000

martinthomson approved this pull request.

OK with the requested changes.

> @@ -2420,13 +2420,15 @@ the packet other than the last 16 bytes for carrying data.
 
 ### Detecting a Stateless Reset
 
-An endpoint detects a potential stateless reset when a packet with a short
-header either cannot be decrypted or is marked as a duplicate packet.  The
-endpoint then compares the last 16 bytes of the packet with the Stateless Reset
-Token provided by its peer, either in a NEW_CONNECTION_ID frame or the server's
-transport parameters.  If these values are identical, the endpoint MUST enter
-the draining period and not send any further packets on this connection.  If the
-comparison fails, the packet can be discarded.
+An endpoint detects a potential stateless reset when a incoming packet
+with a short header either cannot be associated with a connection;
+cannot be decrypted; or is marked as a duplicate packet.  The endpoint

s/;/,/g
```suggestion
cannot be decrypted, or is marked as a duplicate packet.  The endpoint
```

> @@ -2420,13 +2420,15 @@ the packet other than the last 16 bytes for carrying data.
 
 ### Detecting a Stateless Reset
 
-An endpoint detects a potential stateless reset when a packet with a short
-header either cannot be decrypted or is marked as a duplicate packet.  The
-endpoint then compares the last 16 bytes of the packet with the Stateless Reset
-Token provided by its peer, either in a NEW_CONNECTION_ID frame or the server's
-transport parameters.  If these values are identical, the endpoint MUST enter
-the draining period and not send any further packets on this connection.  If the
-comparison fails, the packet can be discarded.
+An endpoint detects a potential stateless reset when a incoming packet
+with a short header either cannot be associated with a connection;

```suggestion
with a short header either cannot be associated with a connection,
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2270#pullrequestreview-188457490