Re: Éric Vyncke's No Objection on draft-ietf-quic-recovery-33: (with COMMENT)
Lucas Pardue <lucaspardue.24.7@gmail.com> Wed, 06 January 2021 15:02 UTC
Return-Path: <lucaspardue.24.7@gmail.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3CAF13A0E0F; Wed, 6 Jan 2021 07:02:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.847
X-Spam-Level:
X-Spam-Status: No, score=-1.847 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q3_vQZTC3oRN; Wed, 6 Jan 2021 07:02:12 -0800 (PST)
Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C0C333A0DFC; Wed, 6 Jan 2021 07:02:11 -0800 (PST)
Received: by mail-ed1-x534.google.com with SMTP id b2so4701740edm.3; Wed, 06 Jan 2021 07:02:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KDKH8jNdCSNt+CKWyT8MNZcXLBOIG0E46E7FLi77Rcc=; b=FplscexupNGZhJlzMP3qjXuGb760ZscquAq34t3PY00dFSSE834u7mXl1/1SeJfQzp PyWcluM/lICi0CDHYIp9rnNINaVry9+mKsv/L16TPqazCuicpvwPLnlskohefOYtBc8u ztCBb+wCzh5kv0TbRkq7MlbYvrtW2KhePti3FcgFUHpZLQTgh9zO7T1U7la3ATxzY0dG Qk01WlwDMUswW5s343BddiJgcN5qu0J08kxWXptx3mEMLed41hHYiIN5ELmPl3Ac4YGE 6xrcL/jxCICLWwUxa/bu1dzIRqAJUJt7JRNrjALXxoxfFBPWemD4Hj+9Q1PzZAxFvNED Qp+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KDKH8jNdCSNt+CKWyT8MNZcXLBOIG0E46E7FLi77Rcc=; b=rESICqQulw6wzJQ5RaogCGKv5NtQ+H6fZMR3Sp7pkX/IB2yafaR1nTThjMfzqSvQ8A ZoegMJ4WS4E1Pk0Pod4FTq7pbmfNUUUt8QLOD+kX3OML7MjyNTKpQilOScTb1gHTMvPU nocmItudf/rDDbNJr3W2/uhH+enMrkL6v2RSFbS6tNGoiy9lmXwuzsR/1xQ+LU0PGNgj aF/pDRdPTwri3LpYQacbtLn2CQlOdYkz3YrJzxCUUJ6U0qXnbNZokdpn7TpSzMLMTLuR XBK7HDdVrdBMICjIfKqu0Rlmha1AmYpZs6TS6v2tWdq2PDCIsloXWIRE8G6eXHFs1/FL WjVA==
X-Gm-Message-State: AOAM533oHceqLpMXSkAfOpuwT4qPWE1KeIy7Dvj/y/GPKP+CGdGb67iS WJMi7rbwfCoilo2leaJ/uSaIp1h047AEDzMoSPA=
X-Google-Smtp-Source: ABdhPJxe3MlVayNfL9RqQ5cBnptMjC03RyxeNEVjPXZz1pZBd3UjnkeHvOIT5ReAKhvWpHtz7+NmbG86RLS7WMYCJgg=
X-Received: by 2002:aa7:dcd0:: with SMTP id w16mr4238272edu.229.1609945330210; Wed, 06 Jan 2021 07:02:10 -0800 (PST)
MIME-Version: 1.0
References: <160993989405.14984.17155368859319045324@ietfa.amsl.com>
In-Reply-To: <160993989405.14984.17155368859319045324@ietfa.amsl.com>
From: Lucas Pardue <lucaspardue.24.7@gmail.com>
Date: Wed, 06 Jan 2021 15:01:58 +0000
Message-ID: <CALGR9oaw9kfGtmMn6q5jdFP4emf5-vA8kKh-FxD32xk0M3DpTA@mail.gmail.com>
Subject: Re: Éric Vyncke's No Objection on draft-ietf-quic-recovery-33: (with COMMENT)
To: Éric Vyncke <evyncke@cisco.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-quic-recovery@ietf.org, WG Chairs <quic-chairs@ietf.org>, QUIC WG <quic@ietf.org>, Lars Eggert <lars@eggert.org>
Content-Type: multipart/alternative; boundary="00000000000083dbb205b83c9b10"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/Dfa5WABOpw2jP9V_UI_S21sNjG0>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jan 2021 15:02:14 -0000
Hi Éric, Thanks for the review. I've captured your comments as issues on the QUIC WG GItHub repository. Links to each are provided as in-line responses. On Wed, Jan 6, 2021 at 1:31 PM Éric Vyncke via Datatracker <noreply@ietf.org> wrote: > Éric Vyncke has entered the following ballot position for > draft-ietf-quic-recovery-33: No Objection > > When responding, please keep the subject line intact and reply to all > email addresses included in the To and CC lines. (Feel free to cut this > introductory paragraph, however.) > > > Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html > for more information about IESG DISCUSS and COMMENT positions. > > > The document, along with other ballot positions, can be found here: > https://datatracker.ietf.org/doc/draft-ietf-quic-recovery/ > > > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > Thank you for the work put into this document. Even for a non transport > person > like myself, I find the text easy to read. > > Please find below some non-blocking COMMENT points (but replies would be > appreciated), and some nits. > > I hope that this helps to improve the document, > > Regards, > > -éric > > == COMMENTS == > > Does the QUIC WG intend to have a BCP-like document on how network devices > on > the path should handle buffers? E.g., QUIC ressembles a lot to TCP so > nodes can > apply back pressure with mechanisms similar to RED (but, AFAIK, RED is > mainly > applied to TCP traffic so not to QUIC/UDP). > https://github.com/quicwg/base-drafts/issues/4588 > -- Abstract -- > Should the QUIC version be specified ? > https://github.com/quicwg/base-drafts/issues/4589 > -- Section 1 -- > Suggest to specify version 1 for the 2nd sentence. > > This (too?) short introduction would benefit by mentioning UDP transport. > https://github.com/quicwg/base-drafts/issues/4590 > == NITS == > > -- Section 7.2 -- > "Endpoints SHOULD use an initial congestion > window of 10 times the maximum datagram size (max_datagram_size), > limited to the larger of 14720 bytes or twice the maximum datagram > size. " > > The above text looks ambiguous to me especially with the ',' before > 'limited'. > https://github.com/quicwg/base-drafts/issues/4591 > Also, s/8 byte overhead/8-byte overhead/ ? > https://github.com/quicwg/base-drafts/issues/4592 Cheers, Lucas On behalf of QUIC WG Chairs
- Éric Vyncke's No Objection on draft-ietf-quic-rec… Éric Vyncke via Datatracker
- Re: Éric Vyncke's No Objection on draft-ietf-quic… Lucas Pardue
- Re: Éric Vyncke's No Objection on draft-ietf-quic… Magnus Westerlund