Éric Vyncke's No Objection on draft-ietf-quic-version-negotiation-12: (with COMMENT)
Éric Vyncke via Datatracker <noreply@ietf.org> Tue, 25 October 2022 06:44 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: quic@ietf.org
Delivered-To: quic@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A3C2C14F6E5; Mon, 24 Oct 2022 23:44:36 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Éric Vyncke via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-quic-version-negotiation@ietf.org, quic-chairs@ietf.org, quic@ietf.org, matt.joras@gmail.com, matt.joras@gmail.com, pspacek@isc.org
Subject: Éric Vyncke's No Objection on draft-ietf-quic-version-negotiation-12: (with COMMENT)
X-Test-IDTracker: no
X-IETF-IDTracker: 8.18.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Éric Vyncke <evyncke@cisco.com>
Message-ID: <166668027662.35817.11958471017053381654@ietfa.amsl.com>
Date: Mon, 24 Oct 2022 23:44:36 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/JkbFz9tu30J721OCnjTQ6H8ewnE>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Oct 2022 06:44:36 -0000
Éric Vyncke has entered the following ballot position for draft-ietf-quic-version-negotiation-12: No Objection When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-quic-version-negotiation/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- # Éric Vyncke, INT AD, comments for draft-ietf-quic-version-negotiation-12 CC @evyncke Thank you for the work put into this document. Please find below some non-blocking COMMENT points (but replies would be appreciated even if only for my own education). Special thanks to Matt Joras for the shepherd's detailed write-up including the WG consensus *even* if the justification of the intended status is rather weak. Please note that Petr Špaček is the DNS directorate reviewer (at the chairs' request) and you may want to consider his review as well (and I have read the email dialogue with David): https://mailarchive.ietf.org/arch/msg/dnsdir/swTm6QGRLQqnsVC87asXiedii9s/ I hope that this review helps to improve the document, Regards, -éric ## COMMENTS ### Section 2 In `the versions are compatible` what is meant by 'compatible' ? Identical version ? Some clarity early in the document will help the reader without waiting the section 2.2. ### Section 11 As the "TCP" reference is only used in a note in section 1.2, it should probably be an informative reference. ### Section 4 ``` For QUIC version 1, version negotiation errors are signaled using a transport error of type VERSION_NEGOTIATION_ERROR; see Section 10.2. ``` Just wondering how an already deployed QUIC version 1 implementation that was not updated will know how to send this error type as it is only specified by the document in 2022... I am sure that I miss something else I would have balloted a DISCUSS. ### Section 5 Just to write my appreciation of this section that takes deployment in consideration. Good idea! ### Section 7.2 Same explanations about the use of "SHOULD" will probably be welcome by implementers. ## Notes This review is in the ["IETF Comments" Markdown format][ICMF], You can use the [`ietf-comments` tool][ICT] to automatically convert this review into individual GitHub issues. [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md [ICT]: https://github.com/mnot/ietf-comments
- Éric Vyncke's No Objection on draft-ietf-quic-ver… Éric Vyncke via Datatracker
- Re: Éric Vyncke's No Objection on draft-ietf-quic… David Schinazi
- Re: Éric Vyncke's No Objection on draft-ietf-quic… Eric Vyncke (evyncke)
- Re: Éric Vyncke's No Objection on draft-ietf-quic… Eric Vyncke (evyncke)