Re: Final DATA frames

Martin Thomson <martin.thomson@gmail.com> Tue, 11 December 2018 00:19 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E964F131339 for <quic@ietfa.amsl.com>; Mon, 10 Dec 2018 16:19:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eBVzRqa1eGH5 for <quic@ietfa.amsl.com>; Mon, 10 Dec 2018 16:19:13 -0800 (PST)
Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C12F213133A for <quic@ietf.org>; Mon, 10 Dec 2018 16:19:06 -0800 (PST)
Received: by mail-oi1-x235.google.com with SMTP id a77so10596942oii.5 for <quic@ietf.org>; Mon, 10 Dec 2018 16:19:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZvAalysldIjitS6Nd2gO9q7WnWZlzLCSuKD/bAbyiyw=; b=O1extpyEgkHkYUp3NOLuokvqHOBaB+pP4E1nrgRPtzWnMu4gN1yVnON3NM2rdtZ36y qkJHkzEMWwq45GeVO8w/QJcXCCctNsOm0ad4QtFLkQWWgcH3PRbBmMYRxGShpceQypnv pIuJ+OBxoDZNn90LP4X/6Mq88IOz9ZL52eYtQB6GNjfuj5kbeu8in29ktF4rjrsQVa/J hfeLsPIr9GurnbnuMLzKr7ZNUbYK9PV0tJ3YhhyX2UEAQBD8EmfS6cGzfzgOhxLuGgEP QeZSceiTyFbCHPouJDvAnAa6tl2zP/yPHd+m5lG7+pq8eTJCDCzFydXu5dmow+9dO5F+ foDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZvAalysldIjitS6Nd2gO9q7WnWZlzLCSuKD/bAbyiyw=; b=c2QMaCn3qPUrwtpkWzsZrs6RzfS0hyVqAWZBGEKQj0cLgLxBxlv2VDEDkFCkxz6LY8 EE9whHfBM53IpKRuMi5VnOYrpyd5/DSApV7HckMqYIGk15p1ePZViZsGQBkiM6B0Z5j7 eThsZ2SG1ajI6Dp9gHyrPBKoKVrwEscsA6q9Tk+/DC4NQWwVGFqxJq/jMv8qdq0IglJh YzWaDUNUrT6OYg+E6wQaUiv53ABWWn4iV70rlT7S47uUdpff67h499mFHmE2poUSfACI nzBs0k9IL1v72R6s+KE89Sn5lwlgB3b2jk2BhnOTLe90EDZouYQ1bVjksyNIHb6/2snF 3tmQ==
X-Gm-Message-State: AA+aEWbi+Aodsdl6uMi60cMPS/g5YFzpSZZNgfzUdou6tum9Mfw/ae3f 8bk4rrexgUHMc0EUX0qZEMcG2SUZAVYRf+GQX6g=
X-Google-Smtp-Source: AFSGD/UxmklncrINxkDfZoPfksp2GEOzVwBR8nO9ELxviAMiNGEuQZeNqwC1gJ0U0d5FlHj8fhBixT0xAtdOwV9IqlQ=
X-Received: by 2002:aca:b404:: with SMTP id d4mr110257oif.167.1544487546044; Mon, 10 Dec 2018 16:19:06 -0800 (PST)
MIME-Version: 1.0
References: <8D72549D-DFDB-419A-BEC7-2ADCA7EFEF2F@fb.com> <CAJ_4DfTYwFHE6w1gF8OVzn=F0fuKWpW7vsKrRF2eniTsX+1O9Q@mail.gmail.com> <CALGR9oZEwN_c10R1Mqwvoug9mYJBhbznE3DR-G_e3p02oaVMHQ@mail.gmail.com> <4A67AC5C-860F-45C7-85ED-9CF72B52A438@fb.com> <CY4PR22MB0983059788B10A5522CA9CBFDAAA0@CY4PR22MB0983.namprd22.prod.outlook.com> <CALGR9oahgd3roD8E2J0aoeOje4+Vvf=6PnJxCGx4hK-8+PZgWg@mail.gmail.com> <CY4PR22MB0983F6A15A81D7E7C0FFD714DAAB0@CY4PR22MB0983.namprd22.prod.outlook.com> <CALGR9obVA=Z-jXzih6PuoV+8mRnOBR=cUbkzZWsBK_MbPvdO+A@mail.gmail.com> <CY4PR22MB098307407311C53A286E5135DAAB0@CY4PR22MB0983.namprd22.prod.outlook.com> <CANatvzxr7bEA+WXoBKk2_Yw61zqqO5woRKrTRR2fssXz_9daZA@mail.gmail.com> <20181209212632.GA2419@ubuntu-dmitri> <CY4PR22MB098351EC18E0ADDAE6258CCADAA50@CY4PR22MB0983.namprd22.prod.outlook.com>
In-Reply-To: <CY4PR22MB098351EC18E0ADDAE6258CCADAA50@CY4PR22MB0983.namprd22.prod.outlook.com>
From: Martin Thomson <martin.thomson@gmail.com>
Date: Tue, 11 Dec 2018 11:18:55 +1100
Message-ID: <CABkgnnUCSxmHvr3jgx4q-BntyR5B0mT5xr44o+98wvW2eC9SjA@mail.gmail.com>
Subject: Re: Final DATA frames
To: Mike Bishop <mbishop@evequefou.be>
Cc: Dmitri Tikhonov <dtikhonov@litespeedtech.com>, Kazuho Oku <kazuhooku@gmail.com>, Jana Iyengar <jri.ietf@gmail.com>, Roberto Peon <fenix@fb.com>, rch=40google.com@dmarc.ietf.org, HTTP Working Group <ietf-http-wg@w3.org>, Lucas Pardue <lucaspardue.24.7@gmail.com>, QUIC WG <quic@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/ZxmrwKVqk2ZBrIwtEGEKVkPrjKU>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Dec 2018 00:19:18 -0000

FWIW, there is a valid use case here, but I'm not happy with the
specific design.

For instance, an extension that used a unidirectional stream for the
body of a request might be a better option.

On that basis, I would revert the change.
On Tue, Dec 11, 2018 at 10:36 AM Mike Bishop <mbishop@evequefou.be> wrote:
>
> I'm personally hoping that the HTTP spec will change less frequently than the QUIC spec will, and that changes will be primarily via extensions.  But the choice I'd like to make on list right now is:
>
> Keep the change – it’s an optimization for a common case, and proxies can disable it if they expect the uncommon case to apply
> Revert the change – the optimization isn’t worth the possibility that proxies shoot themselves in the foot
>
>
>
> Whether we can do better in an extension or by adding new transport features in v2 doesn’t block either option – we can keep this change and still publish something better later.  My count of people on this thread so far is split about 50/50 between keeping the change in versus various reasons to reject it.
>
>
>
> -----Original Message-----
> From: Dmitri Tikhonov <dtikhonov@litespeedtech.com>
> Sent: Sunday, December 9, 2018 1:27 PM
> To: Kazuho Oku <kazuhooku@gmail.com>
> Cc: Mike Bishop <mbishop@evequefou.be>; Jana Iyengar <jri.ietf@gmail.com>; Roberto Peon <fenix@fb.com>; rch=40google.com@dmarc.ietf.org; HTTP Working Group <ietf-http-wg@w3.org>; lucaspardue.24.7@gmail.com; IETF QUIC WG <quic@ietf.org>
> Subject: Re: Final DATA frames
>
>
>
> On Sat, Dec 08, 2018 at 10:18:04AM +0900, Kazuho Oku wrote:
>
> > Admittedly, the alternatives have less chance in making it to v1. But
>
> > the question is, is always using length field so bad that we cannot
>
> > wait for a more ideal fix?
>
>
>
> I don't think it's so bad.  The overhead incurred by the DATA frames is small: 0.2% to 0.02% [1].  I think we can live with it for v1.
>
>
>
>   - Dmitri.
>
>
>
> 1. https://github.com/quicwg/base-drafts/issues/1885#issuecomment-431348155