Re: ack delay in rx packets

Ian Swett <ianswett@google.com> Wed, 25 April 2018 16:09 UTC

Return-Path: <ianswett@google.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 36A95129BBF for <quic@ietfa.amsl.com>; Wed, 25 Apr 2018 09:09:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.71
X-Spam-Level:
X-Spam-Status: No, score=-2.71 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id piG0vPQPKp31 for <quic@ietfa.amsl.com>; Wed, 25 Apr 2018 09:09:54 -0700 (PDT)
Received: from mail-yw0-x234.google.com (mail-yw0-x234.google.com [IPv6:2607:f8b0:4002:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EBEE3127909 for <quic@ietf.org>; Wed, 25 Apr 2018 09:09:51 -0700 (PDT)
Received: by mail-yw0-x234.google.com with SMTP id h6-v6so3243521ywj.9 for <quic@ietf.org>; Wed, 25 Apr 2018 09:09:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NuFlgoN9f3b4U/jbfRYzfCPN9DsDKfyyphuhHQChiNo=; b=X65xys2GIVmZKxnH0QtjdY7CbcGSGSFwHeRY+lGG9ymQ08YQa2uhjhLgb5oHZ2+1z7 iLU2GH5sQ75Nr7CoGlMbDa3ZLTY836DYMeUfpzp5215b6g5Kf/I8qwFNzYkYq4r34hDC hBLrHidEzoIavbmi2vAkLW7AZuEQiN/Idm+2hFNKA113AGqeWuxmGdso5W4ZRLF10jpU phz4787VuaZIWC6+rOCK4yriIihaXqfoj9Qjzb+hauHH1zsuzT+4uqdfny/WB+9hEIjU yiyFNRkZpswt7fgGM/j3rrimy0QmwIdHsDHeNCIBGrcckdMT6G8tju21t4W+423LMV2C jwxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NuFlgoN9f3b4U/jbfRYzfCPN9DsDKfyyphuhHQChiNo=; b=fzICIgUDEc9ykQ5WdExG/DUWFa5KbgadEoPFkG8ULGle9NRsGEO52fGj+0g6x7qC+y L/IANZkvqqqdihFkvlSI00HVWD4BGSwelXgIPrfXi9LB1MXpr7/+7OxEvEpawhl6ilvZ dTBhCz0/RH9sgW69U6lUWVj4M//dvntT0UWPiWHyLZ1zq9rcOBBmuF5j80vO/Gm6Vl1h UIjgXU9hgTaF3/ljsFgXAd1owpLh/9eOKjo7vmWDTshsOTduoFAux1Z1D3VzRlH7maoH Bj6pFyQ8lRq2ce7lbF/fl3p6dnbSY0k/tk5ErGP2jBzRjqot0qNUzEKnsS0AMIkjWdA0 Lt6w==
X-Gm-Message-State: ALQs6tCuw4WO+4QXhsLOT4eXSOYyEfuwDcnCOxOvxhPOh/s+bLnQTimF aOQ73EJ5CrL0J2eX8qQOcJwd+QUruhMVNgZCDDmCNA==
X-Google-Smtp-Source: AIpwx4+bVPFSksHGHx4WZdCK+T6JjcZ0NUbo0tmT5hsWuf6aIpJJVJUpNC9/bs5jAKLCGEmzuC6ZHHhKM5A2tUU/HiY=
X-Received: by 2002:a81:a648:: with SMTP id d69-v6mr15213038ywh.173.1524672590923; Wed, 25 Apr 2018 09:09:50 -0700 (PDT)
MIME-Version: 1.0
References: <MWHPR15MB1821770E698C99AAD160864EB68F0@MWHPR15MB1821.namprd15.prod.outlook.com> <CACpbDcd-N+KLECz9z1JQJwE_JXqq_4rNzP9i9Aq9itfRhGaPgA@mail.gmail.com>
In-Reply-To: <CACpbDcd-N+KLECz9z1JQJwE_JXqq_4rNzP9i9Aq9itfRhGaPgA@mail.gmail.com>
From: Ian Swett <ianswett@google.com>
Date: Wed, 25 Apr 2018 16:09:39 +0000
Message-ID: <CAKcm_gNU-yFCk0QzCrLivb96Wy07VnFpH59Vdut2kR_Ff9fjTg@mail.gmail.com>
Subject: Re: ack delay in rx packets
To: Jana Iyengar <jri.ietf@gmail.com>
Cc: Subodh Iyengar <subodh@fb.com>, IETF QUIC WG <quic@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000002f0331056aae80c0"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/jA-u6_UJyVj3kh6LCtj9JcXYfE8>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 16:09:56 -0000

Jana's right about ignoring the ack for RTT calculation if it doesn't
acknowledge a new packet, see section 3.1:
https://tools.ietf.org/html/draft-ietf-quic-recovery-11#section-3.1

If it did acknowledge a new packet because the previous ACK was lost, then
you end up with either a useless RTT, a useless max ack delay, or both.
Because of issues like this, I prefer sending acks in response to packets,
or within an alarm of packet receipt, rather than at other times.

On Wed, Apr 25, 2018 at 11:53 AM Jana Iyengar <jri.ietf@gmail.com> wrote:

> If the sender has seen a previous ack for the same largest received, then
> it should basically ignore this new ack. If not, the ack delay will be
> accurate... What concern do you see with having a large ack delay?
>
> On Wed, Apr 25, 2018, 8:08 AM Subodh Iyengar <subodh@fb.com> wrote:
>
>> We ran into very common cases where we might have all our data to send
>> already outstanding, so when a TLP and RTO alarm fires, we have no new data
>> to send, so we resend data that was in previous packets.
>>
>>
>> In the time that the RTO fires, we might not have received any new
>> packets, however want to send ACKs in this new packet as well. Since no new
>> packets were received, this ACK will have the same largest acked as the
>> previous packet.
>>
>>
>> One question came up as to what the ack delay of an ACK in such a rx
>> packet should be. We could technically set it to the time since receipt of
>> the packet, however with the new max_ack_delay computations, adding this
>> might screw up our estimate of the normal ack delay, so I don't really want
>> to do that. Is there a better option here, or does max_ack_delay not cover
>> this case?
>>
>>
>> Subodh
>>
>