Re: Working Group Last Call (WGLC) comments for draft-ietf-quic-ack-frequency.

Martin Thomson <mt@lowentropy.net> Fri, 03 November 2023 03:31 UTC

Return-Path: <mt@lowentropy.net>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8396AC15107E for <quic@ietfa.amsl.com>; Thu, 2 Nov 2023 20:31:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.105
X-Spam-Level:
X-Spam-Status: No, score=-7.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lowentropy.net header.b="a9rj2LSS"; dkim=pass (2048-bit key) header.d=messagingengine.com header.b="R6oj4/A3"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lLcgaOMJ_2W6 for <quic@ietfa.amsl.com>; Thu, 2 Nov 2023 20:31:08 -0700 (PDT)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6C050C14CF05 for <quic@ietf.org>; Thu, 2 Nov 2023 20:31:08 -0700 (PDT)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 162175C01E4 for <quic@ietf.org>; Thu, 2 Nov 2023 23:31:07 -0400 (EDT)
Received: from imap41 ([10.202.2.91]) by compute6.internal (MEProxy); Thu, 02 Nov 2023 23:31:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lowentropy.net; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1698982267; x=1699068667; bh=IEU1TVHtFPheV4ptKv5S1lGpJ65Od4XDyhi jzxy6Ad0=; b=a9rj2LSShT61O5GVkf3zSAVjaRdfPqI7QmUlR6c2yE46LBb9mnb 94ge8O/gR2zRxhvATZyBVSZaKDav7nui/FkblE5f67XJ4e0DcznzE6/tyFxhFGnk SRNZ0UhFCk+yVcsIVe7QH2gLzvEhSikqol9VtJgMuFnWd/yzT5xGqlcIyQhpw/oo WhN8bfgirn/A563NxxtoNY7FtsQzwNCxaZnS48dE98ZUZGc4DkrWYOKTugNZrHfR idTLSYBOPQU6g2bIcKQojSNVY2rcABpV7LzlqyOn7koXIZ9b2Sp+7Ya4/K04gyob e5gq2vzgnxPTREant+J2j/9SWgGQUNgIaaw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1698982267; x= 1699068667; bh=IEU1TVHtFPheV4ptKv5S1lGpJ65Od4XDyhijzxy6Ad0=; b=R 6oj4/A3IdmVSlZh6hBwlWYT0rpH1N7Coic1MFckIADo4FDdfA/14hbcAXTDpQ05W MdDcOG3iT7aVUSsLfhMDVHIk2yRRBotCy0NSLgd/RMgGWLoCn42W52BV4vFu+wzq KmFnvb0kODClE3YJobWi7yYhavTOfjGhNtOilSHWdcF3WPhGoM8CQNkPCBpuOwsL ljpJ6Gx6Ai6kv898YTG5rBKJzxxxZLvX+bJX9Oa1KDOEGlrEEA411ofU56W8fJpR iUJeU8XVy4x4UVCdMW/DmSCnrC6Qrh7o4txj5geVnr/bvAbknV3GrJpeknHQc7C2 bxMur06Tk+Po0zSE3RDDQ==
X-ME-Sender: <xms:emlEZSBKjqpgYr8Uc3R7Wq_8QDDGhximhrRg6MqMaZm5icRKxCgTIw> <xme:emlEZchrpNI-zvlXBzthvAJR1dw6Nl0lGgRl5xx0bJqn0DkPOQFAOqptc7u2ZuQCn El6PX985rg2pEkxGQo>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddtjedgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtgfesth hqredtreerjeenucfhrhhomhepfdforghrthhinhcuvfhhohhmshhonhdfuceomhhtsehl ohifvghnthhrohhphidrnhgvtheqnecuggftrfgrthhtvghrnhepgfejueduieffledtge elheejvdettdejudduhefggeefgfekgfeuieetgefftddtnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhtsehlohifvghnthhrohhphidrnh gvth
X-ME-Proxy: <xmx:emlEZVnslyxA03FkuNzQRZHsSqtd6OX4kjuVTvrODuwqRwDMRMiUiA> <xmx:emlEZQwE98_xH8oHcPPhPahK2Te82L0IBRuXn7F51sEummqF610giQ> <xmx:emlEZXRFI9nfM5dDYfhysJspxMqQ0PgRlSW_NxIPYgcK7WmGC4UEbA> <xmx:e2lEZefYUX94h_nYw5bLFb8rtKNuOqdMnjmnmQndjtdeI8NKtYPJWw>
Feedback-ID: ic129442d:Fastmail
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 9AEA9234007E; Thu, 2 Nov 2023 23:31:06 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c
MIME-Version: 1.0
Message-Id: <c56f3023-46ca-43bb-bc59-d16ea8a57283@app.fastmail.com>
In-Reply-To: <ed7d3115-1593-4a01-99f6-cce99ca71195@erg.abdn.ac.uk>
References: <ed7d3115-1593-4a01-99f6-cce99ca71195@erg.abdn.ac.uk>
Date: Fri, 03 Nov 2023 14:30:46 +1100
From: Martin Thomson <mt@lowentropy.net>
To: quic@ietf.org
Subject: Re: Working Group Last Call (WGLC) comments for draft-ietf-quic-ack-frequency.
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/o0O0sfLHQkkaybJ47xPQknqlC2A>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Nov 2023 03:31:14 -0000

I agree with Gorry, but I would also strengthen the requirements in Section 6.1 to use SHOULD/RECOMMEND for the receiver behaviour.  The text is fine, but it uses RFC 6919 rather than RFC 2119.

On Thu, Nov 2, 2023, at 22:59, Gorry Fairhurst wrote:
> Thanks for completing this work. I’ve just read the latest version of 
> draft-ietf-quic-ack-frequency as a part of the WGLC, and also checked 
> the issues and the diff. Overall, this draft seems a consistent and 
> complete document that I think will be useful to publish as a RFC.
>
> I have one request:
>
> In reviewing the issues I see the editors decided to not add any 
> recommendation for how often an ACK needs to be sent. I still think this 
> is a serious omission that the WG ought to address. In section 8.1, para 
> 2, the text says  a “sender **CAN** cause a receiver to send ACKs  at 
> least once per RTT”….(see #168).  The editors argued (in #211) that this 
> document can be impartial on whether this is important, but I think we 
> do need to review that: People reviewing specifications in the IETF are 
> often reminded that a protocol ought to provide at least one feedback 
> packet per RTT to close the control loop when intended for Internet 
> deployment, yet this document seeks to relax the ACK procedure for QUIC 
> (which I fully agree with), but does not provide this guidance, which I 
> would have thought was essential to be published as a PS.
>
> My request is to RECOMMEND at least 1 ACK/RTT when sending data, to 
> provide prompt feedback and refer to RFC 8961.
>
> RFC 8961 is BCP and says, for instance:
> Timer “observations SHOULD be taken and incorporated into the RTO at 
> least once per RTT or as frequently as data is  exchanged in cases where 
> that happens less frequently than once per RTT.”
>
> Can we please provide this guidance and add a reference to this guidance?
>
> Best wishes,
>
> Gorry