IETF Logo Mail Archive

Re: DetectAndRemoveAckedPackets

Ian Swett <ianswett@google.com> Tue, 24 November 2020 18:19 UTC

Return-Path: <ianswett@google.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7BD83A12B5 for <quic@ietfa.amsl.com>; Tue, 24 Nov 2020 10:19:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.699
X-Spam-Level:
X-Spam-Status: No, score=-15.699 tagged_above=-999 required=5 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DDv-RMg5CQtk for <quic@ietfa.amsl.com>; Tue, 24 Nov 2020 10:19:29 -0800 (PST)
Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 90F793A12BB for <quic@ietf.org>; Tue, 24 Nov 2020 10:19:29 -0800 (PST)
Received: by mail-qk1-x730.google.com with SMTP id h20so3109581qkk.4 for <quic@ietf.org>; Tue, 24 Nov 2020 10:19:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k+UWXF4oKklIh62WbLuj5Tk5v6P8Kb/l9L+8SrHGWBM=; b=DZ/fM0MEMHz+W8qBRUi2PTaca1S5/mwJG/Mn/1jdhDNpxj5wXE8XUcZAZR0/gpxbEL iNgDW9ed8awoWMzOFmfuDIGVNcXxEodNITCu4LTUJ+f3bBdlMFSLjubIt1zsUNDvscQ3 fn1zq3lj0Cb1cdmkoBl5C6NVdPjeNR05vo4I8CmxEkREZMJ8PPPYNtBzRV2xKf4z6SJ4 Nck3TKpyJ3FzO11wjb4kQEC/xX4xJ4TwHBeeyO/urCFxnWQ6usCCDpgnW6vbzqRWqNQs 5aWxbGykudNmnVpm+HcO5UrPKvhiZ5H2Eius6CNlzK/c4eMMwCY4gw2kCBjSzIjSvKCB 1+LQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k+UWXF4oKklIh62WbLuj5Tk5v6P8Kb/l9L+8SrHGWBM=; b=pX3IkDdbBrAtfse5p3ozYczv2W3I5F2bdHcfIeiTmcsoz7wcYcWP9pyU75uplskOXF 6FmJ1u4s5ptYFApRqs1x+KGcV1RxYgfK8D/90BLuWiP6VkdUAlqCrnBFqspGtKzG+mrZ 4MdMj6PiskfOKb6eW1gd2klHjwEcQUOsd+WAojIiZbx+MgkPhftRiIurS6/LEdGaHdri a4Q5rRzR99mn8fDv4jqytIcxTmc/cPMCR/lWUdBhBtC+GH0jbbhXiTEtf5vzp1A0uVOL aCCxa3flh+gpSS92Cp+FjOy+RwsJS40uFCYLyExZHhGb2xJw2/6D39MgiDTyt+FB3Kn3 qdiw==
X-Gm-Message-State: AOAM530izXgiwYE9KdH/1fVP0TvgWv/bEghj8urG2ueedS/C0Cqd2cEe S5YHpoD2QjZ967GoLh/1b/zTSmt3hLSpRTkElOyp+w==
X-Google-Smtp-Source: ABdhPJwoQ4JfCafcdhVH/C2776i4rv1k+y11sfL67Onl8UC6O8WGURFffmCeWVGvDZsUuMA23kOIVzhntYznKMt5vVk=
X-Received: by 2002:a25:dc0f:: with SMTP id y15mr11074313ybe.494.1606241968463; Tue, 24 Nov 2020 10:19:28 -0800 (PST)
MIME-Version: 1.0
References: <CC8FDDA5-CBF1-4B9D-B1A0-C900DC6DC15E@fh-muenster.de>
In-Reply-To: <CC8FDDA5-CBF1-4B9D-B1A0-C900DC6DC15E@fh-muenster.de>
From: Ian Swett <ianswett@google.com>
Date: Tue, 24 Nov 2020 13:19:17 -0500
Message-ID: <CAKcm_gPS=vUs1yqPS_bsm13G-QZ5ZBSUm-v-aSmZ2QiJVQSXcQ@mail.gmail.com>
Subject: Re: DetectAndRemoveAckedPackets
To: Timo Völker <timo.voelker@fh-muenster.de>
Cc: IETF QUIC WG <quic@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000f49b4e05b4de59b0"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/t-_oUXUPJiBNpHmTG30kqmHc-2Y>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2020 18:19:36 -0000

It's a bit subtle, but the current pseudocode does the right thing,
because sent_bytes is only set to a non-0 value in OnPacketSent() if the
packet is in_flight:

sent_packets[pn_space][packet_number].sent_bytes =
      sent_bytes

Given the way it's used, maybe it makes sense to rename sent_bytes to
inflight_bytes? Though that could be confused with byte_in_flight?

Ian

On Tue, Nov 24, 2020 at 2:09 AM Timo Völker <timo.voelker@fh-muenster.de>
wrote:

> Hi all,
>
> The pseudo code in the recovery draft uses the function
> DetectAndRemoveAckedPackets. Is my assumption correct that this function
> should return a list of all newly acked packets (including these that do
> not count as in flight)?
>
> If so, it seems there is a bug in the code, because this list is passed to
> the congestion controller, which uses *all* the packets in the list to
> decrease its bytes_in_flight.
>
> Timo

v2.23.0 | Report a Bug | By Email