Re: I-D Action: draft-ietf-quic-reliable-stream-reset-00.txt

Christian Huitema <huitema@huitema.net> Sun, 23 April 2023 21:28 UTC

Return-Path: <huitema@huitema.net>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72A8EC151707 for <quic@ietfa.amsl.com>; Sun, 23 Apr 2023 14:28:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AhVcM4CsKB5C for <quic@ietfa.amsl.com>; Sun, 23 Apr 2023 14:28:37 -0700 (PDT)
Received: from mx43-out1.antispamcloud.com (mx43-out1.antispamcloud.com [138.201.61.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BBC4FC1516F8 for <quic@ietf.org>; Sun, 23 Apr 2023 14:28:37 -0700 (PDT)
Received: from xse229.mail2web.com ([66.113.196.229] helo=xse.mail2web.com) by mx203.antispamcloud.com with esmtp (Exim 4.92) (envelope-from <huitema@huitema.net>) id 1pqhG4-000Nv6-JT for quic@ietf.org; Sun, 23 Apr 2023 23:28:34 +0200
Received: from xsmtp21.mail2web.com (unknown [10.100.68.60]) by xse.mail2web.com (Postfix) with ESMTPS id 4Q4LwZ4LrdzBQp for <quic@ietf.org>; Sun, 23 Apr 2023 14:28:30 -0700 (PDT)
Received: from [10.5.2.12] (helo=xmail02.myhosting.com) by xsmtp21.mail2web.com with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from <huitema@huitema.net>) id 1pqhG2-00086n-FI for quic@ietf.org; Sun, 23 Apr 2023 14:28:30 -0700
Received: (qmail 14971 invoked from network); 23 Apr 2023 21:28:30 -0000
Received: from unknown (HELO [192.168.1.104]) (Authenticated-user:_huitema@huitema.net@[172.58.43.211]) (envelope-sender <huitema@huitema.net>) by xmail02.myhosting.com (qmail-ldap-1.03) with ESMTPA for <quic@ietf.org>; 23 Apr 2023 21:28:29 -0000
Message-ID: <2e1513d2-de43-7051-ba7d-9ad2dcb24072@huitema.net>
Date: Sun, 23 Apr 2023 14:28:28 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0
Content-Language: en-US
To: quic@ietf.org, internet-drafts@ietf.org, i-d-announce@ietf.org
References: <168228046414.33533.12502384024236507200@ietfa.amsl.com>
From: Christian Huitema <huitema@huitema.net>
Subject: Re: I-D Action: draft-ietf-quic-reliable-stream-reset-00.txt
In-Reply-To: <168228046414.33533.12502384024236507200@ietfa.amsl.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
X-Originating-IP: 66.113.196.229
X-Spampanel-Domain: xsmtpout.mail2web.com
X-Spampanel-Username: 66.113.196.0/24
Authentication-Results: antispamcloud.com; auth=pass smtp.auth=66.113.196.0/24@xsmtpout.mail2web.com
X-Spampanel-Outgoing-Class: unsure
X-Spampanel-Outgoing-Evidence: Combined (0.10)
X-Recommended-Action: accept
X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT/moHJwZrjLnoMrSk8P2waRPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5x6h2yQpzTslcOqazQkKtAFKj/EwzSHE5FGYwwjsNRPCPjW sQAfMfnj3vXVO+qaVUHmD6wdmZPcItWbGe10hXJtXL4FsauCVkDjmcYJdU3yWp7KuHNaaKdg7iBE ZefdsNUFWKwa/wzJUjmazeC7ImcaiCLnNFG02wjyqkL5l2qZEBQ6V51u76v35b1wNe/MvdIt8mpZ 0rdxDqSzRRLZVl7r2+J9PgaoF8SQHto3le4zsHTaeQtlKubP6iUTjj6yPARK6buALVaA782LKxg6 vRmng8N1aLhXqdc+jC1RcnVud53D5caUhbVtvqItBqoizkEt9O20UjkwI0v+LOlw05G4BS+iyyNq bT8dUMXMJ4tUCMj6G37ZfAMLceP5aNHPt26RBupu5v1nytoNnc138GfEEIgtEXyXj6S3SDvReMcV 8TXUjLjYWQt1/5xnQymMoPsgr/U0flMcy2Vi/IcBgY4arPaiJ1W6hAyiRC61jekdwIcXNugoOEbH RyFULpSjm7jZ1h/HfDRQ5Ig8VhPsPE8NyFCFIEupbwJBQOBjqIllSsO85HpafuPhPXfqtCL7TZbX /BZQOO6i+6Yq6xmplyA6DRojSVizNl0ce/s7u0P9b9Tml6eOMCV9kYYwkPx6ZsXvIUzTXkDAiiJi mGhLUFuS2lhaIetXfCg1JdAVrOwKfKzm0YO1Dw3yHw4QO5gjUFhUoFIvD3sIcP1fhJPM6B/8C4Tv FI6N5pqfx02spfH5z0VHYqNOfYDUzB3fyoaJ4lKJ+dym1L8cD17Js0v4cp1MX9Xu3pOQL9WCixlJ KbzZEzcKVNeVJ9BXyu9+ceCqThTYg2px1fSoqxQCCHnLMo/m9VKh99btUAanjnMCAH2co+fBoeG+ Hs0afhsY/5zhNYWRVYKU9W9tbmVXJBqdHHDmZEKhyNAv1N35kYWaEdgLurFV5oTvAcwA4rM3FkfW 8/1kE/e7sUnsVpINvARNxpFO
X-Report-Abuse-To: spam@quarantine14.antispamcloud.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/vwzfQmA12urcmDjQ_nNzeJ--fRw>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Apr 2023 21:28:41 -0000


On 4/23/2023 1:07 PM, internet-drafts@ietf.org wrote:
> 
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories. This Internet-Draft is a work item of the QUIC (QUIC) WG of the
> IETF.
> 
>     Title           : Reliable QUIC Stream Resets
>     Authors         : Marten Seemann
>                       奥一穂
>     Filename        : draft-ietf-quic-reliable-stream-reset-00.txt
>     Pages           : 6
>     Date            : 2023-04-23
> 
> Abstract:
>     QUIC ([RFC9000]) defines a RESET_STREAM frame to reset a stream.
>     When a sender resets a stream, it stops retransmitting STREAM frames
>     for this stream.  On the receiver side, there is no guarantee that
>     any of the data sent on that stream is delivered to the application.
>     This document defines a new QUIC frame, the RELIABLE_RESET_STREAM
>     frame, that resets a stream, while guaranteeing reliable delivery of
>     stream data up to a certain byte offset.

A comment on the abstract itself: I am a bit put off by the use of 
"guaranteed". The frame is "requesting" delivery up to the specified 
limit. Whether this happens depends on multiple factors -- the local 
QUIC stack or the remote peer can decide to close the connection, for 
example if there are too many transmission errors.

> 
> The IETF datatracker status page for this Internet-Draft is:
> https://datatracker.ietf.org/doc/draft-ietf-quic-reliable-stream-reset/
>

Otherwise, I find the text easy to read, except for a few small nits.

In section 4, the text says:

    RELIABLE_RESET_STREAM frames are ack-eliciting.  When lost, they MUST
    be retransmitted, unless a RESET_STREAM frame or another
    RELIABLE_RESET_STREAM frame was sent for the same stream (see
    Section 5.1).

There is another case for not retransmitting the RELIABLE_RESET_STREAM 
frame: if the entire content of the stream has been acknowledged by the 
peer. This is the classic race condition between FIN and RESET, and that 
race condition can of course happen with FIN and the 
RELIABLE_RESET_STREAM. It might be useful to document that race 
condition, so application designers do not rely on the "guaranteed" 
delivery of the RELIABLE_RESET_STREAM and the Application Protocol Error 
Code that it conveys.

In section 5, the text says:

    As described in (Section 3.2 of [RFC9000]), it MAY deliver data
    beyond that offset to the application.

Editorial, but who is "it" there? The only actor mentioned in the 
section is "the initiator", and that's probably not what you mean.

-- Christian Huitema