Re: [radext] draft-ietf-radext-radiusv11-00 minor fixes

Matthew Newton <matthew-ietf@newtoncomputing.co.uk> Wed, 24 May 2023 09:09 UTC

Return-Path: <matthew-ietf@newtoncomputing.co.uk>
X-Original-To: radext@ietfa.amsl.com
Delivered-To: radext@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C2504C151B0A for <radext@ietfa.amsl.com>; Wed, 24 May 2023 02:09:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=newtoncomputing.co.uk
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1_XnNZSDSD2B for <radext@ietfa.amsl.com>; Wed, 24 May 2023 02:09:43 -0700 (PDT)
Received: from mail.newtoncomputing.co.uk (mail.newtoncomputing.co.uk [IPv6:2001:8b0:b2:1::140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7D369C15106D for <radext@ietf.org>; Wed, 24 May 2023 02:09:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newtoncomputing.co.uk; s=feb2010; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:To:Subject:MIME-Version:Date:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=i6oKZuVF/1yFRRhxfloN1SK6rkyx5rtsT0sf+ms0W5A=; b=MOH+X2qahhNhBV+A8BvjaijvHW 9s0mbbqXph0Nxn37x+7oICEAEgZGa7X8XFlgcfRk90APuaCpISeu7tNMLhNyV8vbW0UKZTm3+dqMj 5XIhtzre0dwT6WUEVblss+oDlpTUySyRP+PO0lOkBDSPbD6vH+cesV9iIwpUT4JWNHzQ=;
Received: from [2001:8b0:b2:1:e884:d1b7:7807:a9b8] by mail.newtoncomputing.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1q1kV0-0000zw-5Y for <radext@ietf.org>; Wed, 24 May 2023 10:09:38 +0100
Message-ID: <24057400-cd58-e056-787b-6fa9aa79406c@newtoncomputing.co.uk>
Date: Wed, 24 May 2023 10:09:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0
To: radext@ietf.org
References: <eb2cb3c9-10f3-49f9-4b4f-65a283811a90@newtoncomputing.co.uk> <289030AF-F26C-461B-B7F3-AF82E3CF465E@deployingradius.com>
Content-Language: en-GB
From: Matthew Newton <matthew-ietf@newtoncomputing.co.uk>
In-Reply-To: <289030AF-F26C-461B-B7F3-AF82E3CF465E@deployingradius.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
X-NC-Fw-Sig: d28eb7783fcaa8a96965cdcb17b1e1fe matthew-ietf@newtoncomputing.co.uk
Archived-At: <https://mailarchive.ietf.org/arch/msg/radext/5dkpB-bj13wM7kdrs6hj6WDbuKM>
Subject: Re: [radext] draft-ietf-radext-radiusv11-00 minor fixes
X-BeenThere: radext@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: RADIUS EXTensions working group discussion list <radext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/radext>, <mailto:radext-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/radext/>
List-Post: <mailto:radext@ietf.org>
List-Help: <mailto:radext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/radext>, <mailto:radext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 May 2023 09:09:47 -0000


On 23/05/2023 20:46, Alan DeKok wrote:
> On May 23, 2023, at 1:16 PM, Matthew Newton <matthew-ietf@newtoncomputing.co.uk> wrote:
>>
>> I've gone through the latest draft. Page numbers below are from draft-ietf-radext-radiusv11-00.pdf.
>>

Just a handful more having checked the rest of the references.


Page 14

"EAP-PWD" is actually referred to as "EAP-pwd" in RFC5931

Not sure it's worth changing, but it was new to me.


-

Page 15 5.1.2 CHAP-Challenge

"[RFC2865] Section 5.2" -> should be section 5.3 (twice in this
para)


-

Page 15 5.1.4 VSAs

Says VSAs must be encoded as their base data type, then goes on to
say MS-MPPE-Send-Key and MS-MPPE-Recv-Key MUST be encoded as
'text'. RFC2548 gives them as 'String' (albeit 'plaintext
String'). I think this should be type string here (RFC8044 s3.5)
for consistency with 5.1.1 and 5.1.3 above?


-

Page 16 6.1 Status-Server

"extension [RFC7360] suggest" add comma "extension [RFC7360]_,_
suggest"


-


Maybe add an "Implementation Status" section as per RFC7360 Section 9? 
Though I don't know if anything other than FreeRADIUS implements it yet?


-- 
Matthew