AD review of draft-ietf-radext-status-server-06.txt

"Romascanu, Dan (Dan)" <dromasca@avaya.com> Tue, 09 March 2010 19:06 UTC

Return-Path: <owner-radiusext@ops.ietf.org>
X-Original-To: ietfarch-radext-archive-IeZ9sae2@core3.amsl.com
Delivered-To: ietfarch-radext-archive-IeZ9sae2@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id C41F23A6A65 for <ietfarch-radext-archive-IeZ9sae2@core3.amsl.com>; Tue, 9 Mar 2010 11:06:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -104.521
X-Spam-Level:
X-Spam-Status: No, score=-104.521 tagged_above=-999 required=5 tests=[AWL=2.078, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f1pRLE2UA6b6 for <ietfarch-radext-archive-IeZ9sae2@core3.amsl.com>; Tue, 9 Mar 2010 11:06:16 -0800 (PST)
Received: from psg.com (psg.com [147.28.0.62]) by core3.amsl.com (Postfix) with ESMTP id CC8C93A69F1 for <radext-archive-IeZ9sae2@lists.ietf.org>; Tue, 9 Mar 2010 11:06:16 -0800 (PST)
Received: from majordom by psg.com with local (Exim 4.71 (FreeBSD)) (envelope-from <owner-radiusext@ops.ietf.org>) id 1Np4ff-0007cm-IH for radiusext-data0@psg.com; Tue, 09 Mar 2010 19:00:47 +0000
Received: from [198.152.71.100] (helo=de307622-de-outbound.net.avaya.com) by psg.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.71 (FreeBSD)) (envelope-from <dromasca@avaya.com>) id 1Np4fZ-0007cH-Ss for radiusext@ops.ietf.org; Tue, 09 Mar 2010 19:00:42 +0000
X-IronPort-AV: E=Sophos;i="4.49,609,1262581200"; d="scan'208";a="179571395"
Received: from unknown (HELO co300216-co-erhwest.avaya.com) ([198.152.7.5]) by de307622-de-outbound.net.avaya.com with ESMTP; 09 Mar 2010 14:00:39 -0500
X-IronPort-AV: E=Sophos;i="4.49,609,1262581200"; d="scan'208";a="453773815"
Received: from unknown (HELO 307622ANEX5.global.avaya.com) ([135.64.140.15]) by co300216-co-erhwest-out.avaya.com with ESMTP; 09 Mar 2010 14:00:38 -0500
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: AD review of draft-ietf-radext-status-server-06.txt
Date: Tue, 09 Mar 2010 20:00:11 +0100
Message-ID: <EDC652A26FB23C4EB6384A4584434A0401FFEFD8@307622ANEX5.global.avaya.com>
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Thread-Topic: AD review of draft-ietf-radext-status-server-06.txt
Thread-Index: Acq/ur52dL8YmGwYRyGW/2lbLqA5AA==
From: "Romascanu, Dan (Dan)" <dromasca@avaya.com>
To: radiusext@ops.ietf.org
Sender: owner-radiusext@ops.ietf.org
Precedence: bulk
List-ID: <radiusext.ops.ietf.org>

I have reviewed the I-D draft-ietf-radext-status-server-06.txt. The
document is in good shape and ready to be sent to IETF Last Call. The
comments below can be considered together with the other comments
received during the IETF Last Call. 

The comments are divided into Technical and Editorial. 

T1. The document is using the Status-Server Code (12) which is
experimental. Why is not the intended status of the document
experimental? 

T2. The following requirements seem to conflict: 

- section 4.1: 'The client MAY increment packet counters as a result of
sending a
   Status-Server request, or receiving a Response packet. '

- section 4.6.2: ' Clients implementing Status-Server MUST NOT increment
[RFC4668] or
   [RFC4670] counters upon reception of Response packets to Status-
   Server queries. '

I think that the later is better. 

T3. The following requirements seem to conflict: 

- section 4.2: 'The server MAY increment packet counters as a result of
receiving a
   Status-Server, or sending a Response packet. '

- section 4.6.1: '...when a server fully implements
   Status-Server, the counters defined in [RFC4669] and [RFC4671] MUST
   be unaffected by the transmission or reception of packets relating to
   Status-Server.'

I think that the later is better. 


E1. I could not understand the logic of the different alignments of
paragraphs in Section 3. 

E2. In section 4.1 I do not like the word 'Robust' in ' Robust
implementations SHOULD accept any Response packet ...'

E3. In the same section I think that 'should' in the following phrase
needs to be capitalized: 

> That is, prior to accepting the response as valid, the client should
   check that the Response packet Code field is either Access-Accept (2)
   or Accounting-Response (5).  

E4. In the same section I think that the MUST in the following phrase
needs not be capitalized: 

> If the Response Authenticator is valid,
   then the packet MUST be deemed to be a valid response from the
   server.

E5. In Section 4.5 s/Each RADIUS Proxyhas/Each RADIUS Proxy has/


Thanks and Regards,

Dan


 

--
to unsubscribe send a message to radiusext-request@ops.ietf.org with
the word 'unsubscribe' in a single line as the message text body.
archive: <http://psg.com/lists/radiusext/>