[Roll] Secdir early review of draft-ietf-roll-rnfd-02

Chris Lonvick via Datatracker <noreply@ietf.org> Sat, 02 December 2023 21:05 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: roll@ietf.org
Delivered-To: roll@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id F35EBC14F60B; Sat, 2 Dec 2023 13:05:38 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Chris Lonvick via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
Cc: draft-ietf-roll-rnfd.all@ietf.org, roll@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 11.16.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170155113897.35981.11774718017979548349@ietfa.amsl.com>
Reply-To: Chris Lonvick <lonvick.ietf@gmail.com>
Date: Sat, 02 Dec 2023 13:05:38 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/roll/EO5QAI9QjgnF56zfRATZIQEWFe8>
Subject: [Roll] Secdir early review of draft-ietf-roll-rnfd-02
X-BeenThere: roll@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Routing Over Low power and Lossy networks <roll.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/roll>, <mailto:roll-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/roll/>
List-Post: <mailto:roll@ietf.org>
List-Help: <mailto:roll-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/roll>, <mailto:roll-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Dec 2023 21:05:39 -0000

Reviewer: Chris Lonvick
Review result: Ready

Hi,

I have reviewed this document as part of the security directorate's ongoing
effort to review all IETF documents being processed by the IESG. These comments
were written primarily for the benefit of the security area directors. Document
editors and WG chairs should treat these comments just like any other last call
comments.

The summary of the review is READY.

First, I've not been following RPL so I read through the draft a few times and
looked at a few of the references to familiarize myself. That is to say that
I'm not an expert at this.

I found the draft explains the concepts well and has an appropriate Security
Considerations section.

A couple of nits:
Section 1.1 discusses what happens when an LBR crashes. In some places, the
section uses the term "dead LBR". However, in other places, it just uses "LBR"
and I can't always tell if it's referring to a live or dead LBR. It would help
to clarify if in each case, it would be designated that the LBR is live, or
dead.

Section 5.5 uses the phrase "sufficiently many messages". As I said, I'm not
familiar with RPL so I don't know how many would be sufficient. Can this be
better quantified?

Also, s/acros/across

Best regards,
Chris