Re: [Roll] Review [raft-rahul-roll-mop-ext-00]

Rahul Arvind Jadhav <rahul.jadhav@huawei.com> Wed, 05 June 2019 00:53 UTC

Return-Path: <rahul.jadhav@huawei.com>
X-Original-To: roll@ietfa.amsl.com
Delivered-To: roll@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F033C120112 for <roll@ietfa.amsl.com>; Tue, 4 Jun 2019 17:53:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IytVwx__TmGp for <roll@ietfa.amsl.com>; Tue, 4 Jun 2019 17:53:39 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 773261200FB for <roll@ietf.org>; Tue, 4 Jun 2019 17:53:39 -0700 (PDT)
Received: from lhreml709-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id C9D882F9F1411E363F8B for <roll@ietf.org>; Wed, 5 Jun 2019 01:53:37 +0100 (IST)
Received: from BLREML407-HUB.china.huawei.com (10.20.4.45) by lhreml709-cah.china.huawei.com (10.201.108.32) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Jun 2019 01:53:36 +0100
Received: from BLREML503-MBX.china.huawei.com ([169.254.9.73]) by BLREML407-HUB.china.huawei.com ([10.20.4.45]) with mapi id 14.03.0439.000; Wed, 5 Jun 2019 06:23:28 +0530
From: Rahul Arvind Jadhav <rahul.jadhav@huawei.com>
To: "Georgios Z. Papadopoulos" <georgios.papadopoulos@imt-atlantique.fr>, Routing Over Low power and Lossy networks <roll@ietf.org>
Thread-Topic: Review [raft-rahul-roll-mop-ext-00]
Thread-Index: AQHVGtkLRDNOya1frkKW9j05u1UiIKaMMS6g
Date: Wed, 05 Jun 2019 00:53:27 +0000
Message-ID: <982B626E107E334DBE601D979F31785C5DEDE962@BLREML503-MBX.china.huawei.com>
References: <5BC4C696-7FAF-4DA5-95E4-66E3DA512743@imt-atlantique.fr>
In-Reply-To: <5BC4C696-7FAF-4DA5-95E4-66E3DA512743@imt-atlantique.fr>
Accept-Language: en-IN, zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.18.157.44]
Content-Type: multipart/alternative; boundary="_000_982B626E107E334DBE601D979F31785C5DEDE962BLREML503MBXchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/roll/J0fTT375WgzQ2gtlaDPBF76s4WM>
Subject: Re: [Roll] Review [raft-rahul-roll-mop-ext-00]
X-BeenThere: roll@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Over Low power and Lossy networks <roll.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/roll>, <mailto:roll-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/roll/>
List-Post: <mailto:roll@ietf.org>
List-Help: <mailto:roll-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/roll>, <mailto:roll-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jun 2019 00:53:42 -0000

Thank you Georgios for the review and feedback.
Please find my responses inline.

Regards,
Rahul


   REQ2:  Optional capabilities handshake.  Capabilities are features,

          possibly optional, which could be handshaked between the nodes

          and the root within an RPL Instance.

[GP] Maybe few words (to give minimum background) earlier in the Introduction about the "capabilities handshake”? Otherwise it appears too unexpectedly.

[RJ] Yes. Should have introduced capabilities in Introduction section. Will do.



   REQ3:  Backwards compatibility.  The new options and new fields in

          the DIO message should be backward compatible i.e. if there

          are nodes which support old MOPs they could still operate in

          their own instances.



   REQ4:  Capabilities handshake could be optionally added with existing

          MOPs.  Capabilities been optional in nature could be put to

          use with existing MOPs.  Capabilities and MOP-extension is

          mutually independent i.e. a DIO can have a capabilities

          option, MOP-extension option or both in the same message.

[GP] Structurally, I would push REQ4 before REQ3. Since both REQ2 and 4 are related with Capabilities handshake.

[RJ] Or I could swap REQ3 and REQ2 which will make related requirements club together? But yes, I get the point of structuring things together and will update in next ver.



3.  Extended MOP Control Message Option

[GP] A structural comment here, I do not see a Subsection 3.2 and so on, then I do not see why there should be 3.1.

[RJ] Will structure this properly. Should add a separate ‘Extended-MOP Base Rules’ section (which will be Section 3.2).



   This document reserves existing MOP value 7 to be used as an

   extender.

[GP] To make it clear, the value 7 did not represent something till today?

   DIO messages with MOP value of 7 MUST refer to the

   Extended MOP (MOPex) option in the DIO message.  If the MOPex option

   is absent in the DIO whose MOP is 7, then the DIO message MUST be

   silently discarded.

[RJ] MOP=7 does not represent anything today. We have added IANA consideration to reserve MOP=7. This reminds me, I need to add Extended-MOP-Value and Capabilities flag registry in the IANA consideration.


[GP] with the current implementation if this value is 7, what would be the case? It will be silently discarded as well?

[RJ] Thanks for raising this. I tried to check what happens as per 6550. As per 6550 Section 6.3.1, the node can still join the network with unknown MOP as a leaf node. This might have implications and may need handling.



        0                   1                   2                   3

        0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1

       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

       |   Type = TODO |           Extended-MOP-value                  |

       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+



                       Figure 1: Extended MOP Option

[GP] Is it possible to have this Extended MOP option Figure within the actual DIO message?

[RJ] There are 7 bits in Reserved field in DIO base message. But I’m not sure if we can use those bits since otherwise there won’t be any Reserved space left for future play.





4.1.  Capability Control Message Option

[GP] Is there room both for MOPex and for Capability options? Or it will either be one or the other one?

[RJ] The draft allows either or both options. Will make this explicit in next ver.