Re: [Roll] Review of draft-ietf-roll-rnfd-02

Konrad Iwanicki <iwanicki@mimuw.edu.pl> Sun, 19 November 2023 21:41 UTC

Return-Path: <iwanicki@mimuw.edu.pl>
X-Original-To: roll@ietfa.amsl.com
Delivered-To: roll@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1E57FC14CEFE for <roll@ietfa.amsl.com>; Sun, 19 Nov 2023 13:41:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.906
X-Spam-Level:
X-Spam-Status: No, score=-1.906 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5B_MdFqwv0BJ for <roll@ietfa.amsl.com>; Sun, 19 Nov 2023 13:40:57 -0800 (PST)
Received: from mail.mimuw.edu.pl (mail.mimuw.edu.pl [193.0.96.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5FFE7C14F749 for <roll@ietf.org>; Sun, 19 Nov 2023 13:40:56 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by duch.mimuw.edu.pl (Postfix) with ESMTP id 7C28D30001A6F; Sun, 19 Nov 2023 22:40:53 +0100 (CET)
X-Virus-Scanned: Debian amavis at duch.mimuw.edu.pl
Received: from duch.mimuw.edu.pl ([127.0.0.1]) by localhost (mail.mimuw.edu.pl [127.0.0.1]) (amavis, port 10026) with ESMTP id 03w0IF9pOY3u; Sun, 19 Nov 2023 22:40:51 +0100 (CET)
Received: from [IPV6:2a02:a311:813e:880:11b:d43a:1c94:de67] (unknown [IPv6:2a02:a311:813e:880:11b:d43a:1c94:de67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by duch.mimuw.edu.pl (Postfix) with ESMTPSA; Sun, 19 Nov 2023 22:40:50 +0100 (CET)
Message-ID: <017ba943-303d-4d67-b691-b4f1183e70f5@mimuw.edu.pl>
Date: Sun, 19 Nov 2023 22:40:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US, pl
To: Routing Over Low power and Lossy networks <roll@ietf.org>, "S.V.R.Anand" <anandsvr=40iisc.ac.in@dmarc.ietf.org>
References: <d6fxpyibwqdb5vt76ekvh6g3vqguvwp7ndfb4m2phyr7zxpmpf@fsxok66lfr27>
From: Konrad Iwanicki <iwanicki@mimuw.edu.pl>
In-Reply-To: <d6fxpyibwqdb5vt76ekvh6g3vqguvwp7ndfb4m2phyr7zxpmpf@fsxok66lfr27>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/roll/R20UOUeIpAnA0Y7INI8qBlbU_IA>
Subject: Re: [Roll] Review of draft-ietf-roll-rnfd-02
X-BeenThere: roll@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Over Low power and Lossy networks <roll.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/roll>, <mailto:roll-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/roll/>
List-Post: <mailto:roll@ietf.org>
List-Help: <mailto:roll-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/roll>, <mailto:roll-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Nov 2023 21:41:02 -0000

Dear Anand,

Thank you for the insightful review. I will try to get back sometime soon.

Best regards,
-- 
- Konrad Iwanicki.

On 16/11/2023 10:52, S.V.R.Anand wrote:
> Dear Konrad,
> 
> Thank you for your nicely written draft that draws attention to the severity of
> the LBR failure and proposes a solution for faster early detection of such a
> failure. In this review, I will try to summarize my thoughts on the
> same which will hopefully help in enhancing the document.
> 
> 1) After the reading document, I am tempted to ask this question as to how
> come such a serious problem which can disrupt the service for several minutes
> got unnoticed till today after so many years of large scale RPL deployments
> across the world and lot of RPL related research work that had gone in. Surely some of
> those real-world deployments might have implemented their own proprietary
> methods to minimize the service disruption without any changes to RPL protocol.
> Having multiple LBRs for the purpose of combating LBR failures and load
> balancing is not new.
> 
> Since LBR is straddling between wired and wireless worlds, proper functioning
> of the IoT network is essential for wireless sensor data producer and the wired
> sensor data consumer/actuator. This means both these end points can potentially
> detect LBR failures. While the RNFD document tackles the problem from the LLN
> side, one can use plethora of schema for quickly detecting LBR failure from the
> wired side deterministically at negligible cost. In the presence of multiple LBRs
> and the use of virtual roots one can reroute the packets to the other LBRs.
> 
> I came across an interesting work that has been carried out in Inria research
> "RPL cooperation experiments using FIT IoT-LAB testbed". In particular, the
> paper titled "Sharing is caring: a cooperation scheme for RPL network resilience
> and efficiency". Here coordination happens between LBRs over wired network to
> detect LBR failures.  The other LBRs pass on the LBR failure information into
> the LLN. (Source: https://inria.hal.science/hal-02095410/file/papier.pdf).
> 
> Giving a brief summary of strategies adopted by IoT deployments that bring
> resilience to LBR failures may not be out of place. Also, RNFD protocol can
> take benefit from other schemes that are available.
> 
> 2) Assuming the time gap between border router failures due to power outages is
> long, it is not apparent from the document the energy consumption and its
> impact on the node/network lifetime due to the consensus process which is
> always running in the background. I know, it depends :) But it is good to
> include experimental results that indicate RNFD performance under different
> network scenarios.
> 
> 3) Refer to section 5.2.  Detecting and Verifying Problems with the DODAG Root
> 
> - Apart from NUD and Layer 2 triggers, I think "overhearing" technique as a means
>    to infer the neighbors' state can help reducing the message exchanges and
>    faster LBR failure detection. What are your thoughts on this ?
> 
> - How does the RNFD work in the presence of RDC ? How is the causality
>    of information is maintained in such a situation ?
> 
> - What happens if certain conditions result in a state that keeps toggling ?  I
>    think RNFD needs to have additional algorithms in place on top of link
>    failure detection schemes such as NUD.
> 
> 4) For minimizing false positives, and false negatives, we would expect the
>     Sentinel nodes to be running some internal algorithm that decide on the state
>     changes between “SUSPECTED DOWN” and “LOCALLY DOWN”. I suppose this algorithm
>     is important for the proper functioning of RNFD protocol. In order to maintain
>     consistency and robustness among different implementations, a reference
>     algorithm will be useful to be given in a separate section or appendix.
> 
> 5) Refer to 5.3.  Disseminating Observations and Reaching Agreement
> 
> - How does one set RNFD_CONSENSUS_THRESHOLD value ? Is it constant across the
>    network or it depends on factors like network topology, traffic pattern and so on ?
>    Also, does this number remain fixed for the entire lifetime of the network or needs
>    to be adapted over time ?
> 
> - A curious question. I would assume that even if just one node indicates that
>    LBR is UP at any time through PositiveCFRC, then LBR can be considered up at
>    that time. Isn't it ?  This precise time epoch is what should be considered in
>    deciding the liveliness of the LBR. In the absence of the notion of time, the
>    question of "latest" information does not arise. Is there a risk of a wrong
>    conclusion, especially if the number of good links are less ?
> 
> There is a small typo in 3.2. Counters and Communication. "acros" to be changed to "across"
> 
> ----------------------------------------------------------------------------------------
> 
> Thank you for your time. I hope you found the points that I brought out are
> reasonably good and help in improving the draft.
> 
> Regards
> Anand
> 
> _______________________________________________
> Roll mailing list
> Roll@ietf.org
> https://www.ietf.org/mailman/listinfo/roll