Re: [rtcweb] Few comments on draft-ietf-rtcweb-audio-07

Jean-Marc Valin <jmvalin@mozilla.com> Thu, 30 April 2015 22:10 UTC

Return-Path: <jmvalin@mozilla.com>
X-Original-To: rtcweb@ietfa.amsl.com
Delivered-To: rtcweb@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BFBAE1A8766 for <rtcweb@ietfa.amsl.com>; Thu, 30 Apr 2015 15:10:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.301
X-Spam-Level:
X-Spam-Status: No, score=-0.301 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, MANGLED_TOOL=2.3, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D4rISHm15CyC for <rtcweb@ietfa.amsl.com>; Thu, 30 Apr 2015 15:10:25 -0700 (PDT)
Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com [209.85.220.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F199B1A8713 for <rtcweb@ietf.org>; Thu, 30 Apr 2015 15:10:24 -0700 (PDT)
Received: by qku63 with SMTP id 63so42005745qku.3 for <rtcweb@ietf.org>; Thu, 30 Apr 2015 15:10:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=5n0pCspmfh/UJK505Lj8e5QxTrA0oS/iXxYyTa7nZI4=; b=lhoPwV07aIwyM8npHvffOtqiKUIdnytMAnkWZ64KFZLUaTdB+jVdL7m0ZO8s7BeXj7 vHl3OrGBeOWMuXTilP2nZlgH0rHPPy9MXZVCScbHo6J+PFFzPwUg72yt9/iZOrnNfpqx F56Izyc6kzu2w6luTV/oB2BQqKEf5jL54Ne/q2yJIyXbvo8qSMGK+Pf9dbcLHgYEeRRP 98Ka0Ttn1F/wNO47Qc4EtFjxRm9AQVEB3m4ex0pzKj3F1kzXYM6w1oWX4OaPgUXl2ghz hVGIjr+X3kzAsYBL7IAVDzH3wbtgvKAXrJMZ09q4QeRIitRRKmbZZf57LukZ0xaqXlbc 3wQA==
X-Gm-Message-State: ALoCoQk1pkhPHqimYbX61IZeFK2jzriwEMfpTJsiXXTqMr0p2u/eNEwFbFNZa78AkSdRxAHTyjyA
X-Received: by 10.55.24.11 with SMTP id j11mr12052317qkh.73.1430431824063; Thu, 30 Apr 2015 15:10:24 -0700 (PDT)
Received: from panoramix.jmvalin.ca (modemcable074.170-201-24.mc.videotron.ca. [24.201.170.74]) by mx.google.com with ESMTPSA id n24sm1934378qkh.3.2015.04.30.15.10.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Apr 2015 15:10:23 -0700 (PDT)
Message-ID: <5542A84D.3040006@mozilla.com>
Date: Thu, 30 Apr 2015 18:10:21 -0400
From: Jean-Marc Valin <jmvalin@mozilla.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "Cullen Jennings (fluffy)" <fluffy@cisco.com>, "rtcweb@ietf.org" <rtcweb@ietf.org>
References: <7703998F-5364-487A-84F1-1AAEE6E4C3C8@cisco.com>
In-Reply-To: <7703998F-5364-487A-84F1-1AAEE6E4C3C8@cisco.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/rtcweb/XFNonSb7wK4LkLU8nIxQ8xkQzxw>
Subject: Re: [rtcweb] Few comments on draft-ietf-rtcweb-audio-07
X-BeenThere: rtcweb@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Real-Time Communication in WEB-browsers working group list <rtcweb.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/rtcweb/>
List-Post: <mailto:rtcweb@ietf.org>
List-Help: <mailto:rtcweb-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2015 22:10:26 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Cullen, Magnus, Colin,

Thanks for the review. I just updated the draft. As some of you
pointed out, I changed all instances of "client" to "endpoint" to
match the terminology. See below for more:

On 16/04/15 02:28 PM, Cullen Jennings (fluffy) wrote:
> 2) Need to tweak Sec 2 to include NOT RECOMMENDED:

Done.

> 3) To avoid a sec considerations comment, I’d probably bolster
> them by adding something like:
> 
> For security considerations regarding the codes themselves please 
> refer their specifications.  Likewise, consult the RTP base 
> specification for security RTP-based security considerations.

Added that text, along with references.

> 4) The last sentence in the sec cons is likely to attract flies.
> Can we point to the two security drafts instead?

Added many security references. I didn't delete the sentence itself,
but I can do that too if you think it should go.

> 5) I’d probably the refer to the opus rtp payload draft from -03
> to -08 (it’s in IESG eval - yippie) and the reference to the audio
>  codecs for interop from -00 to -01.

Done.

> 6) The draft has "Because of this, clients MAY increase the gain 
> before playback." To make consistent sound levels across browsers,
> I wonder if this should continue to say something like - "many
> browsers increase it by X db" and insert whatever value of X that
> chrome and FF think they should be using. I don't feel strongly
> about adding this one way or the other but can the authors give it
> a little thought and see if they think it is needed or not.

I don't know that browsers are doing that yet and I'm not exactly sure
what would be a good value there. I suspect it's more of a W3C discussio
n.

On 20/04/15 03:40 PM, Colin Perkins wrote:
> - Section 3 says "Clients MAY use the offer/answer mechanism to 
> signal a preference for a particular mode or ptime". Is this just
> of Opus, or in general? It might be worthwhile saying something
> explicit about acceptable ptime values in general.

There was some discussion on acceptable ptime values in the past, but
there was no consensus achieved.

> - Security considerations ought to explicitly point to the
> security considerations of RFCs 3389, 4733, 6716, and 
> draft-ietf-payload-rtp-opus. It should possibly also point to the 
> draft-ietf-rtcweb-security-arch-11, and the security
> considerations for RTP use in WebRTC in
> draft-ietf-rtcweb-rtp-usage-22

Done.

Cheers,

	Jean-Marc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJVQqhNAAoJEJ6/8sItn9q9bP4H/2BwbcFqUo8V0BuG/mRWdzxv
W5pAhsphO+4hxSV2c6bGABRR3KRkjqHklRpQHebSQ/yAhQEWRWWZXoSeX/sqfMqD
RODCF56ZLMIfPtep3ss7eLaRN3qjMfJMbyP7nvTzYqZujbcnlQzw11pJSywMKVqh
Yg0/Fa9X+C5ymWRE3Y9v2ITCoVDwd5A4MnHO3FY+3gotmsT/6+RRgccbXGyqUp2t
OLMknp3lA3ofidZAWkQ1lMv9D/GrLxCqpya2w/4LGZFCK++q0YBvfxlyXjoL7N9l
CKtTreovnhJwULcyp5RVEr3G8BJ0YniOGfkjHuslfAg/L45jVmP/pMxorR7s1LU=
=Afic
-----END PGP SIGNATURE-----