Re: [rtcweb] JSEP: codecs in answer: MUST vs. MAY

Ted Hardie <ted.ietf@gmail.com> Tue, 24 October 2017 20:37 UTC

Return-Path: <ted.ietf@gmail.com>
X-Original-To: rtcweb@ietfa.amsl.com
Delivered-To: rtcweb@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 289FC13F529 for <rtcweb@ietfa.amsl.com>; Tue, 24 Oct 2017 13:37:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e9_PVho9abAt for <rtcweb@ietfa.amsl.com>; Tue, 24 Oct 2017 13:37:26 -0700 (PDT)
Received: from mail-qk0-x22b.google.com (mail-qk0-x22b.google.com [IPv6:2607:f8b0:400d:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D70A1390EE for <rtcweb@ietf.org>; Tue, 24 Oct 2017 13:37:25 -0700 (PDT)
Received: by mail-qk0-x22b.google.com with SMTP id q83so27961438qke.6 for <rtcweb@ietf.org>; Tue, 24 Oct 2017 13:37:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lHSZGSdKqyyBykJiCaqqrje0zKySJmSmm21Zm6R/JJ4=; b=mJoGERlm+ad3IKnaNG1X5uZxI3H0DNoNwJO1O8f77STAD0BwwAINJVU72nG5g+zzzj t+gjgmHDVRK5W+ROVjPhS9EEav2+13IYCflcK3tho7prQ3C5RufIOo9x30bPFjeJQ5eZ wfnZyEnS/bOPbbh5ElLrnFjZO6/e3dCx2gbywYs+qVapdHtYvJVu/VcqpoiZ9B+o7BqN /564UjiwuG1WucoTCwzSiHojWMZtI8kdvh8UcSYM9/mcqdg19jeKMBo4F3k0qJ4HXQHP jMaOxQ4RUzww21CHYIIZSsHkb5GyFMWCyDJfUIGQz4w8Z7f9l1xx+hqnCgU5vhRc98n2 5B7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lHSZGSdKqyyBykJiCaqqrje0zKySJmSmm21Zm6R/JJ4=; b=s8gjgUk6ez86S2ZDKMKiJlpujsFd8fxD2MvyZDYcs3y0kGhInQ+0BdUVNRjsahYwPd zty8x4Q5AYOTq+BDuBtId5rhUt7Q9PDr1/1xToZBPNOwgcXmB0p3obBmADW8gReIPFlI KOrLaU0F4uMReED+JnydeSnHbeamsBVx/aUDuzcX4IlQh1dVpF4GgRBqE/jl0VmccHpY 5uIei9wnpA3aDOqufsIxsWc4cyx7zQWNrQj/edD+hi3lZ5+QcBX+n/htShIIfdNeUkYc 6geETGrikWt4/GX7F5PQh3a6IVcL2J7cOEap7nzMv5+gCzFy1/VpY3E8ztT23cWrPxdF /LNg==
X-Gm-Message-State: AMCzsaXct9wSEwXmNNqrbuaWliPqaeQ5ZtxN7/9wgJwziAb90BV4afDi /6VdzAmb+IHE3IvslsYmifm2p/K9Fq6kq/OHcdU=
X-Google-Smtp-Source: ABhQp+T5Ehofn4GGiuqWQODqJzMrOrFESjqqAaqX21V/alx3DR4C1uRlO9D3AB2qce3NCgTyLvc9K1Ftc7H/yYYWSsM=
X-Received: by 10.55.101.4 with SMTP id z4mr26000707qkb.114.1508877444544; Tue, 24 Oct 2017 13:37:24 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.200.40.68 with HTTP; Tue, 24 Oct 2017 13:36:54 -0700 (PDT)
In-Reply-To: <4CB5EF91-8CB2-433F-85E9-A86140CECC62@vidyo.com>
References: <4CB5EF91-8CB2-433F-85E9-A86140CECC62@vidyo.com>
From: Ted Hardie <ted.ietf@gmail.com>
Date: Tue, 24 Oct 2017 13:36:54 -0700
Message-ID: <CA+9kkMDJEggHar5JbBb9GaNMBsZjgvO0F2VN5UVObv-3VTzE4w@mail.gmail.com>
To: Jonathan Lennox <jonathan@vidyo.com>
Cc: "rtcweb@ietf.org" <rtcweb@ietf.org>
Content-Type: multipart/alternative; boundary="94eb2c05afde177d94055c50e8fd"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtcweb/bnm-Oq3oMZOqfI6eN8b8ZcaSYFY>
Subject: Re: [rtcweb] JSEP: codecs in answer: MUST vs. MAY
X-BeenThere: rtcweb@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Real-Time Communication in WEB-browsers working group list <rtcweb.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtcweb/>
List-Post: <mailto:rtcweb@ietf.org>
List-Help: <mailto:rtcweb-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Oct 2017 20:37:28 -0000

I read this slightly differently, see below.

On Tue, Oct 24, 2017 at 12:58 PM, Jonathan Lennox <jonathan@vidyo.com>
wrote:

> JSEP (section 5.3.1) seems to be inconsistent about how whether
> locally-supported codecs that weren’t listed in a remote offer MUST, or
> MAY, be included in an answer:
>
>    o  If codec preferences have been set for the associated transceiver,
>       media formats MUST be generated in the corresponding order,
>       regardless of what was offered, and MUST exclude any codecs not
>       present in the codec preferences.
>
>
This is what you do if codec preferences are set (keep the order, and don't
add new ones)


>
>    o  Otherwise, the media formats on the m= line MUST be generated in
>       the same order as those offered in the current remote description,
>       excluding any currently unsupported formats.  Any currently
>       available media formats that are not present in the current remote
>       description MUST be added after all existing formats.
>
>
This is what you do if codec preferences are not set (keep the order, add
any new ones to the end)

>    o  In either case, the media formats in the answer MUST include at
>       least one format that is present in the offer, but MAY include
>       formats that are locally supported but not present in the offer,
>       as mentioned in [RFC3264], Section 6.1 <https://tools.ietf.org/html/rfc3264#section-6.1>.  If no common format
>       exists, the m= section is rejected as described above.
>
>
>
In either case, if you don't have at least one codec that matches, you
reject the m= section (don't add any new ones).

I think the MAY there from RFC 3264 permits the behavior in the  "if not
codec preferences are set" behavior branch, but doesn't require it, which
is why there can be a branch like the one where codec preferences are set
and they are not sent.


> The first two paragraphs certainly seem to indicate that these codecs MUST
> be included in the answer; however, the third paragraph suddenly weakens
> this to a MAY.
>
> Is the intent of the third paragraph simply to restate RFC 3264’s loose
> requirements, whereas the first two are JSEP’s more binding ones?  If so, I
> think this should be stated more clearly, otherwise the required behavior
> is unclear.
>
> _


So I don't personally see an inconsistency in this, but if you have other
language, please suggest it.  We're already in IESG evaluation, but it
might be a friendly amendment by Adam or someone else.

regards,

Ted


> ______________________________________________
> rtcweb mailing list
> rtcweb@ietf.org
> https://www.ietf.org/mailman/listinfo/rtcweb
>
>