Re: draft-ietf-bfd-optimizing-authentication-13 nits

Alan DeKok <aland@deployingradius.com> Mon, 22 January 2024 01:23 UTC

Return-Path: <aland@deployingradius.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CCC72C14F6AF for <rtg-bfd@ietfa.amsl.com>; Sun, 21 Jan 2024 17:23:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.909
X-Spam-Level:
X-Spam-Status: No, score=-6.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IULiWvTZl3jl for <rtg-bfd@ietfa.amsl.com>; Sun, 21 Jan 2024 17:23:32 -0800 (PST)
Received: from mail.networkradius.com (mail.networkradius.com [62.210.147.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2DBD3C14F6A8 for <rtg-bfd@ietf.org>; Sun, 21 Jan 2024 17:23:31 -0800 (PST)
Received: from smtpclient.apple (135-23-95-173.cpe.pppoe.ca [135.23.95.173]) by mail.networkradius.com (Postfix) with ESMTPSA id A32851FD; Mon, 22 Jan 2024 01:23:28 +0000 (UTC)
Authentication-Results: NetworkRADIUS; dmarc=none (p=none dis=none) header.from=deployingradius.com
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: draft-ietf-bfd-optimizing-authentication-13 nits
From: Alan DeKok <aland@deployingradius.com>
In-Reply-To: <5EE1006F-0CA6-4D63-9E8A-B7CDB2B7B124@pfrc.org>
Date: Sun, 21 Jan 2024 20:23:26 -0500
Cc: Mahesh Jethanandani <mjethanandani@gmail.com>, "rtg-bfd@ietf. org" <rtg-bfd@ietf.org>, Ashesh Mishra <mishra.ashesh@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <DD272B19-3789-48E6-AC6D-84A24C1179A0@deployingradius.com>
References: <B49A64C7-731F-4729-9D99-AC6C133983C8@deployingradius.com> <F9A30ECC-28E1-4272-A23F-191310424E0F@pfrc.org> <A9091D9D-1F6F-4AB7-BAD6-04229B0F3EFF@deployingradius.com> <5EE1006F-0CA6-4D63-9E8A-B7CDB2B7B124@pfrc.org>
To: Jeffrey Haas <jhaas@pfrc.org>
X-Mailer: Apple Mail (2.3696.120.41.1.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/rtBmzcHSN924qYWcsngHk19C4i8>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2024 01:23:37 -0000

  (removing optimizing authentication)

> On Jan 21, 2024, at 3:37 PM, Jeffrey Haas <jhaas@pfrc.org> wrote:
> I'd not pushed for those details to be spelled out because the only legitimate way an implementation can accomplish this is, as above, through a poll sequence.

  Ah, I had forgotten that.  I've been working on the ISAAC bits, and was studiously ignoring the rest of the BFD state machine.

>> Doing that would address pretty much all of the issues related to not authenticating the packet.  Either a received packet is byte-for-byte identical to what we expect (plus ISAAC key), or it's not, and we drop it.
> 
> ... is perhaps a late understanding for you as the expert in ISAAC rather than BFD, we certainly can spell it out in a sentence or two in the secure sequence numbers document

  Perhaps not quite too late.  I can add some text to the document before another rev is sent out.

  The text should say that none of the fields in the header normally change.  [RFC5880] Section 6.8.3 says:
 
   If either bfd.DesiredMinTxInterval is changed or
   bfd.RequiredMinRxInterval is changed, a Poll Sequence MUST be
   initiated

  There's no similar text for "Required Min Echo RX Interval" changes, but that's fine.

 The ISAAC document also could to be updated to state that a stronger authentication method is used for every Poll Sequence, too.  Because that signifies a change of session state (management information), even if the bfd.SessionState variable remains in "Up".

  For me, that's the main reason to switch to a stronger Auth Type.

  The ISAAC document can then say that the BFD packets can at least be verified to be unchanged if:

* the packet information is cached during an Auth Type which verifies the packet contents

* the same packet header (modulo Sequence Number) is seen for all packets using ISAAC

  I'll try to work up some text tomorrow.

  Alan DeKok.