Re: [Gen-art] Genart last call review of draft-ietf-bfd-unsolicited-10

Lars Eggert <lars@eggert.org> Mon, 12 December 2022 14:28 UTC

Return-Path: <lars@eggert.org>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 83245C14CE47; Mon, 12 Dec 2022 06:28:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.096
X-Spam-Level:
X-Spam-Status: No, score=-2.096 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FDuUQbnxKFxv; Mon, 12 Dec 2022 06:28:28 -0800 (PST)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E27EC1522BD; Mon, 12 Dec 2022 06:28:28 -0800 (PST)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:607a:b494:5b90:c9a0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id F11451DD834; Mon, 12 Dec 2022 16:28:20 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1670855301; bh=QguSjSVpYqtZSj2HZqDiCSP3nXqrPtc10fzisobge8k=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=TEcISyAyUyiZHip5WP3+442CvzL5omev7TDiMNPtXTxkmLCrtmDLm5hZ48Y8iUiW5 /2eoyZjv55Hauzp0vaxh5KboiFDPuEdhLt9U3YeXXDUR/7RjR6VwDediOCa4AH/T7Q zY1NGaTXJlZkbEzP76Ov0cLWROAOk04XAhlUPLeQ=
Content-Type: multipart/signed; boundary="Apple-Mail=_94068AF6-BA70-45A2-8CB1-0B7BBB9C1008"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\))
Subject: Re: [Gen-art] Genart last call review of draft-ietf-bfd-unsolicited-10
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <166739999049.21524.8078883937184254631@ietfa.amsl.com>
Date: Mon, 12 Dec 2022 16:28:20 +0200
Cc: gen-art@ietf.org, last-call@ietf.org, rtg-bfd@ietf.org, draft-ietf-bfd-unsolicited.all@ietf.org
Message-Id: <A0FE0920-BD22-445D-A7F0-01563F649620@eggert.org>
References: <166739999049.21524.8078883937184254631@ietfa.amsl.com>
To: Dan Romascanu <dromasca@gmail.com>
X-MailScanner-ID: F11451DD834.A244B
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/zdA4h4OM7I_YH4RChjxbHPfaXQE>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2022 14:28:32 -0000

Dan, thank you for your review. I have entered a Discuss ballot for this document based on my own review.

Lars


> On Nov 2, 2022, at 16:39, Dan Romascanu via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Dan Romascanu
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-bfd-unsolicited-10
> Reviewer: Dan Romascanu
> Review Date: 2022-11-02
> IETF LC End Date: 2022-11-14
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> This is a well-written and clear document that describes procedures for
> "unsolicited BFD" that allow a BFD session to be initiated by only one side,
> and established without explicit per-session configuration or registration by
> the other side (subject to certain per-interface or global policies), with the
> goal of achieving operational simplification of "sessionless" applications
> using Bidirectional Forwarding Detection (BFD).
> 
> The document is Ready from a Gen-ART perspective. A couple of editorial nits
> need clarification and possible fixes.
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> 1. Section 1 refers to draft-ietf-idr-rs-bfd which has the status Expired in
> the Datatracker. Is the intention to stay with the archived version of this
> Expired document?
> 
> 2. Section 3 defines the new state variable Role as 'The role of the BFD
> session as per [RFC5880], section 6.1.'.
> 
> However, RFC 5880 talks about role as an attribute of the system in session
> initialization rather than an
> 
>> A system may take either an Active role or a Passive role in session
>   initialization.  A system taking the Active role MUST send BFD
>   Control packets for a particular session, regardless of whether it
>   has received any BFD packets for that session.  A system taking the
>   Passive role MUST NOT begin sending BFD packets for a particular
>   session until it has received a BFD packet for that session, and thus
>   has learned the remote system's discriminator value.  At least one
>   system MUST take the Active role (possibly both).  The role that a
>   system takes is specific to the application of BFD, and is outside
>   the scope of this specification.
> 
> I believe that wording in the two documents needs to be aligned.
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art