Re: [RTG-DIR] [Last-Call] Rtgdir last call review of draft-ietf-mpls-lspping-norao-06

Greg Mirsky <gregimirsky@gmail.com> Tue, 13 February 2024 05:36 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D9A7CC14F6F0; Mon, 12 Feb 2024 21:36:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.104
X-Spam-Level:
X-Spam-Status: No, score=-1.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MqHIGGMmxAYb; Mon, 12 Feb 2024 21:36:19 -0800 (PST)
Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BC0D9C14F61C; Mon, 12 Feb 2024 21:36:14 -0800 (PST)
Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-604b94c0556so30444677b3.3; Mon, 12 Feb 2024 21:36:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707802573; x=1708407373; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=e+K7060bL0PpmoqPToQaotDB7Xla11aWUHtDrp0fmTc=; b=BiJDREkGgAMNCnI1D/9mHK9kHJQqZ4T9h8nUMsZhJrA+0mcKnr0oj6o6adsNUpfrLw 6SAIzUHBK36Kvptea8P0xPkwjVexHmYRouJlibycU/PssFZBgucKud/2eRJza4sv8phc YwJPNlYbij1mEfcird2fSjTgO0CBKpGk5jfKsq52qYpcoocrvIq2USQMyXv1eS3hmeRM w7QdMRBtO4+dZO7zB7fy2mrLCcYJXT9lC62s+iasQYXArGHBcgDR/1S3jbErmgqjC58E QHFg4UuYVuqJ5BHSTvPgg44I2UuiVQvIxZ7V7veZU82P5glBgkOIKPFNx6tHKxp5poGB qQYA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707802573; x=1708407373; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e+K7060bL0PpmoqPToQaotDB7Xla11aWUHtDrp0fmTc=; b=YQE0lMXO+KD2K2UMDv8qCbdhUttAQ+p+TCZGffAlEr447MsSy+106AXPnu3H88m/WR fCnydjmJk5FZQiSq4dhO3j3BRsQ3wsRExOKt0v2g4NcIsZiKm6QKmv4yfQQUaHJTsOA7 b3AsPSqOMZ1cHTup1CcJaP7a+y0pvF0OvzDBRPD5WimOm1+SHGe1HHctaCHi++y9R7Jn E+vm9mMDeQny4tax3w4s3IhZ7H0j+MEs5NO2Y3o6X+SoH/m8gy8oqBUe/iwE9x1HcRr9 8yteyU/qB0FFTaq/xVD3aqpSFuzYtXwakLl828Dmp77ex90/UBWHUG9X7DeK5r8BLRzc JaBQ==
X-Forwarded-Encrypted: i=1; AJvYcCVh6FpWrALraFGYPYeLPXYgRv1KYJO9EIFbBBVIiSzq2VDq9YDZQqO0JrACgpcxEEMX5k72RPHc8ut/lqGau4duLNK2Ty07tiNmoQ4whQzc6ONYSFDkh2I/iLyQuJiQ7eHgo3UvC0U2378j/+jNwaToRs97u954AqdZY994G6u0eLg4SBOZdcB2z8PRrA31+w==
X-Gm-Message-State: AOJu0Yy8bm08s4rA6XeC9U5stPoD4TcXL4TC9bKkOmm3fV9cSBOPR3ZF IfklxnnnbuE4uocrvOqastX30NlF3wXfirN3PyBp+sjNwrsIxDrS0FJbXSMoeRJ8L59LQADEYDh zy20IFvHJMouhZ6xmIx2lBOjI6Xk=
X-Google-Smtp-Source: AGHT+IEqQKpxg3oUAu0OH+ZIQgF1Mn0HFnBoaYizO6Fkmx/dvvcsKUUoxOieHUIOWCmgzLDRgtldWBXmaXQx+BL2vA4=
X-Received: by 2002:a81:4fcd:0:b0:5ee:65b3:f289 with SMTP id d196-20020a814fcd000000b005ee65b3f289mr6107971ywb.3.1707802573607; Mon, 12 Feb 2024 21:36:13 -0800 (PST)
MIME-Version: 1.0
References: <170712440103.40611.16663211097190972973@ietfa.amsl.com> <CA+RyBmWdCwaW1JvfGb8rFntWGpkbse+ZtiDP167kt+k_GL32vQ@mail.gmail.com> <CAB75xn5UAh0_b5LNjkZO+T_yeivgmAzjnrk3_X9Q0jSdPEco6Q@mail.gmail.com> <CA+RyBmUu3XozA_RaeeAmoZabBiH=dMU_2vAHT=H+2XPqaKc2Nw@mail.gmail.com> <CAP7zK5b8CNYRDZYe_SRgwTiEhEpZTnCmQZVfYE38_hqt8q_9og@mail.gmail.com>
In-Reply-To: <CAP7zK5b8CNYRDZYe_SRgwTiEhEpZTnCmQZVfYE38_hqt8q_9og@mail.gmail.com>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Mon, 12 Feb 2024 21:36:03 -0800
Message-ID: <CA+RyBmUtvB-S81DeTXrx2dADQ3tQzpxafZKs9rOwT-x2Soy-PQ@mail.gmail.com>
To: Dhruv Dhody <dd@dhruvdhody.com>
Cc: Dhruv Dhody <dhruv.ietf@gmail.com>, rtg-dir@ietf.org, draft-ietf-mpls-lspping-norao.all@ietf.org, last-call@ietf.org, mpls@ietf.org
Content-Type: multipart/mixed; boundary="000000000000bf2f4d06113cc55b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/0RRfdLDNcvmwv8QqQJcEawbcxns>
Subject: Re: [RTG-DIR] [Last-Call] Rtgdir last call review of draft-ietf-mpls-lspping-norao-06
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Feb 2024 05:36:24 -0000

Hi Dhruv,
thank you for your prompt reply, and my apologies for the confusion my
sloppy response caused. A couple of follow-up notes tagged GIM3>> below.
I've attached the updated working version of the draft.

Regards,
Greg

On Mon, Feb 12, 2024 at 9:16 PM Dhruv Dhody <dd@dhruvdhody.com> wrote:

> Hi Greg,
>
> On Mon, Feb 12, 2024 at 5:20 AM Greg Mirsky <gregimirsky@gmail.com> wrote:
>
>> Hi Dhruv,
>> thank you for your thoughtful suggestions. I've added more notes below
>> tagged GIM2>>. Attached, please find the updated working version of the
>> draft.
>>
>> Regards,
>> Greg
>>
>>
>> On Tue, Feb 6, 2024 at 7:41 PM Dhruv Dhody <dhruv.ietf@gmail.com> wrote:
>>
>>> HI Greg,
>>>
>>> Thanks for taking my comments into consideration.
>>>
>>>>
>>>>> ## Major
>>>>>
>>>>> - It would be incorrect to put RFC 7056 (which is being made historic)
>>>>> in the
>>>>> "updates:" list at the top of the page. Note that, one needs to follow
>>>>> the
>>>>> "status-change" document process to mark the RFC as historic which
>>>>> should be
>>>>> triggered by the AD. The job of this I-D is to articulate the reasons
>>>>> why the
>>>>> RFC7506 should be made historic. Update section 1 and section 3
>>>>> accordingly.
>>>>> Section 3 could list or refer to existing sections on why RFC 7506
>>>>> should be
>>>>> historic.
>>>>>
>>>> GIM>> Thank you for pointing this out. Updated the header accordingly.
>>>>
>>>
>>> Dhruv: I think this text in (1) abstract - "It reclassifies RFC 7506 as
>>> Historic..." and this text in (2) introduction "...and reclassifies RFC
>>> 7506 [RFC7506] as Historic." and section 3 (3) "This document reclassifies
>>> RFC 7506 [RFC7506] as Historic." are incorrect.
>>>
>>> It should stay instead that "this document explains why RFC 7560 has
>>> been reclassified as Historic" in all places. I would also suggest to
>>> update section 3 accordingly
>>>
>> GIM2>> Thank you for explaining the process to me. As I understand it,
>> reclassifying RFC 7506 will take separate efforts and time. Hence my
>> question, "Would it be more acceptable to state, "This document explains
>> why RFC 7506 should be reclassified as Historic"?
>>
>
> Dhruv: Yes! Thanks!
>
> <snip>
>
>>
>>>
>>> I have my doubts about one more instance -
>>>
>>> https://datatracker.ietf.org/doc/html/rfc8029#section-4.3
>>>
>>> The Router Alert IP Option of value 0x0 [RFC2113] for IPv4 or value 69
>>>> [RFC7506] for IPv6 MUST be set in the IP header.
>>>
>>> GIM2>> Thank you pointing this text to me. Would the following text
>> address your concern:
>> NEW TEXT:
>>    Furthermore, this specidication updates Section 4.3 of [RFC8029] as
>>    follows:
>>
>>    OLD:
>>
>>    The Router Alert IP Option of value 0x0 [RFC2113] for IPv4 or value
>>    69 [RFC7506] for IPv6 MUST be set in the IP header.
>>
>>    NEW:
>>
>>    The Router Alert IP Option of value 0x0 [RFC2113] for IPv4 or value 69
>>    [RFC7506] for IPv6 MUST be set in the IP header.
>>
>>    END
>>
>
> Dhruv: Did you forget to update the text in NEW? Except for a missing
> space after [RFC2113] there seems to be no difference between OLD and NEW!
>
GIM3>> Indeed. It is like this:


   Furthermore, this specification updates Section 4.3 of [RFC8029] as
   follows:

   OLD:

   The Router Alert IP Option of value 0x0 [RFC2113] for IPv4 or value
   69 [RFC7506] for IPv6 MUST be set in the IP header.

   NEW:

   The Router Alert IP Option of value 0x0 [RFC2113] for IPv4 or value
   69 [RFC7506] for IPv6 MUST NOT be set in the IP header.

   END

WDYT?

>
>
>
>>
>>> Hope you did a check on other instances of "alert" in RFC 8029.
>>>
>>>
>>>
> Dhruv: I hope you did that as it would be good to get you as an expert to
> review it.
>
>
>
>> --
>>>
>>> In one edit in Section 4, where you list the OLD text from RFC 8029, do
>>> not add a reference to RFC 1122 in OLD text as this should be as listed in
>>> RFC 8029. It is good that you added reference in the NEW text!
>>>
>>>
> Dhruv: When we quote the OLD text from RFC 8029, it should be verbatim. By
> adding reference RFC 1122 [RFC1122] is making a change. Please remove
> that in OLD text, and you can add it in NEW text.
>
GIM3>> Now I got it!

>
> Thanks!
> Dhruv
>
>
>
>> Thanks!
>>> Dhruv
>>>
>>