[RTG-DIR] 答复: [Pce] RTG Area review of draft-ietf-pce-pcep-inter-domain-p2mp-procedures

Quintin zhao <quintin.zhao@huawei.com> Wed, 28 May 2014 11:26 UTC

Return-Path: <quintin.zhao@huawei.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 69B8C1A0958 for <rtg-dir@ietfa.amsl.com>; Wed, 28 May 2014 04:26:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.851
X-Spam-Level:
X-Spam-Status: No, score=-1.851 tagged_above=-999 required=5 tests=[BAYES_50=0.8, HTML_MESSAGE=0.001, MIME_8BIT_HEADER=0.3, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.651, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z5RdTjTUg0vm for <rtg-dir@ietfa.amsl.com>; Wed, 28 May 2014 04:26:31 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9BAC91A00C6 for <rtg-dir@ietf.org>; Wed, 28 May 2014 04:26:29 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml204-edg.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BHI13543; Wed, 28 May 2014 11:26:24 +0000 (GMT)
Received: from LHREML403-HUB.china.huawei.com (10.201.5.217) by lhreml204-edg.china.huawei.com (172.18.7.223) with Microsoft SMTP Server (TLS) id 14.3.158.1; Wed, 28 May 2014 12:25:55 +0100
Received: from SJCEML702-CHM.china.huawei.com (10.212.94.48) by lhreml403-hub.china.huawei.com (10.201.5.217) with Microsoft SMTP Server (TLS) id 14.3.158.1; Wed, 28 May 2014 12:26:23 +0100
Received: from SJCEML701-CHM.china.huawei.com ([169.254.3.133]) by SJCEML702-CHM.china.huawei.com ([169.254.4.7]) with mapi id 14.03.0158.001; Wed, 28 May 2014 04:26:16 -0700
From: Quintin zhao <quintin.zhao@huawei.com>
To: Loa Andersson <loa@pi.nu>
Thread-Topic: [Pce] RTG Area review of draft-ietf-pce-pcep-inter-domain-p2mp-procedures
Thread-Index: AQHPbzxCl8goaL8tsU2I9E9oDS3QC5tAkrEAgBU8JVA=
Date: Wed, 28 May 2014 11:26:14 +0000
Message-ID: <11208E03C9803E4CB4C3D898F153D6C03078E385@SJCEML701-CHM.china.huawei.com>
References: <53730A82.7000606@pi.nu> <CAB75xn5ewKgu-motzQEKJCXDQ_hbfWQrdn_21GXbUSOrHoqYUg@mail.gmail.com>
In-Reply-To: <CAB75xn5ewKgu-motzQEKJCXDQ_hbfWQrdn_21GXbUSOrHoqYUg@mail.gmail.com>
Accept-Language: en-US
Content-Language: zh-CN
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.45.19.91]
Content-Type: multipart/mixed; boundary="_004_11208E03C9803E4CB4C3D898F153D6C03078E385SJCEML701CHMchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: http://mailarchive.ietf.org/arch/msg/rtg-dir/BGWyE4tDi-z5odR3coDltO3UVew
X-Mailman-Approved-At: Wed, 28 May 2014 05:05:38 -0700
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-pce-pcep-inter-domain-p2mp-procedures.all@tools.ietf.org" <draft-ietf-pce-pcep-inter-domain-p2mp-procedures.all@tools.ietf.org>, "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>
Subject: [RTG-DIR] 答复: [Pce] RTG Area review of draft-ietf-pce-pcep-inter-domain-p2mp-procedures
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 May 2014 11:26:37 -0000

Dear Loa,



Thanks for your detailed review for this draft. Please see  our replies in-line. We have incorporated your comments into the new version attached here. Please let us know if you have further comments.



Quintin

-------------------------------------------------------------------------------------------------------------------------------------------
On Wed, May 14, 2014 at 11:47 AM, Loa Andersson <loa@pi.nu<mailto:loa@pi.nu>> wrote:
Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or
routing-related drafts as they pass through IETF last call and IESG
review, and sometimes on special request. The purpose of the review
is to provide assistance to the Routing ADs. For more information
about the Routing Directorate,please see
​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them
through discussion or by updating the draft.

Document: draft-ietf-pce-pcep-inter-domain-p2mp-procedures-06
Reviewer: Loa Andersson
Review Date: 2013-05-14
IETF LC End Date: couldn't find
Intended Status: Experimental

Summary:

This document is basically ready for publication, but has nits that should be considered

prior to publication.

Comments:
1. I like that an experimental RFC (for once) actually describe an
   experiment

2. The abstract says:
  "The ability to compute paths for constrained point-to-multipoint
   (P2MP) Traffic Engineering Label Switched Paths (TE LSPs) across
   multiple domains has been identified as a key requirement for the
   deployment of P2MP services in MPLS and GMPLS-controlled networks."

   Where was this defined (reference)?

RFC5671 but implicitly (section 3)


3. There are a couple of cases where words that ae in the 2119-language
   appear in the document in lower cases, please check if this is
   intended or if the normative language are intended.

4. For the terminology section it would be good to know which terms
   that are defined in this document for the first time, otherwise
   please give a reference to where to find the definition.

We will append terminology section -
   Terminology used in this document is consistent with the related
   MPLS/GMPLS and PCE documents [RFC4461], [RFC4655], [RFC4875],
   [RFC5376], [RFC5440], [RFC5441], [RFC5671] and [RFC5862].

   The additional terms Core-Tree, Leaf Domain, Path Tree, Path Domain
   Sequence, Path Domain Tree, Root Domain, Sub-Tree and Transit/branch
   Domain are further defined below.


5. This is possibly an oxymoron comment, but it seems to me that the
   problem statement (section 3) is too focused on describing how hard
   it is to solve the inter-domain P2MP path computation, rather than
   to describe what the problem are.
We will rename the section as Examination of Existing Mechanisms.


6. I'm a little bit concerned about the requirements, it seems that
   they are very close to design criteria.

7. Section 7.1 the concept "entry boundary nodes" are used, is this
   concept defined anywhere? For example from figure 2 I understand
   that L, W, P and T are entry boundary nodes, while D and E are not.

Entry boundary nodes is defined in 5441 etc.
But we specifically mean entry boundary node of the leaf/destination domain and this is L,W,P & T and not D & E.


8. I think it would be good have an H-PCE entry in the terminology
   section.

The document is fairly easy to read and quality is good, there is
sometimes a wish from the authors to bring through how dammed hard this
problem is to solve - they might be right - but there is a risk of
creating a lot of trees that stops you from seeing the forrest (or
maybe the other way around).

Major Issues:

None

Minor issues:

It seems that the document should lead up to a set of protocol
extensions, but in the the only change is to add the C-bit, right?

On the wire changes (message and object encoding) is limited.
There are necessary procedure changes.


Nits:

None - that are not captured in the comments above!


/Loa

--


Loa Andersson                        email: loa@mail01.huawei.com<mailto:loa@mail01.huawei.com>
Senior MPLS Expert                          loa@pi.nu<mailto:loa@pi.nu>
Huawei Technologies (consultant)     phone: +46 739 81 21 64

_______________________________________________
Pce mailing list
Pce@ietf.org<mailto:Pce@ietf.org>
https://www.ietf.org/mailman/listinfo/pce