Re: [RTG-DIR] RtgDir review: draft-ietf-pim-registry-03

Stig Venaas <stig@venaas.com> Mon, 31 January 2011 20:45 UTC

Return-Path: <stig@venaas.com>
X-Original-To: rtg-dir@core3.amsl.com
Delivered-To: rtg-dir@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 55C803A6C8E for <rtg-dir@core3.amsl.com>; Mon, 31 Jan 2011 12:45:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.395
X-Spam-Level:
X-Spam-Status: No, score=-102.395 tagged_above=-999 required=5 tests=[AWL=0.205, BAYES_00=-2.599, NO_RELAYS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cHROFWKBWUT1 for <rtg-dir@core3.amsl.com>; Mon, 31 Jan 2011 12:45:30 -0800 (PST)
Received: from ufisa.uninett.no (ufisa.uninett.no [IPv6:2001:700:1:2:158:38:152:126]) by core3.amsl.com (Postfix) with ESMTP id 934663A6C71 for <rtg-dir@ietf.org>; Mon, 31 Jan 2011 12:45:29 -0800 (PST)
Received: from [IPv6:2001:420:4:ea0c:954b:5606:be1f:6b0c] (unknown [IPv6:2001:420:4:ea0c:954b:5606:be1f:6b0c]) by ufisa.uninett.no (Postfix) with ESMTPSA id 193737FE6; Mon, 31 Jan 2011 21:48:42 +0100 (CET)
Message-ID: <4D47202C.5060005@venaas.com>
Date: Mon, 31 Jan 2011 12:48:44 -0800
From: Stig Venaas <stig@venaas.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7
MIME-Version: 1.0
To: Jamal Hadi Salim <hadi@mojatatu.com>
References: <AANLkTi=PaZc+OgTfWXZQh7Hw-6WHk90QBzEEtG46ZQe8@mail.gmail.com>
In-Reply-To: <AANLkTi=PaZc+OgTfWXZQh7Hw-6WHk90QBzEEtG46ZQe8@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: rtg-dir@ietf.org, draft-ietf-pim-registry.all@tools.ietf.org, rtg-ads@tools.ietf.org
Subject: Re: [RTG-DIR] RtgDir review: draft-ietf-pim-registry-03
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/rtg-dir>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jan 2011 20:45:31 -0000

Hi

Thanks for the review. I have now submitted revision 04 that I believe
takes care of your issues. See below.

On 1/17/2011 5:57 AM, Jamal Hadi Salim wrote:
> Hello,
>
> I have been selected as the Routing Directorate reviewer for this draft.
> The Routing Directorate seeks to review all routing or routing-related
> drafts as they pass through IETF last call and IESG review. The purpose
> of the review is to provide assistance to the Routing ADs. For more
> information about the Routing Directorate, please see
> http://www.ietf.org/iesg/directorate/routing.html
>
> Although these comments are primarily for the use of the Routing ADs, it
> would be helpful if you could consider them along with any other IETF
> Last Call comments that you receive, and strive to resolve them through
> discussion or by updating the draft.
>
> Document: draft-ietf-pim-registry-03
> Reviewer: Jamal Hadi Salim
> Review Date: 2011-01-17
> IETF LC End Date: 2011-01-20
> Intended Status: proposed standard
>
> Summary:
>
> I have some very minor concerns about this document that may need
> to be cleared before publication.
>
> Comments:
>
> The document is well written and structured to request IANA for
> the creation of a registry for PIM message types. The initial
> content specified on this document is based on existing RFCs.
> The document goes on to specify how new PIM message types should
> be allocated.
>
> Major Issues:
>
> No major issues found.
>
> Minor Issues:
> Although section 3.2 describes how the new types should be allocated,
> given that this document is the first time all allocated PIM message
> types are aggregated, it would be useful to also list the unassigned
> message types and summarize what 3.2 says. i.e.
>
>     Type   Name                                      Reference
>     ----  ----------------------------------------  ---------------------
>       0    Hello                                     [RFC3973] [RFC4601]
>       1    Register                                  [RFC4601]
>       2    Register Stop                             [RFC4601]
>       3    Join/Prune                                [RFC3973] [RFC4601]
>       4    Bootstrap                                 [RFC4601]
>       5    Assert                                    [RFC3973] [RFC4601]
>       6    Graft                                     [RFC3973]
>       7    Graft-Ack                                 [RFC3973]
>       8    Candidate RP Advertisement                [RFC4601]
>       9    State Refresh                             [RFC3973]
>      10    DF Election                               [RFC5015]
>      11-14 Unassigned at the moment                  Future IETF Review

I added

11-14 Unassigned      this document

>      15    Reserved (for extension of type space)    [this document]
>
> Nits:
>
> There is an interesting nit in that you have RFC 3973 as a normative
> reference (which sounds deserving in the context of this document)
> but that RFC is an experimental RFC.

I have now made them informative. I believe that is appropriate.

In addition I added the sentence:

The message type is a 4-bit integer with possible values from 0 to 15.

Stig

>
> cheers,
> jamal