[RTG-DIR] RtgDir Last Call review: draft-ietf-lsr-isis-fast-flooding

Loa Andersson <loa@pi.nu> Sat, 07 October 2023 16:32 UTC

Return-Path: <loa@pi.nu>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 01677C151069; Sat, 7 Oct 2023 09:32:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.907
X-Spam-Level:
X-Spam-Status: No, score=-1.907 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2dIr_zw-ZRLr; Sat, 7 Oct 2023 09:32:20 -0700 (PDT)
Received: from pipi.pi.nu (pipi.pi.nu [83.168.239.141]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2AB31C14E515; Sat, 7 Oct 2023 09:32:09 -0700 (PDT)
Received: from [192.168.1.241] (c-adee71d5.1063529-0-69706f6e6c79.bbcust.telenor.se [213.113.238.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: loa@pi.nu) by pipi.pi.nu (Postfix) with ESMTPSA id BA21735D1BF; Sat, 7 Oct 2023 18:32:06 +0200 (CEST)
Message-ID: <db42cf7c-0f5c-4543-8b9d-2e32074a27ab@pi.nu>
Date: Sat, 07 Oct 2023 18:31:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-CA
From: Loa Andersson <loa@pi.nu>
To: rtg-ads@ietf.org
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, draft-ietf-lsr-isis-fast-flooding.all@ietf.org, lsr-chairs <lsr-chairs@ietf.org>, lsr@ietf.org, loa@pi.nu
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/L_c9J_7QIsFsrVMB7OifUKM06UI>
Subject: [RTG-DIR] RtgDir Last Call review: draft-ietf-lsr-isis-fast-flooding
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Oct 2023 16:32:22 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. 
The Routing Directorate seeks to review all routing or routing-related 
drafts as they pass through IETF last call and IESG review, and 
sometimes on special request. The purpose of the review is to provide 
assistance to the Routing ADs. For more information about the Routing 
Directorate, please see https://wiki.ietf.org/en/group/rtg/RtgDir

Although these comments are primarily for the use of the Routing ADs, it 
would be helpful if you could consider them along with any other IETF 
Last Call comments that you receive, and strive to resolve them through 
discussion or by updating the draft.

Document: draft-ietf-lsr-isis-fast-flooding (the current version is -05)
Reviewer: Loa Andersson
Review Date: 2023-10-08
IETF LC End Date:
Intended Status: Experimental

Summary:

This document is basically ready for publication; I only found one issue 
- the number of authors listed.

Document Overview:
Current Link State Protocol Data Unit (PDU) flooding rates are much 
slower than what modern networks can support.  The use of IS-IS at 
larger scale requires faster flooding rates to achieve desired 
convergence goals.  This document discusses the need for faster 
flooding, the issues around faster flooding, and some example approaches 
to achieve faster flooding.  It also defines protocol extensions 
relevant to faster flooding.

Comments:

The draft is well-written and easy to read. I gone over the IANA 
Considerations and allocations, and not found anything that need to be 
addressed.

Major Issues:

Number of authors: There are 7 authors, that is more the the "allowed" 5 
authors.

I have no background why there 7 authors listed, this has to be 
addressed in some way:

- reduce the number of authors to five

- keep the number of authors at seven, and the Shepherd will have to
    address this in the SWU,

I have put this as a "major issue" since I don't know where to put it.

My personal opinion is that anyone that has contributed text to the 
document, and participated in the authors discussions, should be listed 
as an author.

"No minor issues found."

Nits:

The nits-tool only finds a  Miscellaneous warning:

-- The document date (5 September 2023) is 32 days in the past.  Is this
      intentional?

This warning is a bit annoying since it is impossible to avoid.

I have not found any other nits.


/Loa


-- 
Loa Andersson                        email: loa@pi.nu
Senior MPLS Expert                          loa.pi.nu@gmail.com
Bronze Dragon Consulting             phone: +46 739 81 21 64