Re: [RTG-DIR] RtgDir review:draft-ietf-mpls-ldp-gtsm-06.txt

["Carlos Pignataro (cpignata)" <[e-mail]>]

Thanks again for your review. 

Thumb typed by Carlos Pignataro.
Excuze typofraphicak errows

On May 25, 2012, at 4:05 PM, "Eric Gray" <[e-mail]> wrote:

> When I said it would be "cleaner", it was because your draft doesn't modify
> the rest of the TLV.
>  
> As a general rule, it is "cleaner" not to include anything that you are not
> modifying (beyond whatever you believe is minimal acceptable context).
>  
> If some later draft were to come along and modify - or  extend - some
> other part of the TLV, the issue would then be - does this later document
> update this one, or RFC 5036?
>  
> That could lead to a mess.  Which is pretty much what it means not to
> be "clean."
>  
> However, it doesn't seem terribly likely that someone else is going to alter
> another part of this TLV, so this is largely theoretical, and a minor issue.
>  
> As a secondary factor, the fact that you repeated the entire TLV meant
> that there were just that many other bits I had to make sure you didn't
> "typo" in some way, or make other (un)intended changes to.
>  
> From a point of view of readability, it should be relatively clear to anyone
> implementing these changes to their LDP implementation, where the flags
> field is in the modified TLV.  In fact, I suspect that - if you just showed the
> flags field, this would make the meaning clearer and easier to implement
> to many readers.
>  
> And this too is a minor issue.  For one thing, it is a matter of opinion.  As
> I mentioned in my other reply, it's okay with me if you don't want to adopt 
> any of the changes implied in my comments.
>  
> On your paraphrasing the quote about a picture being worth a thousand
> words, the jury's still out on just how true that is.  Different people think
> and comprehend in different ways.  For me, a picture is worthless unless
> the words are there to explain it.
>  
> --
> Eric
> 
> From: Carlos Pignataro [mailto:[e-mail]] 
> Sent: Friday, May 25, 2012 2:46 PM
> To: Eric Gray
> Cc: [e-mail]; BRUNGARD, DEBORAH A; [e-mail]; [e-mail]
> Subject: Re: RtgDir review:draft-ietf-mpls-ldp-gtsm-06.txt
> Importance: High
> 
> Eric,
> 
> Thanks much for your review! Please see inline.
> 
> On May 25, 2012, at 2:17 PM, Eric Gray wrote:
> 
>> 
>> 
>> Hello, 
>> 
>> I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing    or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://www.ietf.org/iesg/directorate/routing.html 
>> 
>> Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion    or by updating the draft. 
>> 
>> Document: draft-ietf-mpls-ldp-gtsm-06.txt 
>> Reviewer: Eric Gray
>> Review Date: 25-May-2012 
>> Intended Status: Standard 
>> 
>> Summary: 
>> 
>> No major issues found. This document is essentially ready for publication.
> 
> Sounds good.
> 
>> 
>> Comments: 
>> 
>> This document is mostly clearly written and easily understood.
> 
> Thanks. Is the "mostly" qualifying clearly written, easily understood, or both? :-) Where is specifically not? It seems the nits you bring up below are not clarifying meaning.
> 
>> 
>> Major Issues: 
>> 
>> No major issues found.
>> 
>> Minor Issues: 
>> ============
>> 
>> Because this draft defines only a new bit assignment as an update to RFC 5036, it 
>> would have been cleaner to have only included the flags field as shown here:
>> 
>> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>> |T|R|G|   Reserved              |
>> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> 
> Thank you for this suggestion. I feel however that furthering the packet context in which the bits reside adds much more to the clarity and removes ambiguity than this proposal. That is, the whole TLV in a figure is more clear than just 3 bits and a reserved without insertion point, and the figure exactly as from the RFC it is updating (RFC 5036) module the updated bit is more unambiguous and easier to find.
> 
>> 
>> To maintain readability, the draft should still say where this field is (that it
>> is part of the Common Hello Parameter TLV).   
> 
> A figure is worth how many words? :-)
> 
>> 
>> In addition, since the definitions of T and R are exactly as given in RFC 5036,
>> the text that currently repeats the definitions for T and R could better have 
>> been written as:
>> 
>> "T and R
>>   As specified in [RFC5036]."
> 
> Sure we could take the common denominator out, but the current form of the definition has more symmetry and rhyme while not wasting too many extra lines...
> 
>     T, Targeted Hello
>        As specified in [RFC5036].
> 
>     R, Request Send Targeted Hellos
>        As specified in [RFC5036].
> 
>     G, GTSM
> ...
> 
>> 
>> This way of representing the changes makes it clearer what the actual changes
>> are.  However, this is a very minor issue.
> 
> Perhaps clarity is relative. I feel that including the contextual fields graphically is more clear than describing it with words, and keeping a per-field list element seems more clear.
> 
> In any case I appreciate you taking the time to comment on this and proposing an alternate representation of those few lines.
> 
>> _________________________________________________________________________________
>> 
>> I am curious why the text under Figure 1 explicitly includes the possibility that 
>> an LSR might implement GTSM capability negotiation but not implement GTSM.  But, 
>> again, this is a very minor issue.
> 
> Do you mean the text immediately underneath Figure 1, or the last paragraph of Section 2.1? If the latter, this is based on an mpls wg review (Adrian's IIRC), which separates the support for GTSM from the understanding of the G bit. While I agree with you, I think the current text is OK because it is unambiguous and complete. 
> 
> Thanks also for pointing this out. I do not expect this will be the case but covering the base.
> 
>> _________________________________________________________________________________
>> 
>> NITs:
>> ====
>> 
>> In the abstract, "packets" should be "packet's."
> 
> Agreed. Changed in my working copy.
> 
>> 
>> First sentence, first paragraph under Figure 1 - "meaingful" should be "meaningful."
> 
> Wow, great catch! I thought I'd run idspell on this...
> 
>> 
>> Second sentence, second paragraph under Figure 1 - "but that it does not" should be
>> "but that does not."
> 
> Yes. Done in my working copy.
> 
> Thanks again for this review!
> 
> -- Carlos.
> 
>> 
>> --
>> Eric Gray
>> 
>> 
>> 
>