[RTG-DIR] RtgDir Review: draft-ietf-detnet-mpls-over-udp-ip
Harish Sitaraman <harish.ietf@gmail.com> Sun, 22 December 2019 19:03 UTC
Return-Path: <harish.ietf@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EEF55120110; Sun, 22 Dec 2019 11:03:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sTwc1DCQPkKm; Sun, 22 Dec 2019 11:03:18 -0800 (PST)
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 836B612010D; Sun, 22 Dec 2019 11:03:15 -0800 (PST)
Received: by mail-lf1-x135.google.com with SMTP id m30so11014669lfp.8; Sun, 22 Dec 2019 11:03:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=YJeu6UNhNkdwzIvlHTX8Q8vRdxYs4u4N33dieZF4HPI=; b=LTKa7oy9E8EPFUQ8XPD2jrTdgxq4FLMmWe8Vh6aed473yhfa1l1IlmdBjW3cAdQ+Im jUCmF1mfAA/ZOHpskI62BM8uWrRM6SGgm6H3NhRtU4Y8c2hKRjg/GFxplWlMJAbspuec giMof47ACVbJJJkYnOzSjUKAwB3izfVylseiyHg8a6m9zn8yyAnf7H+nGq4hY7iVKjTM r2AYTBsEiFAI0pCxZ+/30R34qCDDogsrXmGfQtom/TVuH/9/sQtwkzLXHACv5cY1FS3G HrnMca5iyld/MmP1YCPV6Mg3CtIA58dYc4atqqyAtiTLOJ47wvg4gCsjitpsdYJIjSvz UUPQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=YJeu6UNhNkdwzIvlHTX8Q8vRdxYs4u4N33dieZF4HPI=; b=UkJFGXoUVWzO0svMPJqjgoln/B+UAaRkdeEEekqZ0IOK5B3IB3ttPjlC9ZhnFLZoGB vL94J0l0Ghzas3cuR1xRz/8DrVoRCELFh2R0P8MSiseAykZi/u+M3DLYHEl4lLANEeDT jzwk03+TLDmOl8zoUNm60xcMlKFGeP7ttePQsel/QLsysOrpVY6mKXRIwGxd7OZfZHXW 5qOfhfw75HTwZAqp8Rlf3EvHg0kDuEPFkHUjbOhH/1qiFX+IGAIKmMw0pvSQ8NMzMmF7 g5J0Y94RK/gRi+xx4z/GkRq3H47wSS+BPpitMUhvhQAFj46K6ZCwRSvdxMXD0d8G5mhZ WNPQ==
X-Gm-Message-State: APjAAAUwbBUpwd55ewxC+6nKrWjgIjJwu+7UHCRkcQrdmI7w6RWQut1g r0jhK0GftWYFP2RIWEA0wlQmqbtxuNf7hQI6d5N9gtMC
X-Google-Smtp-Source: APXvYqwzdOfxOI/cugqSF3uiq8JzKrpMfecZluuVtkyjmjaMGdyB4+xNzbPFqgLvC+laBzAZOCaZtbfR+Dbwj2pediA=
X-Received: by 2002:a19:2d0d:: with SMTP id k13mr14435899lfj.12.1577041393188; Sun, 22 Dec 2019 11:03:13 -0800 (PST)
MIME-Version: 1.0
From: Harish Sitaraman <harish.ietf@gmail.com>
Date: Sun, 22 Dec 2019 11:03:02 -0800
Message-ID: <CAGEaP=tuigiEwPfM9xWz9jLg15xWt9N41x7mrqemi1dZC=e5Vw@mail.gmail.com>
To: rtg-ads@ietf.org
Cc: rtg-dir@ietf.org, draft-ietf-detnet-mpls-over-udp-ip.all@ietf.org, detnet@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/RE7nFnkg_Filk7QL3Wr5KshSOqA>
Subject: [RTG-DIR] RtgDir Review: draft-ietf-detnet-mpls-over-udp-ip
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Dec 2019 19:03:21 -0000
Hello, I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. Document: draft-ietf-detnet-mpls-over-udp-ip-04.txt Reviewer: Harish Sitaraman Review Date: Dec 22, 2019 IETF LC End Date: date-if-known Intended Status: Standards Track Summary: I have some minor concerns about this document that I think should be resolved before publication. Comments: The document is concise and focussed. I'm not as familiar with the work of the DetNet WG so I quickly skimmed through some of the related drafts. Major Issues: No major issues found. Minor Issues: Section 1, last paragraph: "These requirements are satisfied by the DetNet over MPLS Encapsulation described in [I-D.ietf-detnet-mpls] and they are partly satisfied by the DetNet IP data plane defined in [I-D.ietf-detnet-ip]" Please explicitly mention which subset of the requirements are satisfied by ietf-detnet-ip since the text mentions "partly satisfied"? For MPLS, it seems apparent since prior to listing the requirements, the text says "(these are a subset of the requirements for MPLS encapsulation listed in [I-D.ietf-detnet-mpls])". Section 3: "In case of aggregates the A-Label is treated as an S-Label and it too is not modified." I couldn't understand the usage of "aggregates" here - Is this referring to A-label used only at the aggregation end-point but not as dis-aggregation end-point? If there is not distinction, the maybe A-label can be clubbed into the previous sentence as not being modified. Section 4: "The headers for each outgoing packet MUST be formatted according to the configuration information and as defined in [RFC7510], with one exception. Note that the UDP Source Port value MUST be set to uniquely identify the DetNet flow." The MUST in the first sentence above is used along with an exception, which I think the next sentence "Note that..." clarifies on how the source port should be set. Would it be possible to remove "with one exception" and stitch the two sentences together to be more more precise? "This includes QoS related traffic treatment." - I assume this is IP ToS/DSCP and not MPLS EXP? Is traffic treatment relevant for receive processing in the next paragraph? Section 5: "e.g., via the controller or management plane" Would it be better to use "...via the controller plane [RFC8655]" since the next paragraph starts using controller plane? Nits: Section 4: "To support receive processing an implementation" - add a comma after 'processing'. It might be preferable to replace "receive processing" (I noticed a prior use in the DetNet MPLS draft and not in the base RFC) with "To support processing incoming DetNet MPLS over UDP/IP encapsulation..." to be specific. Section 4: The packet MUST then be handed as ^^^^^^^ Section 5: multiple sets of UPD/IP information ^^^^ needed to provided the traffic treatment => s/provided/provide ^^^^^^^^ Section 9, References: Re-run to pull in latest versions of drafts. -- Harish
- Re: [RTG-DIR] RtgDir Review: draft-ietf-detnet-mp… Balázs Varga A
- [RTG-DIR] RtgDir Review: draft-ietf-detnet-mpls-o… Harish Sitaraman
- Re: [RTG-DIR] RtgDir Review: draft-ietf-detnet-mp… Balázs Varga A