Re: [RTG-DIR] Rtgdir early review of draft-ietf-bess-extended-evpn-optimized-ir-04

[Wen Lin <[e-mail]>]

 Hi Nicolai,

Thanks a lot for your thorough review and valuable inputs. I have addressed your comments, and you can find my responses inline below, along with the updated draft in the latest diff:

Diff:     https://urldefense.com/v3/__https://author-tools.ietf.org/iddiff?url2=draft-ietf-bess-extended-evpn-optimized-ir-05__;!!NEt6yMaO-gk!C1ibVk6b22e_0MZKMMPzp0fY5g36TkykAkkXb53HLm1FnTTV98cykYEoA574Vr3ljMoXZIf-GgfVhWPRkCyp9gSb$<https://urldefense.com/v3/__https:/author-tools.ietf.org/iddiff?url2=draft-ietf-bess-extended-evpn-optimized-ir-05__;!!NEt6yMaO-gk!C1ibVk6b22e_0MZKMMPzp0fY5g36TkykAkkXb53HLm1FnTTV98cykYEoA574Vr3ljMoXZIf-GgfVhWPRkCyp9gSb$>

Wen



Juniper Business Use Only
From: Nicolai Leymann via Datatracker <[e-mail]>
Date: Wednesday, November 29, 2023 at 3:49 AM
To: [e-mail] <[e-mail]>
Cc: [e-mail] <[e-mail]>, [e-mail] <[e-mail]>
Subject: Rtgdir early review of draft-ietf-bess-extended-evpn-optimized-ir-04
[External Email. Be cautious of content]


Reviewer: Nicolai Leymann
Review result: Has Issues

Hi,

I have been selected to do a routing directorate “early” review of this draft:
https://urldefense.com/v3/__https://datatracker.ietf.org/doc/draft-ietf-bess-extended-evpn-optimized-ir__;!!NEt6yMaO-gk!GlhaPATHS2SyoyQSr-bVQRYUW88HKjEtwPu2RAlfy_2CZ-fhcMdcRchlv2x6OCh_TnWXLt5A3FgQJw$<https://urldefense.com/v3/__https:/datatracker.ietf.org/doc/draft-ietf-bess-extended-evpn-optimized-ir__;!!NEt6yMaO-gk!GlhaPATHS2SyoyQSr-bVQRYUW88HKjEtwPu2RAlfy_2CZ-fhcMdcRchlv2x6OCh_TnWXLt5A3FgQJw$>

The routing directorate will, on request from the working group chair,
perform an “early” review of a draft before it is submitted for
publication to the IESG. The early review can be performed at any time
during the draft’s lifetime as a working group document.

For more information about the Routing Directorate, please see
https://urldefense.com/v3/__https://wiki.ietf.org/en/group/rtg/RtgDir__;!!NEt6yMaO-gk!GlhaPATHS2SyoyQSr-bVQRYUW88HKjEtwPu2RAlfy_2CZ-fhcMdcRchlv2x6OCh_TnWXLt5UDfHfzw$<https://urldefense.com/v3/__https:/wiki.ietf.org/en/group/rtg/RtgDir__;!!NEt6yMaO-gk!GlhaPATHS2SyoyQSr-bVQRYUW88HKjEtwPu2RAlfy_2CZ-fhcMdcRchlv2x6OCh_TnWXLt5UDfHfzw$>

Document:
https://urldefense.com/v3/__https://datatracker.ietf.org/doc/draft-ietf-bess-extended-evpn-optimized-ir-04__;!!NEt6yMaO-gk!GlhaPATHS2SyoyQSr-bVQRYUW88HKjEtwPu2RAlfy_2CZ-fhcMdcRchlv2x6OCh_TnWXLt5_thqIog$<https://urldefense.com/v3/__https:/datatracker.ietf.org/doc/draft-ietf-bess-extended-evpn-optimized-ir-04__;!!NEt6yMaO-gk!GlhaPATHS2SyoyQSr-bVQRYUW88HKjEtwPu2RAlfy_2CZ-fhcMdcRchlv2x6OCh_TnWXLt5_thqIog$>
Reviewer: Nicolai Leymann Review Date: Nov 19, 2023 Intended Status: Standards
Track

Overall the draft is in good shape and extends the existing optimzed ingress
replication in multihoming scenarios. For such networks the draft  provides a
solution and also optimized ingress replication for the EVPN overlay.

The draft assumes that the reader is familiar with the details of the
underlying specs such as "Optimized Ingress Replication solution for EVPN".
There are a few things which would help to make the document more readable.

In general I recommend to extend abbreviation such as "A-D", "RNVE", "BD" (at
first occurence in the document).
Wen: Added in the terminology section
The first part of the draft describes
handling of BUM traffic, later BM is used (for Multicast/Broadcast) only; the
solution itself refers to BUM again. Please clarify a more in detail what the
solution/document is addressing.
Wen: Added the clarification that this document addresses BM traffic delivery with extended Optimized-IR. Also, I cleaned up relevant text accordingly.
Section 2 gives an detailed description of a
scenario used throughout the document but a figure as additional information
and reference would be really helpful to better understand the problem as well
as the solution (also because the scenario is referred from other sections such
as 4.2.1, making the draft hard to read).
Wen: Added a figure.

Other Nits:
Section 2 and following
  - inconsistent use of "split horizon" and "split-horizon"
  - inconsistent use of "extended optimized-IR" and "extended Optimized-IR" and
  "Extended Optimized-IR"
Wen: Fixed through the document.
Section 2.2
  - "[EVPN-AR] specifies an optimized ingress replication procedures for" to
    "[EVPN-AR] specifies an optimized ingress replication procedure" for
Wen: Fixed.
Section 3.1
  - "it MUST informs"
  - "it MUST inform"
  - "The changes in the control plane and forwarding [...] is further explained
  in detail in section 5.2." - "The changes in the control plane and forwarding
  [...] are further explained in detail in section 5.2." - "It may also applies
  to Unknown unicast traffic." - "It may also apply to Unknown unicast traffic.
Wen: Fixed all the above.

Section 3.2
  - consider explaining/extending "BD"
Wen: Added in the terminology section.

  - "Consider an EVPN NVO network with a tenant domain consists of a set of m
  AR-LEAFs in BD X: AR-LEAF1, AR-LEAF2, AR-LEAF3, ..."
    -> would be easier to understand with a figure showing the network being
    described
Wen: Added another figure.

Section 3.3
  - "The extended Optimized-IR procedures specified in this document greatly
  reduces ..."
    Rest of the section is written in a way that it's only one procedure but
    not several
Wen: Fixed.

Section 4.1.1
  - consider explaining/extending "EVI"
Wen: Added in the terminology section.

  - "EVPN Multicast Flags Extended Community" should be used consitently
  throughout the draft (vs. "multicast flags extended community")
Wen: Fixed