Re: [RTG-DIR] Rtgdir early review of draft-ietf-babel-hmac

Donald Eastlake <d3e3e3@gmail.com> Thu, 20 September 2018 00:17 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 26D0A130E11; Wed, 19 Sep 2018 17:17:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.748
X-Spam-Level:
X-Spam-Status: No, score=-1.748 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5Lht4HjLgfl3; Wed, 19 Sep 2018 17:17:18 -0700 (PDT)
Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EAEED124C04; Wed, 19 Sep 2018 17:17:14 -0700 (PDT)
Received: by mail-it0-x234.google.com with SMTP id h23-v6so10118028ita.5; Wed, 19 Sep 2018 17:17:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KRo5t0+dkdifrTWDiQ5phocvbXR7kwXQ5BNDwPtB1OE=; b=rRSvWaCN/GKAsNpLsUNqf1mT1Ms637n4m/7p2BEqhnt3KG26ggiohmj964Q+5yG2gx 83EmZ88P2Jhyp5Bjd0nywWzbsLVPkNTwQTjuXaryay9W8qgvgao0xEXeEkKDVpETXRD7 SCFE2q5uT73S11QiKb6ZC7rmY0z/Oh6DcXhSw3lze95aV/zEBIzzHYT5j2nNxIrLF/wS Poo+OEhaPHWY4UjEdDZuc4FduIMc2ZIoYx01Y+1rNxsj6JCea3OwOvFsJHolcFTgaxVw TsA6ioabObmcnXjRgUhlnYok3ZeUUJJQzlWVBJ9ywW1aimx6Gtsz/E7vGR8yc1JtckP3 ihAQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KRo5t0+dkdifrTWDiQ5phocvbXR7kwXQ5BNDwPtB1OE=; b=BkCuz+T8rKYFS+p5kqSuJ4Gh3SWto3VshR5XsTDLRH8sOie2nuwpZRBWrxqMnVyU7L 5JYLnzgtwfynH+adyfrV0EfwbzZ9S3+TO/hQ9tSDCtXKhmgN1ZZtFnzhtIeyA/DHTaYD Zh6pDHgQXfp8bcalPfO1rD0E8+PhZUCSaO4QlFrS9PbWyR/rPLL7bYUbhQHC+cuKQLVm MvhFCMCiLDwxNXDKQY6GQMRj7AMxpK1XvGmeB+ZfWf/7ed5UUbxWoNKaNq0jyMy1lP5v skioVj5Vv6TzAZkb6FITP2loTwaWG6J4KhtcFFWOLGn3O2vs3HaY38kJu59Ap+jRYlZo ID3Q==
X-Gm-Message-State: APzg51A4EFVBAeoonjsb4PKcruGiiHH94mGP7xhke5TlT0C+JE6Z5TyB g2XBOYcS5JRnTrZKzUhBqpbEdAbOwCYBJpfulkA=
X-Google-Smtp-Source: ANB0VdaPmFLa0bFQcvZFTXSLlqjTyTBXXuOUzOsyDD0Jve90Typ/mnI1HbiOtXb6eigjj++beWr0AsLcsQDLLj72qr4=
X-Received: by 2002:a24:7cc:: with SMTP id f195-v6mr339943itf.72.1537402634222; Wed, 19 Sep 2018 17:17:14 -0700 (PDT)
MIME-Version: 1.0
References: <8CCB28152EA2E14A96BBEDC15823481A1CD5B548@sjceml521-mbs.china.huawei.com>
In-Reply-To: <8CCB28152EA2E14A96BBEDC15823481A1CD5B548@sjceml521-mbs.china.huawei.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 19 Sep 2018 20:17:02 -0400
Message-ID: <CAF4+nEHJqT0oN8_weSi_a9-U=gR_BKEHaxbYygcVdHOkx80QLw@mail.gmail.com>
To: Michael McBride <Michael.McBride@huawei.com>
Cc: draft-ietf-babel-hmac@ietf.org, rtg-dir@ietf.org, babel-chairs <babel-chairs@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000e3c31505764271e2"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/oXcsY-V4aeNI5YdZs8G7Osx-JAY>
Subject: Re: [RTG-DIR] Rtgdir early review of draft-ietf-babel-hmac
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Sep 2018 00:17:19 -0000

Hi Mike,

Thanks for the review. OK if I forward to the babel WG mailing list?

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 1424 Pro Shop Court, Davenport, FL 33896 USA
 d3e3e3@gmail.com


On Wed, Sep 19, 2018 at 7:46 PM Michael McBride <Michael.McBride@huawei.com>
wrote:

> I have been selected to do a routing directorate “early” review of
> draft-ietf-babel-hmac.
>
>
>
> Document: draft-ietf-babel-hmac-00
>
> Reviewer: Mike McBride
>
> Review Date: 19-09-2018
>
>
>
> Intended Status: Standards Track
>
>
>
> Comments:
>
>
>
> I only found a few nits. Great job with the draft, especially being a 00.
> The nits that should be considered:
>
>
>
> 1.      Add a Terminology section to include HMAC, Babel, PC, etc
>
> 2.      1.1 Applicability Section: “The protocol defined in this document
> assumes that all interfaces on a given link are equally trusted and share a
> small set of symmetric keys (usually just one, two during key rotation).”
> Consider changing it to: “…(Typically one key. Two keys during a key
> rotation).” Otherwise it can read as “just one or two during key rotation”.
>
> 3.      4.2 Packet Transmission Section: “A Babel node may delay actually
> sending TLVs by a small amount…”. Consider giving an example of a small
> amount.
>
>
>
> Sound reasonable?
>
>
>
> mike
>