Re: draft-ietf-rtgwg-policy-model default reject-route

Chris Smiley <csmiley@amsl.com> Mon, 27 September 2021 23:20 UTC

Return-Path: <csmiley@amsl.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 10FEA3A10D4; Mon, 27 Sep 2021 16:20:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t5o1DAvF--oB; Mon, 27 Sep 2021 16:20:05 -0700 (PDT)
Received: from c8a.amsl.com (c8a.amsl.com [4.31.198.40]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 483E83A10C7; Mon, 27 Sep 2021 16:20:04 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by c8a.amsl.com (Postfix) with ESMTP id CAE6242C640B; Mon, 27 Sep 2021 16:20:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
Received: from c8a.amsl.com ([127.0.0.1]) by localhost (c8a.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VLp6dADyutZq; Mon, 27 Sep 2021 16:20:04 -0700 (PDT)
Received: from [192.168.1.16] (cpe-76-95-228-63.socal.res.rr.com [76.95.228.63]) by c8a.amsl.com (Postfix) with ESMTPSA id 85D6F428B4E8; Mon, 27 Sep 2021 16:20:04 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: draft-ietf-rtgwg-policy-model default reject-route
From: Chris Smiley <csmiley@amsl.com>
In-Reply-To: <7251E588-C833-4170-9002-079139608304@cisco.com>
Date: Mon, 27 Sep 2021 16:20:03 -0700
Cc: Kris Lambrechts <kris@netedge.plus>, "draft-ietf-rtgwg-policy-model@ietf.org" <draft-ietf-rtgwg-policy-model@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>, Alvaro Retana <aretana.ietf@gmail.com>, RFC Editor <rfc-ed@rfc-editor.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <544490BF-093A-4775-A293-95DADBCAC0BC@amsl.com>
References: <CAAEiB=0Y5tB+xDRnhi4=c9vrxWcj0HErEfE56r2KFi9NgEatRQ@mail.gmail.com> <7251E588-C833-4170-9002-079139608304@cisco.com>
To: "Acee Lindem (acee)" <acee@cisco.com>
X-Mailer: Apple Mail (2.3445.104.11)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/K7LGGnWCVeWe_Z2vvs2jJLs4iZw>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Sep 2021 23:20:10 -0000

Adding rfc-editor@rfc-editor.org


> On Sep 27, 2021, at 11:58 AM, Acee Lindem (acee) <acee@cisco.com> wrote:
> 
> Hi Kris, 
> I agree with your analysis and proposal. Do others have comment? If not,  we should remove during AUTH48 (Chris Smiley copied). 
> Thanks,
> Acee
> 
> On 9/17/21, 10:55 AM, "rtgwg on behalf of Kris Lambrechts" <rtgwg-bounces@ietf.org on behalf of kris@netedge.plus> wrote:
> 
>    Hi,
> 
>    I have been working on an implementation of
>    ietf-routing-policy@2021-08-12.yang and
>    ietf-bgp-policy@2021-07-11.yang and I'm struggling to implement a
>    pattern that I think is very common among routing policies.
> 
>    The problem I'm seeing is with the policy-result leaf under actions.
>    It is of type policy-result-type meaning that it can be either
>    accept-route or reject-route with a default of reject-route. As per
>    section 5.  Policy evaluation, all processing ends when either of
>    these is encountered. That would mean only one statement in a policy
>    can ever be processed. The first paragraph of section 5 suggests the
>    presence of those actions is optional however:
>> If the actions include either accept-route or reject-route actions, evaluation of the current policy definition stops, and no further policy statement is evaluated.
> 
>    In any vendor implementation I'm familiar with it is possible, and
>    common in practice, to combine actions (i.e. set a BGP community or
>    local-preference) from various statements which are processed in order
>    by either implicitly or explicitly continuing on to the next
>    statement.
> 
>    So my proposal here is to remove the default statement from the
>    policy-result, which would signify an implicit continuation to the
>    next statement. Or with the same net effect, you could add a
>    next-statement enum to the policy-result-types to make the choice
>    explicit.
> 
>    I feel like either change would make it much easier to write elegant,
>    compact and easy-to-understand policies (and to port existing
>    policies). Still, if this goes against your intended design, it would
>    be good to fix any wording in the draft that implies that these
>    actions are optional.
> 
>    Thank you,
> 
>    Kris Lambrechts
> 
>    _______________________________________________
>    rtgwg mailing list
>    rtgwg@ietf.org
>    https://www.ietf.org/mailman/listinfo/rtgwg
>