IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-ietf-rtgwg-yang-key-chain-17

Alissa Cooper <alissa@cooperw.in> Wed, 26 April 2017 17:05 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 62722126DDF; Wed, 26 Apr 2017 10:05:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.721
X-Spam-Level:
X-Spam-Status: No, score=-2.721 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=EVawIT4w; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=RPzXeEoc
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bWJoKNs0L2fw; Wed, 26 Apr 2017 10:05:06 -0700 (PDT)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0BF1E131518; Wed, 26 Apr 2017 10:05:06 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 7755B21C0A; Wed, 26 Apr 2017 13:05:05 -0400 (EDT)
Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Wed, 26 Apr 2017 13:05:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=oLGgU71r95Kza0LlJu 3POH2BBPeWbooEa6BjOMSvKSo=; b=EVawIT4w8Z6Qgp/eozreuuoDZuy2+t0Q0b CsMotjaZR9F2hbDbgMd0JAkeq8VNN4V0/q38t6oqkwy13GrBPR1lEl3Mn5x2no41 1IsIE56CnOkpzjmcDd2awZm3/Tk/0Xu8ro5JTSFIb748DaVRT1zhnJsatu1HFT5E c5t/eMfb6wF+yVuc+Hxdz6Nif9kk4WwQqeMGdfJr9PKdRojobXWSKyoCBhx7Hi84 trTlh7IARRItVuKNEw6p5o/J8Ee6MmTaE7DGEZhOVUhMUt1XWaH9sGloS67jGPhi 0E0uw5V8dujI+jlSfmWdjPqElYuS1vdiCLCkpqFXxUaS8h6HgFKg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=oLGgU71r95Kza0LlJu3POH2BBPeWbooEa6BjOMSvKSo=; b=RPzXeEoc KwOZFbQTqaqmFMGHGKgMnqb0mxHBdwv+7huMonJaHUuo0MbMRhEw7uS/T+8xdsY9 MMReU9PWGCIcdJ1WhfB2d16T9W1YTaUa3p2dWII2HUiVBQkg0NjesOtfNXBio3gQ zXKMzHhV374W4Aje2z+A0P58N6LuOvndRqmX0o18AhI8DciaRfFuv/STQdmbhagv HT2OM3tFgdk7ffhnQ8J9yUJYb1qesaWuQSNyMisc17pHWUtR1LyfXQeuoDQBJ2Ei BATGExUW8j5LkCvssKdh8C+mDH9TeSDyR4PKV5TwvBDKtIPoi0HGlL0DXLH/jmGG U6+9791aEaA/CQ==
X-ME-Sender: <xms:QdMAWfF420_kwV1NVRiyGcC0BgIqMwIb1jnXxO0myJ_iJ-3YyjaOIA>
X-Sasl-enc: Cs8pMiCu2xNUHMGqA9UZ/JI8Enkfh8ZH1VIkBpP6Xyob 1493226305
Received: from [10.24.116.101] (unknown [128.107.241.169]) by mail.messagingengine.com (Postfix) with ESMTPA id 68A0C7E0A4; Wed, 26 Apr 2017 13:05:04 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [Gen-art] Genart last call review of draft-ietf-rtgwg-yang-key-chain-17
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <149158793224.11224.1489071223626497682@ietfa.amsl.com>
Date: Wed, 26 Apr 2017 13:05:03 -0400
Cc: gen-art@ietf.org, draft-ietf-rtgwg-yang-key-chain.all@ietf.org, rtgwg@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <60BA3230-F2EF-4DDB-B9F0-694DBD674762@cooperw.in>
References: <149158793224.11224.1489071223626497682@ietfa.amsl.com>
To: Matthew Miller <linuxwolf+ietf@outer-planes.net>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/_Kav6sD5VjHW2xGNiW6EV9eZWc0>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Apr 2017 17:05:08 -0000

Matt, thanks for your review. Authors, thanks for your engagement with Matt. I have ballotted no-objection.

Alissa

> On Apr 7, 2017, at 1:58 PM, Matthew Miller <linuxwolf+ietf@outer-planes.net> wrote:
> 
> Reviewer: Matthew Miller
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-rtgwg-yang-key-chain-17
> Reviewer: Matthew A. Miller
> Review Date: 2017-04-07
> IETF LC End Date: 2017-04-07
> IESG Telechat date: 2017-04-13
> 
> Summary:
> 
> This document is almost ready to be published as a Proposed Standard,
> once the issues noted herein are resolved.
> 
> Major issues:
> 
> NONE
> 
> Minor issues:
> 
> * Forgive me for my limited knowledge of YANG, but is there a reason
> key-strings are only representable as either a YANG string or
> hex-string type, and not the YANG binary type?
> 
> * This document does not provide much guidance around AES key wrap
> other than it can be used and the KEK is provided
> out-of-band/-context.
> For instance, AES key-wrapped key-strings probably require using
> "hexidecimal-string".  Also, assuming I'm reading the model
> correctly,
> it appears this feature applies to the whole chain, which I think is
> worth calling out.
> 
> * This document warns against using the "clear-text" algorithm, which
> the
> reader is lead to understand is for legacy implementation reasons.
> However, is there not a similar concern with cryptographically weak
> algorithms, such as md5 and (arguably) sha1?
> 
> Nits/editorial comments:
> 
> * In Section 3.2. "Key Chain Model Features", the word "of" is
> missing
> between "configuration" and "an" in the phrase "support configuration
> an
> acceptance tolerance".
> 
> Non-nits:
> 
> * I note that idnits is calling out some odd spacing issues, but I
> think
> they are safe to ignore.
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email