[scim] Corrections to draft-ietf-scim-device-model

"Rohit Mohan (rohitmo)" <rohitmo@cisco.com> Thu, 18 January 2024 21:16 UTC

Return-Path: <rohitmo@cisco.com>
X-Original-To: scim@ietfa.amsl.com
Delivered-To: scim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 39ECEC14F6B5 for <scim@ietfa.amsl.com>; Thu, 18 Jan 2024 13:16:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.604
X-Spam-Level:
X-Spam-Status: No, score=-9.604 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ECAfMIxDshy7 for <scim@ietfa.amsl.com>; Thu, 18 Jan 2024 13:16:07 -0800 (PST)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 46BF6C14F6A7 for <scim@ietf.org>; Thu, 18 Jan 2024 13:16:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=3441; q=dns/txt; s=iport; t=1705612567; x=1706822167; h=from:to:subject:date:message-id:mime-version; bh=ca7JFjaET0RP22k3awxelG8YEj2S/blOTbBPpfWUQm0=; b=avC/JatR4zVhn0+BWlOaBDTUiuaKPJ0aq1d+2aWEqycntvUQi379PMib emGH2RHpF6ptHnXSJt4fOi5vuifi5pPNmH9O1D4jMoWHJabG6s97XcvTp w9CZSHGqLsCI3zpeoDqgqb4YzWGfrNkBvOkkPfgulmnHnvVqS6SlaoaVA E=;
X-CSE-ConnectionGUID: 10ygGNEyRECJuzeD593XGg==
X-CSE-MsgGUID: s7OWQrE4S/euI3Hfr2z64Q==
X-IPAS-Result: A0A0AQCpk6llmJ1dJa1agQklgSqBNjFSegKBBRKIZgOFLaAehlCBfg8BAQENAQE5CwQBAYUGAodFAiY0CQ4BAgQBAQEBAwIDAQEBAQEBAQEGAQEFAQEBAgEHBRQBAQEBAQEBAR4ZBQ4QJ4VsAQyGXnkBDHMnBBsagl4BghdIAwEQqXMBgUACiih4gTSBAYIWBbJ3BoFIhGeDNQGBToN9GoQ9JxuBSUSBV4YHAoFihBKCLwSFWJEVgU4jA30IbxsPHjcREBMNAwhuHQIxPAMFAwQyChIMCyEFE0IDQAZJCwMCGgUDAwSBMAUNGgIQLCYDAxJJAhAUAzgDAwYDCjEwVUEMUANlHzIJPA8MGgIbGw0nIwIsQAMREgIWAyQWBDQRCQsmAyoGNwISDAYGCV0mFgkEJQMIBANUAyN0EQMECgMUBwsHeIJ9A0QdQAMLbT01FBsFBIE2BZQreQGDIlNQo3ejQwqEEQWMAJVHF6kwZId5kFogjU2VV4R/AgQCBAUCDgEBBoFjOoFbcBWDI1EZD445g1+PeYExAgcLAQEDCYpnAQE
IronPort-PHdr: A9a23:PS69vhIxlYQ/gH3IHNmcua4yDhhOgF28FhQe5pxijKpBbeH4uZ/jJ 0fYo/5qiQyBUYba7qdcgvHN++D7WGMG6Iqcqn1KbpFWVhEEhMlX1wwtCcKIEwv6edbhbjcxG 4JJU1o2t2qjPx1tEd3lL0bXvmX06DcTHhvlMg8gPOP1G5LXiOy81vu5/NvYZAAbzDa4aKl5e Q2/th6Z9tFDm4ZgJ60tghfIuS5OfOJbhCtkcFmShB37oMy3+fZe
IronPort-Data: A9a23:9BohKKyKqzeMmMYiYUB6t+dFxirEfRIJ4+MujC+fZmUNrF6WrkVTm 2dOD2+PPK2KZmWnfIh1PYyw/EwA7JLSmNVkTldt+VhgHilAwSbn6Xt1DatR0we6dJCroJdPt p1GAjX4BJlpCCea/lH0auSJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kobVuKYw6TSCK13L4 Y6aT/H3Ygf/h2YtazJMscpvlTs21BjMkGJA1rABTagjUG/2zxE9EJ8ZLKetGHr0KqE88jmSH rurIBmRpws1zj91Yj+Xuu+Tnn4iHtY+CTOzZk9+AMBOtPTtShsaic7XPNJEAateZq7gc9pZk L2hvrToIesl0zGldOk1C3Fl/y9C0aJuoefWLleZnN2p4mbkbmnh76g/V3EZMthNkgp3KTkmG f0wMjsBaFWIgPi7hez9Qeh3jcNlJ87uVG8dkig/lneCUrB3GtaaHvqiCdxwhF/cguhUGvbfe 88eQTFudx/HJRZIPz/7Dbpnw73y3SevKmwwRFS9vvUQ3FHJ4VBKl7XwEYH1dMbQV5sJpxPNz o7B1z+kWk5BboP3JSC+2mmnh+rnnC7nVsQVDrLQyxJxqEeYympWAxoMWB7l5/K4kUW5HdlYL iT45xbCs4BrrF2kYf/QTieVi1yZrBMwBosLI8I1vVTlJrXv3y6VAW0NTzhkYdMgtdMrSTFC6 rNvt465bdCImODFIU9x5oupQSWO1T/5xFLuiAceRgcDptLkuox20FTET81oF+i+idid9dDML 9Ki8nVWa1Y71JJjO0CHEbbv2GPESn/hFVFd2+kvdjj5hj6Vnab8D2BS1XDV7OxbMKGSRUSbs X4PlqC2tb9WUM/VznLdH7hQRdlFAspp1hWB0DaD+LF8plyQF4KLLei8HRknfRg5bJxYEdMXS BaP5105CGBv0IuCNvIvPNnrVKzGPIDrFM/uUbjPf8FSb51qPA6B92cGWKJj9z6FraTYqolmY c3zWZ/1VR4yUP07pBLoHL11+eFwmUgDKZb7GMqTI+KPi+TOPRZ4iN4tbTOzUwzOxP3f/lSKr 4oEaaNnCXx3CYXDX8UeyqZKRXgiJnkgDpewoMtSHtNv6CI/cI39I5c9GY8cRrE=
IronPort-HdrOrdr: A9a23:3iUy/q0fU4As39jWtJJDlwqjBRRyeYIsimQD101hICG9Lfbo9P xGzc566farslcssSkb6K290cm7LU80hqQFnbX5XI3SFzUO11HYV72KgbGSpwEIeBeOvNK1t5 0QCZSWYeeYZTMV/KSKhTVQeOxQpuVvhZrY/ds2uE0dND2CBZsQiDtRO0KwKGEzbg9AApYyCZ qb4eR6hxfIQx4qR/X+LEMoG8zYqfP2tL+OW3M77hgchzWmvHeN0vrXAhKY1hARX3dk2rE561 XIlAT/++GKr+y74gW07R6e071m3P/ajvdTDs2FjcYYbh/2jByzWYhnU7qe+BgoveCU7kowmt WkmWZuAy0z0QKeQoiGm2qs5+DS6kds15Yk8y7bvZLXm725eNv9MbsFuWsWSGqc16NqhqAC7E sC5RPmi3MQN2KMoMw4jOK4ES2DUSGP0D0fuP9WgHpFXYQEbrhN6YQZ4UNOCZ8FWDn38YY9DY BVfbfhDdttACenhkrizx5S6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEBvo 3/Q+xVvaALStVTYbN2Be8HT8fyAmvRQQjUOGbXJVj8DqkIN3/Etpay6rQo4+OhfoAO0fIJ6d 38eUIdsXR3d1PlCMWI0pEO+hfRQH+lVTCo0c1a74gRgMyIeFMqC1zwdLkDqbrSnxxEOLyrZx +aAuMnP8Pe
X-Talos-CUID: 9a23:eThE9GrweRZhPS/gdpyXFgfmUZl9Y3Ly6lrBGWKTK3t7RZHIGASg16wxxg==
X-Talos-MUID: 9a23:VHAk+w650SDA9CbeMCKQu1aRxoxzvIORMVogza5BttSlbgx+IW2P0miOF9o=
X-IronPort-Anti-Spam-Filtered: true
Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by rcdn-iport-9.cisco.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2024 21:16:06 +0000
Received: from rcdn-opgw-3.cisco.com (rcdn-opgw-3.cisco.com [72.163.7.164]) by rcdn-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id 40ILG6MC018816 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <scim@ietf.org>; Thu, 18 Jan 2024 21:16:06 GMT
X-CSE-ConnectionGUID: q4tK4B8OQImhvXLQOWAaDg==
X-CSE-MsgGUID: VuGcSczPSlKq5zrIrIqxqA==
Authentication-Results: rcdn-opgw-3.cisco.com; dkim=pass (signature verified) header.i=@cisco.com; spf=Pass smtp.mailfrom=rohitmo@cisco.com; dmarc=pass (p=reject dis=none) d=cisco.com
X-IronPort-AV: E=Sophos;i="6.05,203,1701129600"; d="scan'208,217";a="10058120"
Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168]) by rcdn-opgw-3.cisco.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2024 21:16:06 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MKUav26gLqn1rRqSo/yna4JPG8o2ZsFkChsx9PmLGpAlJlWUhOmw5x1+YMuHLv2iIMv7q94S4cekL9NT7vmvldORvdflfONQWkiB800tUCAK7iaBsSENon+S0GhvLChHLpnTJ1YO+CaYaPiwAYiadFR8Nop3WnSs0mZKmTTG4RKeS+aQ4L454KTrEARZi9kh+bnwsKreUDBFt05Ew4V2jMrmsBks/zkdZ18qtEBaPqWsZqGPhioRbaaV5fKl8QlcgzZRHcPskmtYYa9FJGatgoMdH+ltrPYrO9QaA54gJG1S1h1290/gIdaCl6EVQoOtUzHmZ+FTuJPzLHnGOylF3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ca7JFjaET0RP22k3awxelG8YEj2S/blOTbBPpfWUQm0=; b=dhqjVCab5hmCsTolKYFPybnCH85vKmaMdVsXzVvi8u+RWXKQ40cR3TDyFRjn+dJqEK1KRUoMofwsP0z3r+JjPDiXkZysmYO4bPu7W+2iAz3t1c0IwhWObRLf+/oZfEzETxFTX1yPScUV1Men9orxja8hlT6f+/VSftuZa2frbJdUby1nHKmdYIk7jdto8iLuUWyHd0C8mt9Cvdq5RSB+nGeSV9OOFVJimP/qxZwqlvghbMLDhuXE6g/3eAN3thFQAwIhAax87Ejn7dXgfZPVXdZKNViecmkwnBm74nCZl+8gMIjxfzbauA5avuQ4jzwsGwlOe9nzqtQTTr/EoN3AwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
Received: from SN7PR11MB7019.namprd11.prod.outlook.com (2603:10b6:806:2ae::22) by DM4PR11MB6066.namprd11.prod.outlook.com (2603:10b6:8:62::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.23; Thu, 18 Jan 2024 21:16:04 +0000
Received: from SN7PR11MB7019.namprd11.prod.outlook.com ([fe80::a7a2:422d:88cd:b6e5]) by SN7PR11MB7019.namprd11.prod.outlook.com ([fe80::a7a2:422d:88cd:b6e5%4]) with mapi id 15.20.7202.024; Thu, 18 Jan 2024 21:16:04 +0000
From: "Rohit Mohan (rohitmo)" <rohitmo@cisco.com>
To: "scim@ietf.org" <scim@ietf.org>
Thread-Topic: Corrections to draft-ietf-scim-device-model
Thread-Index: AQHaSlCM8QakDzEdEE6xPxBSFasZcw==
Date: Thu, 18 Jan 2024 21:16:04 +0000
Message-ID: <SN7PR11MB701960D1178D41891EF84BB8AA712@SN7PR11MB7019.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SN7PR11MB7019:EE_|DM4PR11MB6066:EE_
x-ms-office365-filtering-correlation-id: f638b2c1-4713-4b59-2c27-08dc186aae19
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: fCFo9I71ijqBZJVWnNuLqKdETugeSzFH+ydV5SIzZLYhGlWCADV93/w/W1GJXcr0QYgk0TsM0BwPtpOqXZFIPK785T1HuSLwRLar6f2k4aeLwOqJrao3Qijw4l7Q2XQQrvXEotDvOa6l082Aqrs2i0RCzvauJ/BHYi1hIrHKQDLcEq2sQ1DNuM9WxH4ZX40LLur44xdPQ1hsyk4CVz1tMZjHdfFKQRMZ3021xjNV03T83K7kH6C+duPvZ0QH4nkbAsvvytd7PNii3APDHkpuQsCJANRdAKo5/4+j50EF4/tZleXxKOE4M16cON1UePMZ8yg/5D/3BtDJ48W4heN6fTGVYF1HEVCMK2vTMh0eqsBiNol0ro8DCq+WbFOiSt854CWUCN3ayta7eOplx1HSfFx4q3VLrTg56H797oFXE09jYBIbOmDBaTiMdjpeJEeE4YUeTqxrBBbsUezWVDv/B9KlyUgRNqSIk6XANjNzDXAKiHrkG2t8gWxY/8Y5tvQkiGBSBIzuA9rBGPeKGacxv1ZfDFb9Bfo91WQWJaf6PkmRMibd3z9I2A37wQ7uBHa4kxidfsHGzGPWaZR8CzitKUcO2r2zqS8Iut9rIJN7aoQ=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7019.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(396003)(136003)(39860400002)(366004)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(166002)(86362001)(122000001)(38100700002)(33656002)(83380400001)(55016003)(38070700009)(6506007)(9686003)(7696005)(76116006)(316002)(91956017)(478600001)(66476007)(6916009)(66556008)(64756008)(66446008)(4744005)(2906002)(66946007)(966005)(5660300002)(52536014)(8676002)(8936002)(71200400001)(41300700001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: LRPUbkjwZ0DXMOGXqywHw4aC8slIPEGsf3LuAShYkrWz3u2De6TVs3Dsaho4Ljj5Wksh2MUQ2yf3okE5CATorW4L1wiik64YZHrovIYAKfAjXXvPoMoEHpJQ+31ItK5w08sTlAEMj6mjSwtM53oDaQgEE9pEhFezBBVNYF8t5rzO2o47usRl95FZLiCQ9OvjqFapxEfZLkgFqJaC+Pblo0VjavQDOASPVDPrrd1f7HZBTwYqa1uMe6R+EpNqmRTONnYGxSfzRMjsiq6u1HLU6Q3qWtK0MO1CcBrQWn5nSi1yQmXtHhhZn7kfTETv1sEnwmYjostn+IiPdmX9pDoqOs6Fak2K5obvG1sJaQH0U7tXdVrt7EJHbFvVq931OlkhK8pt21uJtK4Sb+P4MDjfKAOHsUd3dN61GNE2uABrdf+6gHvLmmLhF8o3SXVDNtbZkjyxLEnRR426cPmg3XXc744y7unDEtOr4jSN61Qf+tMUzM+M6wvo7MrUPujtBzTUjj1C5Jpe0axf8PhM7zVM2obCnejzETwhuFCOLcApEVCRbaIS5vuh9DfHCzTFL5vK1QQhZQM3kIk5Ueal6a1iNSk6ldLDlnMDocObpWNwTU9enKlxHl1tXakRHzfmfL13MK/tUMzqKe9PWTe5HmPjXJ+wiTujAPuJL/fFqsjSaJmKrOawDvVstMUCNm80HJuNzkMaF7NKC9T9D0XJQTgVGQaqKn5Xw9ro8Q7W+YBLj5+GgUxuEIjz1EJtvZ7CNLehdAjZdFq+fSrm67XIaQF6TugK09tdlYAmc4DOjooUywFP3Uv0cCwsSqCaxb+BNU9o6Lj2pcT21OlL7NDcnehELDeuliFVIrZ4VeB3wZZWebKauzQZsnQVsixln2NqwAFJQjVVPg0CDGRb8Vxqk7CAXv5ctCmw1chchp23EZz8Hwchf0kfSjReftxh7/g6gZIyJuTEYxbWk9IbNN1CRV9/xziBLsstjzkmD8vmqh62YAQObvM9c8KcgaWX24K68+QZVEl63qZARgmmM/VHi3d2Ny0cwPKVTehRfifxmSESgtzZm5fChlE74iqiYfgyY3F8mhMuESVQ2gV7DpoHRFrzuslyaeuBFWhXoNgqWb/jnWb9qVkkEDt6A89vND4K6S0TG9cP592+eJAJt3TJOkN965i9eBHCpHu2au2B3WTbkiJ0xELPDSq1IBoSVMtAj8yV5AVSNMpmvl4S9ZZ0z/gFMaJSqBFrXo65v7K3SuLNwmbbxA/TsZDSai72zcVMFmj7tSbSpK+OXDxSnKnmm3nWdal0exGAnNw2/RPiw+CyfD+//e29WYJoyWJkiDAMHQbX3mes42mntH3jQMiRlVPUoQwPOwIusk7JGnh6X8GvKX0YyLopr3blG7qVgqKBk6JmM7T7qLwpHKNP6/cCs6kfGQYOabchcktngDpeYZWlBa9eJtfBp33S8Y1Wd7w8mJTk/Uo/C4PG4cDODnM3EeKJvkgR0+0BtqX1kQUb/zxSY6P25FbzRkBGWkU7UbTRAUeOfZVg1VREk2Gfp83gw+q95O1UT6Z9jcEP8IuTvAQ4bbdnhl9Terdzd5X0j9SjBHZQ+RIaiORQG2jjzoh9zX1hG/cV/lphDMOJrsRP6W5xIzQaXyH2bGelFL4YXejiQOSGPqbUHgCOpqIlvdV56Jk7Uw==
Content-Type: multipart/alternative; boundary="_000_SN7PR11MB701960D1178D41891EF84BB8AA712SN7PR11MB7019namp_"
MIME-Version: 1.0
X-OriginatorOrg: cisco.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7019.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f638b2c1-4713-4b59-2c27-08dc186aae19
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2024 21:16:04.5838 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KXfM80Ewj3lDYvygQ3oDx5mXbmg5/n86Nw22e3s2L7cjTUbC6B9UkcdE+EileN9FMKfM4pJRju7nV/aFpTosnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6066
X-Outbound-SMTP-Client: 72.163.7.164, rcdn-opgw-3.cisco.com
X-Outbound-Node: rcdn-core-6.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/scim/yVXN-M7shB1YDpdHXRluoVlYPh8>
Subject: [scim] Corrections to draft-ietf-scim-device-model
X-BeenThere: scim@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Simple Cloud Identity Management BOF <scim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/scim>, <mailto:scim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/scim/>
List-Post: <mailto:scim@ietf.org>
List-Help: <mailto:scim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/scim>, <mailto:scim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2024 21:16:11 -0000

Hi everyone,

I have raised a pull request to correct some of the text in the draft to accurately reflect the device model schema.
Here is a link to the PR: https://github.com/iot-onboarding/scim-devices/pull/23

The `separateBroadcastAddress` was incorrectly marked as not multivalued in the table in the draft whereas it is a multivalued attribute in the schema. I would like to get your feedback on this and get this merged for the next revision of the draft.

Thanks,
Rohit