[secdir] Secdir last call review of draft-ietf-lamps-ocsp-nonce-03

Sean Turner via Datatracker <noreply@ietf.org> Tue, 01 September 2020 14:10 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Sean Turner via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
Cc: last-call@ietf.org, draft-ietf-lamps-ocsp-nonce.all@ietf.org, spasm@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <159896945131.15022.6534989576417116403@ietfa.amsl.com>
Reply-To: Sean Turner <sean@sn3rd.com>
Date: Tue, 01 Sep 2020 07:10:51 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/1TASQdslNtS__AuhT-L3fk8hk38>
Subject: [secdir] Secdir last call review of draft-ietf-lamps-ocsp-nonce-03

Reviewer: Sean Turner
Review result: Has Nits

The is short little document that put size constraints on the OCPS nonce
extension. In particular, it requires the nonce be between 1 and 32 octets
long. Since there's no bits on the wire changes, I think it's fine there's no
new ASN.1 module.

My technical nits include:

0. s2.1: Consider also throwing an error if the OCTET STRING is zero bytes in
length. You throw one if it's too long, but not if it's too short.

1. s2.1, 4th paragraph: Consider adding reference to RFC 4086 for randomness
requirements.

My editorial nits include:

0. Abstract: missing period at the end of paragraph.

1. s2.1, 3rd para: missing period at end of paragraph

2. s4: I think the indentation is off by a couple of characters.

[secdir] Secdir last call review of draft-ietf-la… Sean Turner via Datatracker
Re: [secdir] [lamps] Secdir last call review of d… Mohit Sahni