[secdir] Re: Telechat SECDIR Review of draft-ietf-lamps-pq-composite-sigs-15

[Mike Ounsworth <[e-mail]>]

Thanks Donald!

I just fixed that in github, so that's ready for a next rev.

(@Authors -- I also looked at draft-composite-kems and I don't see any overly-long lines there)


-Mike 

"Knowing is a barrier which prevents learning" -- Frank Herbert, Dune.


"An expert is a person who has found out by his own painful experience all the mistakes that one can make in a very narrow field.” -- Niels Bohr

On Thursday, March 26th, 2026 at 12:42 PM, Donald Eastlake <[e-mail]> wrote:

> Actually, I missed that there are five lines too long in the -15
> version of this draft. Should be easy to fix in the next rev. Here are
> the line numbers and lines:
> 
>     792:          Signature Label values are defined in the "Signature
> Label Values"
>     923:          Signature Label values are defined in the "Signature
> Label Values"
>     966:      if not ML-DSA.Verify( mldsaPK, M', mldsaSig,
> mldsa_ctx=Label ) then
>    1641:                           -- algorithm identifier dictates
> the format of
>    3336:          Signature Label values are defined in the "Signature
> Label Values"
> 
> Sorry,
> Donald
> ===============================
>  Donald E. Eastlake 3rd   [phone] (cell)
>  2386 Panoramic Circle, Apopka, FL 32703 USA
>  [e-mail]
> 
> On Thu, Mar 26, 2026 at 1:11 PM Donald Eastlake <[e-mail]> wrote:
> >
> > # Telechat SECDIR Review of draft-ietf-lamps-pq-composite-sigs-15
> >
> > I have reviewed this document as part of the security directorate's
> > ongoing effort to review all IETF documents being processed by the
> > IESG. These comments were written primarily for the benefit of the
> > security area directors. Document editors and WG chairs should treat
> > these comments just like any other last call comments.
> >
> > The summary of the review is Ready.
> >
> > This is a re-review of my previous review of -14 which is here:
> > https://datatracker.ietf.org/doc/review-ietf-lamps-pq-composite-sigs-14-secdir-lc-eastlake-2026-02-04/
> >
> > This draft specifies how to do hybrid signatures with ML-DSA as the
> > post-quantum algorithm and various traditional algorithms.
> >
> > ## Security Considerations
> >
> > This draft does a good job of covering all the bases. It explains the
> > hybrid signature concept and motivation well. The Security
> > Considerations Section appears to be thorough and comprehensive.
> >
> > ## Major/Minor Issues
> >
> > None.
> >
> > ## Nits
> >
> > All of the nits mentioned in my previous review have been corrected
> > and, as far as I can see, no new ones added.
> >
> >
> > I did not review Sections 7 and 8 or Appendices A through F.
> >
> > Thanks,
> > Donald
> > =============================
> >  Donald E. Eastlake 3rd   [phone] (cell)
> >  2386 Panoramic Circle, Apopka, FL 32703 USA
> >  [e-mail]
>