Re: [secdir] Secdir last call review of draft-ietf-anima-prefix-management-05

Brian E Carpenter <brian.e.carpenter@gmail.com> Fri, 06 October 2017 01:21 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A73DB133226; Thu, 5 Oct 2017 18:21:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QoRSRbH2cTKT; Thu, 5 Oct 2017 18:21:13 -0700 (PDT)
Received: from mail-pg0-x22e.google.com (mail-pg0-x22e.google.com [IPv6:2607:f8b0:400e:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 67B5613320B; Thu, 5 Oct 2017 18:21:13 -0700 (PDT)
Received: by mail-pg0-x22e.google.com with SMTP id p5so9156657pgn.7; Thu, 05 Oct 2017 18:21:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TiDHaVB+6LbQtkYH0DzJqGNjYt0vvgYTan7/tPyjlR0=; b=GLbt2jc14YJu1BC7Mt1r5ZZzCnhoW7E/zj4RNF1fZJrMjbbZVmg4/+yHgbPx7BAC1a XDnbj08XNe1dCS0HD9iSwYJvkkFIz6VtKOjOOgKMjSctXndbbYJngKpUwKRusLmndp6p 3l82J0dvMf/EhoBBq8cZZo1iAuBtLf4GkLL8SFqXNlVBdeH/xeX+8K5PFEefomL/+clf X2aTo2NGtoWRZutNzkujdj+Xxx646i62XfcOjn/MK5lSOSChYuQN5cUQinyKBDiQkjVs 43I4xRJEHzRIOEwFQ4Ua+PRjm2e4OWabipzL7tDdsnmGOrr3b+L5fL16aY2stq3vlF7Q NyUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=TiDHaVB+6LbQtkYH0DzJqGNjYt0vvgYTan7/tPyjlR0=; b=pQagclvBZMci0hLo1VBH7dSWzs+Nnm6u8n1XeATSK+NPgiOQG8bEpx1tOIGk9dzfyM K+b/aEDrH2XKQty9Q8EqZY8v7CUfDvYLrijiwZ8yYJaiAPAN6z5Fq3zGxeBYiggzW1ko Mu9BAbG/7DJMTszFTdIXsE1+lReKUFiTtTpioKdPKqVDn5lotGOW4Rpn2OhwusWqlch8 fiGpV+gTBsKpEYtlrakpNH841AUHvp3eEpBudMMHEdHcZVkweYxJpfSHskxkcEERkla6 TSBaV4Q8WjbokeDthv027Ik6hRF3YoxZuQCtYs+WyTu1TGhfPPjfwovX6Ey1XnGELMX1 bElA==
X-Gm-Message-State: AMCzsaWGGm8sZM9BOrs9L6CZCMkviihJeNJczidCn+xuiehn52C423Df x3ATZdoPP+/Ou5AFBxei3dcF8Q==
X-Google-Smtp-Source: AOwi7QAzwDAMmQcJT2rIShJQdibaEseMXO34HBxVwM7nX2wNo/Czy3sr+wxjfcrMmKrcPLtKmj27Rg==
X-Received: by 10.84.218.131 with SMTP id r3mr437255pli.271.1507252872640; Thu, 05 Oct 2017 18:21:12 -0700 (PDT)
Received: from ?IPv6:2406:e007:6d3c:1:28cc:dc4c:9703:6781? ([2406:e007:6d3c:1:28cc:dc4c:9703:6781]) by smtp.gmail.com with ESMTPSA id k67sm286655pga.46.2017.10.05.18.21.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Oct 2017 18:21:11 -0700 (PDT)
To: Russ Housley <housley@vigilsec.com>, secdir@ietf.org
Cc: draft-ietf-anima-prefix-management.all@ietf.org, anima@ietf.org
References: <150723455673.6154.11287987531699991961@ietfa.amsl.com>
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Organization: University of Auckland
Message-ID: <7ced8d26-61c8-be72-ff49-68051cb07607@gmail.com>
Date: Fri, 06 Oct 2017 14:21:18 +1300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <150723455673.6154.11287987531699991961@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/7t92uumUfaLXsP8pfksOnio4y0I>
Subject: Re: [secdir] Secdir last call review of draft-ietf-anima-prefix-management-05
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Oct 2017 01:21:14 -0000

Thnaks Russ, all valid comments. We'll take care of them
at the end of Last Call.

Regards
   Brian

On 06/10/2017 09:15, Russ Housley wrote:
> Reviewer: Russ Housley
> Review result: Has Issues
> 
> I reviewed this document as part of the Security Directorate's ongoing
> effort to review all IETF documents being processed by the IESG.  These
> comments were written primarily for the benefit of the Security Area
> Directors.  Document authors, document editors, and WG chairs should
> treat these comments just like any other IETF Last Call comments.
> 
> Document: draft-ietf-anima-prefix-management-05
> Reviewer: Russ Housley
> Review Date: 2017-10-05
> IETF LC End Date: 2017-10-12
> IESG Telechat date: Unknown
> 
> Summary: Has Issues
> 
> I did not review the state machines in detail.  I assume that others
> that are far more familiar with PIM have done s detailed review of them.
> 
> 
> No Major Concerns
> 
> 
> Minor Concerns
> 
> This document uses "DHCPv6-PD" and "DHCPv6 PD".  At first, I was going
> to recommend picking one spelling.  However, RFC 3633 does not define
> either of these.  So, some explanation is needed in addition to being
> consistent.
> 
> In Section 3, the document says that roles can be locally defined.  If
> I properly understood the rest of the document, this is just a indirect
> way to state the prefix size.  If I got that right, it would help to
> explain this to the reader as soon as possible.
> 
> In Section 3.2.1, please give some examples of device identities.  Are
> we talking about a serial number or something else?
> 
> In Section 4.1, the document says:
> 
>   It should decide the length of the requested prefix and request it by
>   the mechanism described in Section 6.
> 
> However, Section 6 talks about:
> 
>    ...  Thus it would be possible to apply an
>    intended policy for every device in a simple way, without traditional
>    configuration files.
> 
> I do not see how the mechanisms in Section 6 increases the allocation
> for a single router.  It seems to increase the allocation to all routers
> with a particular role.
> 
> 
> Nits
> 
> Throughout the document, I find that "administrator(s)" grabs my
> attention.  I suggest that "administrators" would be better for the
> reader.
> 
> In Section 1, please spell out the first use of "ASA".
> 
> In Section 3.1: s/with minimum efforts/with minimum effort/
> 
> 
>